From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 198F6A0613 for ; Thu, 29 Aug 2019 00:48:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4E421B94D; Thu, 29 Aug 2019 00:48:47 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84]) by dpdk.org (Postfix) with ESMTP id B4C551B94D; Thu, 29 Aug 2019 00:48:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHcydB3OPKA1ZQG7rC6ecP8plr3bqdNiN6edTTSflxM=; b=8lVtj3/aLrPDwczfsgxXy3JKwYCm8VEgntmQzM64v+UH7GQadlVIQUztJoryoKWfVgmDuW2T5W4D32JHgR51/LpXRaaI/Uy7ItOo6Hkwkj5rm9J8byb3uXR0ZauNNIL26v2lVlcFgY32FHYIxY4egn9J+a8Rbi133yAykPPCkEI= Received: from VI1PR08CA0169.eurprd08.prod.outlook.com (2603:10a6:800:d1::23) by AM5PR0801MB1844.eurprd08.prod.outlook.com (2603:10a6:203:39::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.20; Wed, 28 Aug 2019 22:48:43 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::205) by VI1PR08CA0169.outlook.office365.com (2603:10a6:800:d1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.14 via Frontend Transport; Wed, 28 Aug 2019 22:48:43 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.16 via Frontend Transport; Wed, 28 Aug 2019 22:48:41 +0000 Received: ("Tessian outbound d33df262a6a7:v27"); Wed, 28 Aug 2019 22:48:39 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0ff3f8d4932b.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.4.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id EA3FB0ED-4F73-45B9-A4D4-EF8C1BA52154.1; Wed, 28 Aug 2019 22:48:34 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2054.outbound.protection.outlook.com [104.47.4.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ff3f8d4932b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Wed, 28 Aug 2019 22:48:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c1YBgG9IG9A/LLvFTlJaS0rno/Q4FyjlYuVJlMBp3a3EuNVxBdzPfV9/wcmww61zyk9oV5TYIAhXIV1AgrSZIHTfNi2T078koljEwCBnqg7UUJiGdpLY2V2sRJDI3kFYpn/n0ULA1t2r95hxL08S98dz9DG6UakLN9s7/uszvOSF3O/Oq8gdzoC37FUXTO3VaBpBkE3jcTer6lRb2aK9k1YWoszfc5N5RMBNeX3UOzxEm65VNk0teu/H7RgBhRDkrOR20W8vmZoKOTWImEFYXe/5mcoabP0mQ0o/gPUjO60n76v4ej8PaULQtwFVqelbqKsdzj2G6HLlTO1vZyuvDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHcydB3OPKA1ZQG7rC6ecP8plr3bqdNiN6edTTSflxM=; b=ZxgOyxGmMBbiGV0hfF9bS96fTLPuC9lJHmOERh/9dixNYPj51RgwmLbGlYx+8ol7dxqLv72qWaU+lmnf/4wL67OtYXQuO6Umo31290ccjprNL1sYDKsRdXfKoDBch1qEXX8aXeIo0wB37oWD1eN2uyeJCbKhAubRlO8Qx8SOUZBmJ3XpMzoHBQkRzeuf//MD1kNgBf8wbeeqaq22Y9/VZ9vro1miZQQebI8dlmBjkGVU+tNIywmFBe+TuHYB0OcaSEPAtDVScDSIIeop1cXpHfXzScZoX0xGWqPQ13myP1I6JMxWvpUmDKayshgyi6/c+9pjm1ixfQnsUq915ON2zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHcydB3OPKA1ZQG7rC6ecP8plr3bqdNiN6edTTSflxM=; b=8lVtj3/aLrPDwczfsgxXy3JKwYCm8VEgntmQzM64v+UH7GQadlVIQUztJoryoKWfVgmDuW2T5W4D32JHgR51/LpXRaaI/Uy7ItOo6Hkwkj5rm9J8byb3uXR0ZauNNIL26v2lVlcFgY32FHYIxY4egn9J+a8Rbi133yAykPPCkEI= Received: from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by VE1PR08MB4990.eurprd08.prod.outlook.com (10.255.158.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Wed, 28 Aug 2019 22:48:31 +0000 Received: from VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128]) by VE1PR08MB5149.eurprd08.prod.outlook.com ([fe80::a8af:a9b8:4597:4128%3]) with mapi id 15.20.2178.023; Wed, 28 Aug 2019 22:48:31 +0000 From: Honnappa Nagarahalli To: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "qi.z.zhang@intel.com" , "bruce.richardson@intel.com" , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH 2/2] net/i40e: remove compiler barrier for aarch64 Thread-Index: AQHVUcQNVkWdJSkEe0u6SfL89MXHC6cRPt4A Date: Wed, 28 Aug 2019 22:48:31 +0000 Message-ID: References: <1565693011-33998-1-git-send-email-gavin.hu@arm.com> <1565693011-33998-3-git-send-email-gavin.hu@arm.com> In-Reply-To: <1565693011-33998-3-git-send-email-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9a7cc2bf-d5d9-4bf9-a871-3b022b55797d.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 4895acec-7d5d-4d8e-ac58-08d72c09dfd3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR08MB4990; X-MS-TrafficTypeDiagnostic: VE1PR08MB4990:|AM5PR0801MB1844: X-MS-Exchange-PUrlCount: 1 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 014304E855 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(979002)(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(189003)(199004)(33656002)(229853002)(2501003)(6116002)(3846002)(64756008)(66556008)(6306002)(446003)(110136005)(54906003)(8676002)(102836004)(81156014)(2906002)(7696005)(305945005)(7736002)(966005)(14454004)(74316002)(8936002)(478600001)(66066001)(4326008)(486006)(25786009)(26005)(53936002)(81166006)(99286004)(6506007)(71190400001)(71200400001)(6246003)(256004)(52536014)(9686003)(66946007)(11346002)(186003)(76116006)(6436002)(76176011)(5660300002)(476003)(86362001)(316002)(66476007)(55016002)(66446008)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB4990; H:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: ktoO9Uud2E4ync1NQ+LGdU+quRbowgyq8+QuudqQ0YlRIlW6/Bvg4Cwio0S2dXpdJ6Yyb/o1qaatQkSQn6wE8u5+jOqQlc1Dm7PirTu4hBPMt+SBbGgHROAxjYOgs6t9vegLlOT3IBRND2+HUa57Z1dpYLLWYUj6Y0wwN7CTTn4vUo/VPmnD4jaua6Qnpnwc0tA0i3IvBJ1gnxHSdInCtgUoWlxstBIKqPzqNMmob/GCGvhbtTkUgxl5kZe1r1G9NnQ0Xaf6Q3qxIYNITeqLeqhy0GbzmticUitvkKcjtdbU9eUsYicAqEKrX+0GOb6pHygWcKmbUwdn22blw/+epZVBo8jSIXKbEWwenwKeRqZXnNmFi8Zgw4F48sRaycn2wC5sWn3VacQ5Cw56yFnXm08JQ0FlSkVydArMj3B4KZc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4990 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(979002)(4636009)(346002)(396003)(39860400002)(136003)(376002)(2980300002)(189003)(199004)(33656002)(966005)(126002)(26005)(186003)(102836004)(55016002)(47776003)(66066001)(478600001)(6246003)(2906002)(305945005)(336012)(36906005)(229853002)(9686003)(52536014)(8936002)(63350400001)(74316002)(8746002)(8676002)(476003)(486006)(446003)(7736002)(356004)(11346002)(2501003)(81166006)(450100002)(5660300002)(81156014)(316002)(86362001)(14454004)(76130400001)(6306002)(110136005)(54906003)(76176011)(4326008)(50466002)(22756006)(70586007)(6116002)(70206006)(26826003)(3846002)(23726003)(99286004)(6506007)(25786009)(7696005)(63370400001)(46406003)(97756001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0801MB1844; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: ac81130b-a0fd-43f5-a0fe-08d72c09d997 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM5PR0801MB1844; NoDisclaimer: True X-Forefront-PRVS: 014304E855 X-Microsoft-Antispam-Message-Info: 06g5rJccCkoaS6OjGH7k+sRw03Y0kgIXFR0dL077Iq/7p3FXeZZrjCe5ImhoQm6LNuO7WM8om6IWD0SBQfFo9CmM+0waWT8szUbS8XFCH6Fn3s1hYOP7lsQ+aZ1z3GdePRnjVHVFuIgKKQFNAFBsaps4aw96Qvn9FaoPAlck0VpSPaVNS+n6m6CUa3WXmntSaaShnj8FcJDRx2/wnHpsRK+RQKDI8P7uTzY3mQg8pyhCP502CQp9weno+N9DZg+egyo7/LxVQZOIXHAWdCqYhami51Fsbf9Z9F/EjWAKIHKnvrm7KzkyTmFTka2MJnVZLlj0SwzeA9DWEPgkhGp7VsstDDnowXDOTSd2gfp7PBvbAnn6VUGC/RnFbH3Io7FBVwMLXc8Mjajn6GG4mDW0Sm8n/5wJIGsAVmTIlGArP5U= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2019 22:48:41.6522 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4895acec-7d5d-4d8e-ac58-08d72c09dfd3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1844 Subject: Re: [dpdk-stable] [PATCH 2/2] net/i40e: remove compiler barrier for aarch64 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" >=20 > As packet length extraction code was simplified,the ordering was not > necessary any more.[1] IMO, there is no relationship between the compiler barrier and [1] at least= on Arm platforms. I suggest we just say 'there is no reason for the compil= er barrier'. I think this compiler barrier is not required for x86/PPC as well. >=20 > 2% performance gain was measured on Marvell ThunderX2. > 4.3% performance gain was measure on Ampere eMAG80 >=20 > [1] http://mails.dpdk.org/archives/dev/2016-April/037529.html >=20 > Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") > Cc: stable@dpdk.org >=20 > Signed-off-by: Gavin Hu > Reviewed-by: Ruifeng Wang > Reviewed-by: Steve Capper > --- > drivers/net/i40e/i40e_rxtx_vec_neon.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c > b/drivers/net/i40e/i40e_rxtx_vec_neon.c > index 5555e9b..864eb9a 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c > +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c > @@ -307,9 +307,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, > struct rte_mbuf **rx_pkts, > rte_mbuf_prefetch_part2(rx_pkts[pos + 3]); > } >=20 > - /* avoid compiler reorder optimization */ > - rte_compiler_barrier(); > - > /* pkt 3,4 shift the pktlen field to be 16-bit aligned*/ > uint32x4_t len3 =3D > vshlq_u32(vreinterpretq_u32_u64(descs[3]), > len_shl); > -- > 2.7.4