From: Akhil Goyal <akhil.goyal@nxp.com> To: Adam Dybkowski <adamx.dybkowski@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "fiona.trahe@intel.com" <fiona.trahe@intel.com> Cc: "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [dpdk-stable] [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment Date: Thu, 21 May 2020 12:46:17 +0000 Message-ID: <VI1PR04MB3168E931BA6D7ABEBD76A6FDE6B70@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200521113817.3148-2-adamx.dybkowski@intel.com> > -----Original Message----- > From: Adam Dybkowski <adamx.dybkowski@intel.com> > Sent: Thursday, May 21, 2020 5:08 PM > To: dev@dpdk.org; fiona.trahe@intel.com; Akhil Goyal <akhil.goyal@nxp.com> > Cc: Adam Dybkowski <adamx.dybkowski@intel.com>; stable@dpdk.org > Subject: [PATCH v3 1/1] cryptodev: fix SHA-1 digest enum comment > > This patch fixes improper SHA-1 digest size in the enum comment > and also adds the note about HMAC-SHA-1-96. > > Fixes: 1bd407fac80b ("cryptodev: extract symmetric operations") > Cc: stable@dpdk.org > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com> > --- > lib/librte_cryptodev/rte_crypto_sym.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > b/lib/librte_cryptodev/rte_crypto_sym.h > index d9585ecd6..6fc3b8f59 100644 > --- a/lib/librte_cryptodev/rte_crypto_sym.h > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > @@ -269,9 +269,11 @@ enum rte_crypto_auth_algorithm { > /**< HMAC using MD5 algorithm */ > > RTE_CRYPTO_AUTH_SHA1, > - /**< 128 bit SHA algorithm. */ > + /**< 160 bit SHA algorithm. */ > RTE_CRYPTO_AUTH_SHA1_HMAC, > - /**< HMAC using 128 bit SHA algorithm. */ > + /**< HMAC using 160 bit SHA algorithm. > + * HMAC-SHA-1-96 can be generated by setting digest_size to 12. It should be 12 Bytes. And should specify where to set the digest size The name of the field in xform is digest_length and not digest_size. + /**< HMAC using 160 bit SHA algorithm. + * HMAC-SHA-1-96 can be generated by setting + * digest_length to 12 Bytes in auth/aead xforms. + */ > RTE_CRYPTO_AUTH_SHA224, > /**< 224 bit SHA algorithm. */ > RTE_CRYPTO_AUTH_SHA224_HMAC, > -- > 2.17.1
next prev parent reply other threads:[~2020-05-21 12:46 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <20200521113817.3148-1-adamx.dybkowski@intel.com> 2020-05-21 11:38 ` Adam Dybkowski 2020-05-21 11:44 ` Trahe, Fiona 2020-05-21 12:02 ` [dpdk-stable] [dpdk-dev] " Anoob Joseph 2020-05-21 12:46 ` Akhil Goyal [this message] 2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 0/1] " Adam Dybkowski 2020-05-21 14:48 ` [dpdk-stable] [PATCH v4 1/1] " Adam Dybkowski 2020-05-21 15:32 ` Akhil Goyal 2020-05-24 9:54 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VI1PR04MB3168E931BA6D7ABEBD76A6FDE6B70@VI1PR04MB3168.eurprd04.prod.outlook.com \ --to=akhil.goyal@nxp.com \ --cc=adamx.dybkowski@intel.com \ --cc=dev@dpdk.org \ --cc=fiona.trahe@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git