patches for DPDK stable branches
 help / color / Atom feed
From: Sachin Saxena <sachin.saxena@nxp.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Babu Radhakrishnan,
	AgalyaX" <agalyax.babu.radhakrishnan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Pattan, Reshma" <reshma.pattan@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	"Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue
Date: Thu, 31 Oct 2019 11:16:57 +0000
Message-ID: <VI1PR04MB4845EE570DE1C7681AED36F8E3630@VI1PR04MB4845.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8z3GoBpN8nPzVY+b5k+f6GA8f8pFjC6_wio+6CUr7ax5Q@mail.gmail.com>


> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, October 25, 2019 12:47 AM
> To: Sachin Saxena <sachin.saxena@nxp.com>
> Cc: Babu Radhakrishnan, AgalyaX <agalyax.babu.radhakrishnan@intel.com>;
> dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>; Hemant
> Agrawal <hemant.agrawal@nxp.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue
> 
> On Thu, Oct 3, 2019 at 10:43 AM Sachin Saxena <sachin.saxena@nxp.com>
> wrote:
> >
> >
> > > -----Original Message-----
> > > From: Babu Radhakrishnan, AgalyaX
> > > <agalyax.babu.radhakrishnan@intel.com>
> > > Sent: Tuesday, September 10, 2019 1:11 PM
> > > To: dev@dpdk.org
> > > Cc: Pattan, Reshma <reshma.pattan@intel.com>; Hemant Agrawal
> > > <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>;
> > > Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> > > stable@dpdk.org
> > > Subject: RE: [PATCH] bus/fslmc: fix for resource leak coverity issue
> > > Importance: High
> > >
> > > Hi,
> > >
> > > > -----Original Message-----
> > > > From: Babu Radhakrishnan, AgalyaX
> > > > Sent: Tuesday, September 10, 2019 1:01 PM
> > > > To: dev@dpdk.org
> > > > Cc: Pattan, Reshma <reshma.pattan@intel.com>;
> > > hemant.agrawal@nxp.com;
> > > > sachin.saxena@nxp.com; Parthasarathy, JananeeX M
> > > > <jananeex.m.parthasarathy@intel.com>; Babu Radhakrishnan, AgalyaX
> > > > <agalyax.babu.radhakrishnan@intel.com>; stable@dpdk.org
> > > > Subject: [PATCH] bus/fslmc: fix for resource leak coverity issue
> > > >
> > > > From: Agalya Babu RadhaKrishnan
> > > <agalyax.babu.radhakrishnan@intel.com>
> > > >
> > > > 1 issue caught by 344967
> > > > Leaked_storage: Variable sep going out of scope leaks the storage
> > > > it points to.
> > > >
> > > > When 'sep' is not null and sep_exist is 0, 'sep' is freed before
> > > > going out of scope of the function irrespective of 'addr' exists or not.
> > > >
> > > > Coverity Issue: 344967
> > > > Fixes: e67a61614d0b ("bus/fslmc: support device iteration")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Agalya Babu RadhaKrishnan
> > > > <agalyax.babu.radhakrishnan@intel.com>
> > > > ---
> > >
> > > if (strncmp("dpni", sep, 4) &&
> > >             strncmp("dpseci", sep, 6) &&
> > >             strncmp("dpcon", sep, 5) &
> > >             .....
> > >
> > > We think validation of device name is done using AND operator
> > > instead it should be done by OR operator.
> > > Please confirm
> > [Sachin Saxena] The purpose of this logic to confirm that one of the device
> name should match to supported list and as soon as one strncmp() matches
> the string it will return 0 and the control comes out of IF condition.
> > So, existing logic is correct.
> >
> 
> Should I understand this as a confirmation of the initial ACK?
> 
[Sachin Saxena] Yes. please consider it as ACK. Thank you.
> 
> --
> David Marchand


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10  7:30 [dpdk-stable] " Agalya Babu RadhaKrishnan
2019-09-10  7:41 ` Babu Radhakrishnan, AgalyaX
2019-10-03  8:43   ` Sachin Saxena
2019-10-24 19:17     ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-10-31 11:16       ` Sachin Saxena [this message]
2019-10-03  8:40 ` [dpdk-stable] " Sachin Saxena
2019-10-31 16:18 ` [dpdk-stable] [dpdk-dev] " David Marchand

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB4845EE570DE1C7681AED36F8E3630@VI1PR04MB4845.eurprd04.prod.outlook.com \
    --to=sachin.saxena@nxp.com \
    --cc=agalyax.babu.radhakrishnan@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox