From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0048.outbound.protection.outlook.com [104.47.0.48]) by dpdk.org (Postfix) with ESMTP id B50C1968; Thu, 14 Sep 2017 07:23:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mA98YbqW0cpt4ogsdjJzPDg7KtDW6stbc1bBhMEH9qM=; b=YydB2Cuxx3bz7ldo/69pPYkwqAwsftTdJ5RrIkLOxNCe5vbdeT6ieOnGEc1HTJw4eJL/CR16lQA8HfyzmfS8j+dClNUtQslsZPxtvbveBveGO7zfO282cLCAm9+Y65emrPTRDExEczG+neeAS7XqzgIbO1EcFCpREMlPdEJV2KI= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB3327.eurprd05.prod.outlook.com (10.170.238.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12; Thu, 14 Sep 2017 05:23:31 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::3c3c:8f27:30a1:cd59%13]) with mapi id 15.20.0056.010; Thu, 14 Sep 2017 05:23:31 +0000 From: Shahaf Shuler To: Yongseok Koh CC: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation Thread-Index: AQHTLMnK/VQlmGwRNEurtI+SqfOoA6Kz14wA Date: Thu, 14 Sep 2017 05:23:31 +0000 Message-ID: References: <7b6d42c0c5e1a04f8483b6546ea0b1db8fb7ceee.1505133966.git.shahafs@mellanox.com> <20170913195154.GA4263@yongseok-MBP.local> In-Reply-To: <20170913195154.GA4263@yongseok-MBP.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB3327; 6:gnA+ozFBBbOZm7CX4v1hNv4+D5qJgFiIomdkPZdPPmqwvAuY/4D2kBiTOzECrNE4Mh/dsKNUuvLVi9kWeGbP2aqhyHowI/l4VOnPOVKeVdbffi/AQgqfCczW4m1qlXLdfjrSmwq8fwwN/A4pHmeYKf3imao4TGzNGc1s1keXIcIe2EZ/prizNN2lP76tH/kWevsr/nyUfXMmRviYq+W2cIpG3pQ7L/Gmn0CFOxkPiHh5sQe6CTUG/yd5BoB2IktvaWVAD+WFegPhdVnWEArTNfAzkGYTri57YjOfzVT9lb4OBhH2eR7uFQz+yrBh0oetxUBond5jAaPoEEhoWwYOAw==; 5:fVKTSmDwZE7tmk7WZ/35TFw5aovW2LZMN9EpkyBK9/8m7xTCDVK7U/dw1FwVVPMAhtQLpsCegn4eQcDk452zMTYNx24ENcSaS+P1Nm+cTZ1TgbxppyTLuhHlyb3hwDBWr85UL/kqbDMxclgUqQCveA==; 24:8dqDSmPel/e3yf42DXghafbVSFXDCIKtG+XowpHzMALal3tDhFbtMtMlOs76bdhioXejYtEc6lJsRP3NviU+4GfM6s7dRONe7Whhrh/Nfu8=; 7:inVKXljKPMd0CphMPnLqjEa3rxxU3hkixMrsPz6T3ZmGp1yB2izI6FDfNQsuX67LZMFXtNPPK39BM0nwSNWD4n7LtCPx1mQdOEbeS4irvgAsT2J9IMNuR41Vywnxz8nb7izJloHUAfIAffny0qRMRMAVAjG4ODh7mvtf9mQndzVczlB/DveUJPpcdVTlYRx/m7gsMkEbGO8VnTKjqeqttwzWaFQ73BRBrlShOj8odHI= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: a69ca184-3a1e-4384-6104-08d4fb30bd41 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR05MB3327; x-ms-traffictypediagnostic: VI1PR05MB3327: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123564025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR05MB3327; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR05MB3327; x-forefront-prvs: 0430FA5CB7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(6009001)(346002)(376002)(189002)(199003)(377454003)(229853002)(305945005)(7736002)(14454004)(97736004)(5660300001)(7696004)(74316002)(2950100002)(25786009)(8936002)(66066001)(2900100001)(86362001)(6636002)(6116002)(3846002)(102836003)(81166006)(8676002)(68736007)(316002)(101416001)(54356999)(3280700002)(50986999)(3660700001)(81156014)(2906002)(53936002)(76176999)(33656002)(6436002)(4326008)(6506006)(9686003)(5250100002)(110136004)(105586002)(478600001)(6246003)(106356001)(189998001)(99286003)(54906002)(55016002)(6862004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB3327; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2017 05:23:31.7169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3327 Subject: Re: [dpdk-stable] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 05:23:34 -0000 Hi Yongseok, Wednesday, September 13, 2017 10:52 PM, Yongseok Koh: > > > > +/* Maximum number of DS in WQE. */ > > +#define MLX5_MAX_DS 63 > How about make it consistent with MLX5_MPW_DSEG_MAX by naming > MLX5_DSEG_MAX? >=20 It doesn't have the same meaning.=20 The MLX5_MPW_DSEG_MAX is to limit the number of mbuf segments (buf->nb_segs= ) for multi packet wqe. The inline part is taken into account differently= .=20 The MLX_MAX_DS is to limit the number data segments (i.e. MLX5_WQE_DWORD_SI= ZE) that could be set into a WQE. This includes everything (inline, ctrl se= g, eth seg, pointers). For the regular Tx burst there are many options for different inline sizes = which impact on the max number of mbuf segments possible.=20 BTW - am still not sure why we have the MLX5_MPW_DSEG_MAX limitation.=20