From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10079.outbound.protection.outlook.com [40.107.1.79]) by dpdk.org (Postfix) with ESMTP id B38E4728E; Mon, 22 Jan 2018 21:27:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Hog/XcwP33n5fcgL/4+Na13LeY4OJLidAidK4+rzOBc=; b=Mpv9jmqUQskX+Kas9DXg6wQD0debFV5D1c9Myfeknk4LumWu/Z/lv91JRFRfXJF+gcLW3h9ExnNFw+TadiGtBo+e7Us460nP+VtX28CxGsNuFCYzV37Q6iwEWBoMKbiprYOWhaJKeym8o024vjzWEiNx3JPKXikBWJVDTPtqQWs= Received: from VI1PR05MB3149.eurprd05.prod.outlook.com (10.170.237.142) by VI1PR05MB1805.eurprd05.prod.outlook.com (10.165.236.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Mon, 22 Jan 2018 20:27:47 +0000 Received: from VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c]) by VI1PR05MB3149.eurprd05.prod.outlook.com ([fe80::789c:3f06:bb88:e29c%13]) with mapi id 15.20.0428.019; Mon, 22 Jan 2018 20:27:47 +0000 From: Shahaf Shuler To: Olivier Matz , "dev@dpdk.org" , Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Yongseok Koh" CC: "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH v3 1/2] net/mlx5: fix return value of start operation Thread-Index: AQHTk31RxVHq2JykI02ffboZa/et5aOAV81Q Date: Mon, 22 Jan 2018 20:27:47 +0000 Message-ID: References: <20180119162517.4451-1-olivier.matz@6wind.com> <20180122123338.19806-1-olivier.matz@6wind.com> In-Reply-To: <20180122123338.19806-1-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.107] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR05MB1805; 7:+ijg5aYrjIA5Ht6lmqYTHiIwfa4EivD+KJZyx+10zZRoCECGjsywWan4tj4OkAMxhiGvb/5pFZ4sMeYWR0UPL2Qb2aNOXWtFZ0Xv8O1xdnzxwNP3DmH4FVk+uTJoMNEx0aO4vxI3BDilg5phTAMB6RJLSbe1sH5J/lX8jmIObPqF4GP7ytXXmWkdfXXR6pjOn7+5v+dCtiN/hMBWaNF6YOILiAN+5NSBhjJRqCjIH7hMl8boAFTk0tMkR3hQtxMT x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 0887cc38-5944-436a-3dcb-08d561d699c0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020); SRVR:VI1PR05MB1805; x-ms-traffictypediagnostic: VI1PR05MB1805: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231023)(2400081)(944501161)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR05MB1805; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR05MB1805; x-forefront-prvs: 0560A2214D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39380400002)(396003)(39860400002)(199004)(189003)(7696005)(81166006)(81156014)(99286004)(6116002)(3846002)(8936002)(66066001)(97736004)(6636002)(25786009)(2501003)(106356001)(110136005)(316002)(4326008)(105586002)(26005)(86362001)(2906002)(3280700002)(2900100001)(229853002)(74316002)(53936002)(7736002)(305945005)(33656002)(5660300001)(14454004)(59450400001)(6246003)(2950100002)(5250100002)(3660700001)(68736007)(6436002)(102836004)(9686003)(55016002)(76176011)(6506007)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB1805; H:VI1PR05MB3149.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ECMSMBSv4GXo8r0YL+kF1S/7U6pKnVJTZ5UxGFz05iD9jFGqwgErJePeywDflUVYLsVOiEM4RpfVLy7gR4ffyg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0887cc38-5944-436a-3dcb-08d561d699c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2018 20:27:47.1795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1805 Subject: Re: [dpdk-stable] [PATCH v3 1/2] net/mlx5: fix return value of start operation X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 20:27:51 -0000 Monday, January 22, 2018 2:34 PM, Olivier Matz: > On error, mlx5_dev_start() does not return a negative value as it is supp= osed > to do. The consequence is that the application > (ex: testpmd) does not notice that the port is not started and begins the= rxtx > on an uninitialized port, which crashes. >=20 > Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") > Cc: stable@dpdk.org >=20 > Signed-off-by: Olivier Matz > Acked-by: Nelio Laranjeiro Series applied to next-net-mlx, thanks.