From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Mordechay Haimovsky <motih@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx4: fix drop flow resources not freed
Date: Thu, 1 Feb 2018 08:40:19 +0000 [thread overview]
Message-ID: <VI1PR05MB3149FB270B83D8AED97DC295C3FA0@VI1PR05MB3149.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180131153141.1289-1-adrien.mazarguil@6wind.com>
Wednesday, January 31, 2018 5:33 PM, Adrien Mazarguil:
> Resources allocated for drop flow rules are not freed properly. This causes a
> memory leak and triggers an assertion failure on a reference counter when
> compiled in debug mode.
>
> This issue can be reproduced with testpmd by entering the following
> commands:
>
> flow create 0 ingress pattern eth / end actions drop / end port start all port
> stop all port start all port stop all quit
>
> The reason is additional references are taken when re-enabling existing flow
> rules, a common occurrence when rehashing configuration.
>
> Fixes: d3a7e09234e4 ("net/mlx4: allocate drop flow resources on demand")
> Cc: stable@dpdk.org
>
> Reported-by: Moti Haimovsky <motih@mellanox.com>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
Applied to next-net-mlx, thanks.
prev parent reply other threads:[~2018-02-01 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 15:54 [dpdk-stable] [PATCH] " Moti Haimovsky
2018-01-30 16:41 ` Adrien Mazarguil
2018-01-30 17:24 ` Adrien Mazarguil
2018-01-31 15:33 ` [dpdk-stable] [PATCH v2] " Adrien Mazarguil
2018-02-01 8:40 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR05MB3149FB270B83D8AED97DC295C3FA0@VI1PR05MB3149.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).