From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 829CCA04F1 for ; Wed, 17 Jun 2020 16:06:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6835258C4; Wed, 17 Jun 2020 16:06:28 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2079.outbound.protection.outlook.com [40.107.21.79]) by dpdk.org (Postfix) with ESMTP id B68C21E2B; Wed, 17 Jun 2020 16:06:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UWzLlv4wFR2vu9GyeqIdMm/5DqoVJcyXZGppPBB/AbsrIX2Bw3DwwDrLdOmM31qNdoIwxwoR8gZllgutZkPEhAFts7vFL69UO22Upyy0RTK7MNJng4CEuexBE6VuusXW4qi3y8+vnLLzYtTIfxptB/bCKmFN4Ab5RBm0f620yR4q+7p+0IL+mPrlPyTuM/WvQPQH9nIw8CnRiRoYL/CM9ULs09TKRFGJGe0bIb+LGp1MKerUg6SGjSQdlUVz1cVnQQCLRbSfHujrci7LrAYEx59stWHccRcuRSCuZAp0kZRTAdR6KroQi8w9ve9+d4bu2o5xwYjXfB5wiMn2VVMVZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7+vdTDkKKThWxrJ8rZjFdwIAK3Ntef9sS+drLOQTaw=; b=bYg/9qM81knza85yaKn3XV2ULbubsZ82wLhOJkIEVtrbV6+CIOhJbby3V2W8AukSRdobMEsqe0smJYcWMDFCcP9GdsL/mTT6XMRhethR8JxYOOfTdhEMbXXFQLmyNZwSgIGI/RbbFinkvpINykuUOlvxKtfjIa586JUsWhnvE+zFbWb45eR9u7zG/rZPaItQc/Zdqm5+3oaSF/9dIqbPo0WtvCbXIgkphtdL9PPcLotgwwYb8KWhxe42DCC9TAlRAl0b5w85GNFHRRqTTZuT6StzYpLpA+CvViveoY1c2kV+F8Yig6HWUAvYjJYNsK+5k5lw+SgqthFtotxVbBJNcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7+vdTDkKKThWxrJ8rZjFdwIAK3Ntef9sS+drLOQTaw=; b=C2YaAK62G9TiMhjkhK6hPfEVBk+UkNVSluI2etz8fFBTInsAJ3YXGWTnm8GC5e+Pl8qxwt6uQkS1MUHryN8zyyd7DFLhNr2P8x6XylPNdQKdX5xSkAM2I08FZDxkFUNYjYAaPBAeaPIKbAqLDlYwLaTI7KR+ohCCwhxhCWcF7N4= Received: from VI1PR05MB4192.eurprd05.prod.outlook.com (2603:10a6:803:4e::18) by VI1PR05MB4494.eurprd05.prod.outlook.com (2603:10a6:803:43::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Wed, 17 Jun 2020 14:06:24 +0000 Received: from VI1PR05MB4192.eurprd05.prod.outlook.com ([fe80::2d66:8a63:f90:4a86]) by VI1PR05MB4192.eurprd05.prod.outlook.com ([fe80::2d66:8a63:f90:4a86%5]) with mapi id 15.20.3088.028; Wed, 17 Jun 2020 14:06:24 +0000 From: Bing Zhao To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Jack Min , Dekel Peled Thread-Topic: [PATCH] net/mlx5: remove redundant newline Thread-Index: AQHWRK62GDrIMmA7M0CpxdWhuDikZKjc1ziQ Date: Wed, 17 Jun 2020 14:06:24 +0000 Message-ID: References: <20200617135325.9998-1-david.marchand@redhat.com> In-Reply-To: <20200617135325.9998-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [117.147.46.45] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4fff696d-b6f3-4095-6f30-08d812c79ef5 x-ms-traffictypediagnostic: VI1PR05MB4494: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1107; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wtdh6A0DJyUeSr+0C60cA89+oEqk6ZnzusPFk6lCExBVtproi0dszv3VJSD4iM98H6ZCbqtmPdQ6l2B4h8KBwb98Uy7FzIEQv5pv/ktBjxVLxuFaTRFef93vbyVCXD/2Z7Ij6qkysyJ33xMvEySqDy0ePU2WmJWOGjM1C8teFJPZUtg7XMKDLgIArk07hi76WsovKsyQlZm73gENZt4JSMxP9lbFwjl2Td1EFfSSBYWsmeikHzyTwUEnlEYlXrirv+K52oOFvqRENviPJjvIhsLhlV3XCy1vWEs0i9Yfwf9ODAdiB9/zHU6YPbzdFF2SDqjtEFfLaNrz+I7SAUvRug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB4192.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(76116006)(33656002)(66946007)(66476007)(66446008)(66556008)(64756008)(26005)(186003)(7696005)(316002)(107886003)(54906003)(83380400001)(86362001)(53546011)(6506007)(52536014)(8936002)(71200400001)(478600001)(110136005)(8676002)(2906002)(5660300002)(4326008)(9686003)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: igc/rAi61b8yvxRDo7PD9OwdKF50e6skbOXSSBblII/NR6nI0/AwUPPqGmhH/WEpdViFngt0GNRBW85eQjyqovFFVx2gb/34AEnjBpSG/KqBOnh29Ez4LRwHzoPJph4q+Ql/swatef0cIftHyB0mSD27hQ9FwKegrSADEVDuAmB/1kcEUhQueDH22157cZR7aOGMNyg2R81gNY0IVyPcqU/oRaU7B/K5ePKV5OhPcABW+7CebPjX14boQmwS6DDHpr9qAfoYNOCey1akL0E44PHk7z3mfSwFzTtAbC5Exz7MhkQN9u+HvaelCDXwLTOnGWWPlNVfVe5G4p55d+T+i2evdKmzRtcGPj5HlwBF3TG69wUcUILn2EgYK9D9g7xGv9+AUQ72v6sjAZYjNYB5vT1d+ZJ/kDCva5l7CBUdWIljTLuxMrH1hHlqItZs4is1bDdyzRZZF8a/cUe6gOlY8jt20+FbHX9ImDZIj9rYWPs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fff696d-b6f3-4095-6f30-08d812c79ef5 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 14:06:24.6622 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EXX81i9kh3EWRdHiAued1e6dVP0QmN9c9gmq2aozFCGoPXQ5VYWwZbw0/hVdMqZ2W5vsLMyCQ0X/RM6x3Dl4Qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4494 Subject: Re: [dpdk-stable] [PATCH] net/mlx5: remove redundant newline X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Yes, the newline should be removed. Many thanks. BR. Bing > -----Original Message----- > From: David Marchand > Sent: Wednesday, June 17, 2020 9:53 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Matan Azrad ; Shahaf > Shuler ; Slava Ovsiienko > ; Bing Zhao ; > Jack Min > Subject: [PATCH] net/mlx5: remove redundant newline >=20 > The DRV_LOG macro already appends a newline. >=20 > Fixes: 46287eacc1b1 ("net/mlx5: introduce hash list") > Fixes: 860897d2895a ("net/mlx5: reorganize flow tables with hash list") > Fixes: e484e4032332 ("net/mlx5: optimize tag traversal with hash list") > Fixes: 6801116688fe ("net/mlx5: fix multiple flow table hash list") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/mlx5/mlx5.c | 6 +++--- > drivers/net/mlx5/mlx5_utils.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 95a0f337fe..fe7ed4899a 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1062,7 +1062,7 @@ mlx5_alloc_table_hash_list(struct mlx5_priv > *priv) > snprintf(s, sizeof(s), "%s_flow_table", priv->sh->ibdev_name); > sh->flow_tbls =3D mlx5_hlist_create(s, > MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE); > if (!sh->flow_tbls) { > - DRV_LOG(ERR, "flow tables with hash creation > failed.\n"); > + DRV_LOG(ERR, "flow tables with hash creation failed."); > err =3D ENOMEM; > return err; > } > @@ -1146,7 +1146,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > if (!sh->flow_tbls) > err =3D mlx5_alloc_table_hash_list(priv); > else > - DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, > reuse\n", > + DRV_LOG(DEBUG, "sh->flow_tbls[%p] already created, > reuse", > (void *)sh->flow_tbls); > if (err) > return err; > @@ -1154,7 +1154,7 @@ mlx5_alloc_shared_dr(struct mlx5_priv *priv) > snprintf(s, sizeof(s), "%s_tags", sh->ibdev_name); > sh->tag_table =3D mlx5_hlist_create(s, > MLX5_TAGS_HLIST_ARRAY_SIZE); > if (!sh->tag_table) { > - DRV_LOG(ERR, "tags with hash creation failed.\n"); > + DRV_LOG(ERR, "tags with hash creation failed."); > err =3D ENOMEM; > goto error; > } > diff --git a/drivers/net/mlx5/mlx5_utils.c > b/drivers/net/mlx5/mlx5_utils.c index d29fbcbc83..6f3ba7ca49 100644 > --- a/drivers/net/mlx5/mlx5_utils.c > +++ b/drivers/net/mlx5/mlx5_utils.c > @@ -20,7 +20,7 @@ mlx5_hlist_create(const char *name, uint32_t > size) > if (!rte_is_power_of_2(size)) { > act_size =3D rte_align32pow2(size); > DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power > of 2, will " > - "be aligned to 0x%" PRIX32 ".\n", size, act_size); > + "be aligned to 0x%" PRIX32 ".", size, act_size); > } else { > act_size =3D size; > } > @@ -29,7 +29,7 @@ mlx5_hlist_create(const char *name, uint32_t > size) > /* Using zmalloc, then no need to initialize the heads. */ > h =3D rte_zmalloc(name, alloc_size, RTE_CACHE_LINE_SIZE); > if (!h) { > - DRV_LOG(ERR, "No memory for hash list %s > creation\n", > + DRV_LOG(ERR, "No memory for hash list %s creation", > name ? name : "None"); > return NULL; > } > @@ -37,7 +37,7 @@ mlx5_hlist_create(const char *name, uint32_t > size) > snprintf(h->name, MLX5_HLIST_NAMESIZE, "%s", > name); > h->table_sz =3D act_size; > h->mask =3D act_size - 1; > - DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is > created.\n", > + DRV_LOG(DEBUG, "Hash list with %s size 0x%" PRIX32 " is > created.", > h->name, act_size); > return h; > } > -- > 2.23.0