From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94196A0A03 for ; Sat, 16 Jan 2021 15:39:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E9D8140DCB; Sat, 16 Jan 2021 15:39:04 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by mails.dpdk.org (Postfix) with ESMTP id 7B4F4140DA7; Sat, 16 Jan 2021 15:39:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x5gdJ6dx+cgMugJmtzZBbQCyPczJpF/myjuZBj0QJEw=; b=uWeNFmbY1fFljvhsPeJZZVlfmbYOJUzFD/io47mDUgiKU5e/YOlrqLzSBnERtQ0BNKXaQDLVd4QAmBLDBVFXRRpCdIJHqiYjcz2fEHVvFbZD+LPSF4FejW+q5zguUWEIAOAu2rol+c3UPcm3s+HbntoUo+y/fl/3Nq1ujcZzXbE= Received: from MR2P264CA0164.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::27) by AM0PR08MB3636.eurprd08.prod.outlook.com (2603:10a6:208:d4::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Sat, 16 Jan 2021 14:39:00 +0000 Received: from VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:1:cafe::a0) by MR2P264CA0164.outlook.office365.com (2603:10a6:501:1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.13 via Frontend Transport; Sat, 16 Jan 2021 14:39:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT031.mail.protection.outlook.com (10.152.18.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12 via Frontend Transport; Sat, 16 Jan 2021 14:38:59 +0000 Received: ("Tessian outbound e989e14f9207:v71"); Sat, 16 Jan 2021 14:38:59 +0000 X-CR-MTA-TID: 64aa7808 Received: from d0d34989805e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E5DF15C3-715D-4266-B00C-F44D0919B42A.1; Sat, 16 Jan 2021 14:38:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d0d34989805e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 16 Jan 2021 14:38:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ENO4ZhlomrOj5uXTYmk+Duyh1zfT8YfWkDCXxCR1+8/QWnhN5L1+aeqUWMKO3E6vGLKhyVP5nJsOptRNNGy1i0hAP+IKgxyQDmBwX7j5ciemWjid4p7bcBB2U1O1vPgi6mvaR2bHghL7rPqRgbXweMwJqf0u/9wjjKp+uNBphHokB9exRqTvcCRYpTnPBcsGtO905A8e5kxzFfU5Vd/0yzb7WGyqUAiiMweE4tRnICJuTfwymMVXuTFi8bUeyiTtPDNmzhwHOG4SBagh8+QBmqHq2CH7srBCsbjD6YneDWH3sLkppYnxv45jFKE3gjW1jXoMkG3+gAaNPcVo3BLohQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x5gdJ6dx+cgMugJmtzZBbQCyPczJpF/myjuZBj0QJEw=; b=azyS1XNwlFkSoUSjcuIYX3WJOwY6Di8XgykW7hO5rUdm77Rm+N/dn3jNrsno1GPq3QLkyz+87qBetsreqCY98VqcxV7OUe+pOGvuhgWR84Cp4GDYgB/r9BIw/JVOM1fV/CdTKg08mD+vlwYqCX/PNaxsKMnqc25FlzW+B0o5m5Qf/5i0OiY91Z03oxaPXRRhWDkpEmDQdsUx3CP/LMKmAb9Owj9H8lAVldEu/4zbZmn9KRF72kU3WBR2vWgsF5r80CXIIkwAtPjy0+8/l0e0hS7TvBPxckg9XFo/hNAlm+eHLkz9G007Y2Fo1C6QNmXyKoUFmQHKJ/xkUo9OJe8yew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x5gdJ6dx+cgMugJmtzZBbQCyPczJpF/myjuZBj0QJEw=; b=uWeNFmbY1fFljvhsPeJZZVlfmbYOJUzFD/io47mDUgiKU5e/YOlrqLzSBnERtQ0BNKXaQDLVd4QAmBLDBVFXRRpCdIJHqiYjcz2fEHVvFbZD+LPSF4FejW+q5zguUWEIAOAu2rol+c3UPcm3s+HbntoUo+y/fl/3Nq1ujcZzXbE= Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com (2603:10a6:800:a0::10) by VE1PR08MB4768.eurprd08.prod.outlook.com (2603:10a6:802:ab::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Sat, 16 Jan 2021 14:38:46 +0000 Received: from VI1PR0802MB2351.eurprd08.prod.outlook.com ([fe80::b950:7a8:744:62bb]) by VI1PR0802MB2351.eurprd08.prod.outlook.com ([fe80::b950:7a8:744:62bb%10]) with mapi id 15.20.3763.014; Sat, 16 Jan 2021 14:38:45 +0000 From: Ruifeng Wang To: David Marchand , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "stable@dpdk.org" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Ciara Power , "thomas@monjalon.net" , nd Thread-Topic: [PATCH 1/3] net/hinic: restore vectorised code Thread-Index: AQHW60QhzBBMXI8dC0Wk4Pi4YBfsKqoqUA9A Date: Sat, 16 Jan 2021 14:38:45 +0000 Message-ID: References: <20210115134021.7391-1-david.marchand@redhat.com> <20210115134021.7391-2-david.marchand@redhat.com> In-Reply-To: <20210115134021.7391-2-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 84309435FE73A14CA9256C08EBABBA4D.0 x-checkrecipientchecked: true Authentication-Results-Original: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [203.126.0.112] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8bf0ad0c-e8bf-4c68-3dd0-08d8ba2c7637 x-ms-traffictypediagnostic: VE1PR08MB4768:|AM0PR08MB3636: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:2043;OLM:2043; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XPX43BXQKmO2VdCNEpMNtuCTRe4n7+62h3lK1YbCAckilIFGPQJE+rw8xgglsF5KGAlQkcpDcq5rLCqCDRzlutQjApybURDfBxHe6H2U0SJHg1dXL9iiObF7cyM6IEzzwFHeAvV4K4o3ak6hNPUzSZRQRmD6FLagaWgYQe0twQiCjOA7YIgU8+WecMMeSVq131RFQ4XRneXL//exLLtiAwcVw3jlBmlFu+JnKOf4Ci5yLdBFzNf1BiSA3ens+sCzjzrXpESSIDiSZv+yZJnXwyP/8Kyp/VGSbW6L7FTd+0m9w3DSl15BC3e20zEZ5unmik/OoYdpX1kc7nO13QxpLmRgKGHcmm+vlDiBkjz3/bUpNPfZkflJ/t2RL/CWJLegwZLP7yq+LndVOecUkndaX9yyfxnOAHg6OF5qgA3fr+xkuk7cU72LpC0P8pBVI+NAwpSQinIxbc5TTph+c2SZxQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0802MB2351.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(376002)(39850400004)(136003)(316002)(110136005)(54906003)(186003)(8936002)(26005)(71200400001)(83380400001)(33656002)(966005)(5660300002)(52536014)(86362001)(478600001)(7696005)(76116006)(2906002)(53546011)(6506007)(4326008)(66946007)(9686003)(66476007)(66556008)(64756008)(66446008)(8676002)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Vg++jgx3AvqAN46e9PJBiqxm102QIbx1n8nhc3dSPMNjtmqlATBgfGa0sk5h?= =?us-ascii?Q?3xyx5GT3Qt3DrFw8vo0ZlCVIRVm3GFHIts68HLPFoNIUnF9Mzmex5v063NCt?= =?us-ascii?Q?LC/oveH4tLaMyj0Owz+uoIWsP1LL0zL1rEPcNwbyGGU8KnSGT79XHmZ+VWel?= =?us-ascii?Q?K5R2ybrP8I8PqVZg8APDegNpHGgjKD6MWuiKkiBudfJQzVsqElO/skXUNr1e?= =?us-ascii?Q?fYq+Evw+0ybKoFYQ5lCx2Uda6UV21aUNi3LgiNb2HpqbHVuzVON6eWgOAOqu?= =?us-ascii?Q?PVV3fqIUNJK3QIemRK5J/JSpwXAdIIrGlaix3iL5WDNYtl0IDoNkOdRVGzwr?= =?us-ascii?Q?54S0KMs/vZUiISWhPZ8XrunmMoceP6tevFn6iMSN80wKXS9EshJHvKPv9Y0v?= =?us-ascii?Q?WeBi7d2wfbl6IZloiBLDVt4Dz1hE84E1DJYHjTfYWNE1HZAjE7bnWDDcJqTa?= =?us-ascii?Q?/wOU/uNJKJ+a+nDfiWlFCoh9ieIw+bPAIb0j67//M6jAONxotEMWP5KUNTE+?= =?us-ascii?Q?Jc723wNjJkhjn2TgTGKQ7dQMZlSgJCtlLXHSA2Qw7e3L6M1AtqrRW+vosAi6?= =?us-ascii?Q?A8LhVT5YFkZttnKRmRXEQFcNIYpWMB/dlJJ3XmjKQzO1JRLXosknLTrEMrHr?= =?us-ascii?Q?h5jb3Q0hQlueZe0Vkf7pcK+is/XC5QH2uAw07nKG0tEUeHWQNYc43rL9soF2?= =?us-ascii?Q?5EPmvIlIu/pzoIGslXysp9TuktIqFPkJyXd5XdJdxdrSPCdTAXGGaE2FutR5?= =?us-ascii?Q?LNJsVGwpr7pmCgNZKbhOILdtqADhoGZ/yZeynSuRqlIaxc8n5fOM+VzQYxRJ?= =?us-ascii?Q?4ICXpNwrusUUHn+MHYkZkmQ8YWLoQKwnQ7HteQEv9Bqu/c7qpg1iQ+7bu5r2?= =?us-ascii?Q?HmZLfn95NKTbqsaaO1aoR7dP7nz8q6OLaZVmcgEoa653BCac4mZNOHVlIm/b?= =?us-ascii?Q?VduzztX7pFQk0pCa6YqEeOblr4Wy5H8rxpvncka5hCk=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4768 Original-Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ee1e5f2-a904-4801-cfa1-08d8ba2c6dc8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0B4hXGEgft5NEwWTKNLM1cUVHHDpcTV8UBnslhnQHJCpdmGHOM4IvZifEVjmO4yWlc3G00hKYvmvOSkS6zz0bZMxi1OzBneYebLzHN9yuJsLpZSo24pTiSO2pPjP3S8Hn3GscSXXYyRmBvLiji8qPOgCt8ek8CR4EWoXARIMIHVjafYaCgTiNh9eAww89LrCnmHMmhb0YkfuHNvNdBpEGbCB3lANNasWWvj9ASeeSgOA+1XoqjbKizSudiZmnGYZTOYK13PExJSb9633C/5XlYm+ww5Z8W5JmzbHTu64g46bsz5r+9snNs0mV2XbU5IXENSm8UWMmrZYqQj+F5n+hIIfpzKQkuHLJd0ikIzDUa2EI5BNEqsZ/orZ7/4VxLJjPYV+cS60nLMGlYTRi8fW3vdPilga2MIeyiNzs/hNWeP+c2/dgu8JmIE4kGjyl2TkZq0a+qYcQxmsEqUgca+qOHEcM0S7Wfrjpz9kzvK2vxRPTFnhQxtZrXlFeLkKwd8hlc6MQ4Vxa6RlIahPssi50eBuLxf0JXFkkGOHjjoB8VY= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39850400004)(396003)(136003)(346002)(376002)(46966006)(966005)(8936002)(4326008)(450100002)(52536014)(8676002)(5660300002)(86362001)(356005)(7696005)(83380400001)(478600001)(82740400003)(316002)(110136005)(186003)(336012)(33656002)(70586007)(26005)(53546011)(6506007)(81166007)(54906003)(9686003)(2906002)(82310400003)(47076005)(55016002)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2021 14:38:59.5815 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bf0ad0c-e8bf-4c68-3dd0-08d8ba2c7637 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3636 Subject: Re: [dpdk-stable] [PATCH 1/3] net/hinic: restore vectorised code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: David Marchand > Sent: Friday, January 15, 2021 9:40 PM > To: dev@dpdk.org > Cc: ferruh.yigit@intel.com; stable@dpdk.org; Ziyang Xuan > ; Xiaoyun Wang > ; Guoyang Zhou > ; Ciara Power ; > Ruifeng Wang ; thomas@monjalon.net > Subject: [PATCH 1/3] net/hinic: restore vectorised code >=20 > Following make support removal, the vectorised code is not built anymore, > fix the build flag check. >=20 > Fixes: 3cc6ecfdfe85 ("build: remove makefiles") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > drivers/net/hinic/hinic_pmd_rx.c | 6 +++--- > drivers/net/hinic/hinic_pmd_tx.c | 10 +++++----- > 2 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/hinic/hinic_pmd_rx.c > b/drivers/net/hinic/hinic_pmd_rx.c > index a49769a863..842399cc4c 100644 > --- a/drivers/net/hinic/hinic_pmd_rx.c > +++ b/drivers/net/hinic/hinic_pmd_rx.c > @@ -4,7 +4,7 @@ >=20 > #include > #include > -#ifdef __ARM64_NEON__ > +#ifdef RTE_ARCH_ARM64 We can test '__ARM_NEON' which will be defined by compilers. https://developer.arm.com/documentation/ihi0053/latest/ > #include > #endif >=20 > @@ -762,7 +762,7 @@ void hinic_free_all_rx_mbufs(struct hinic_rxq *rxq) > static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le32, > volatile void *src_be32) > { > -#if defined(__X86_64_SSE__) > +#if defined(RTE_ARCH_X86_64) > volatile __m128i *wqe_be =3D (volatile __m128i *)src_be32; > __m128i *wqe_le =3D (__m128i *)dst_le32; > __m128i shuf_mask =3D _mm_set_epi8(12, 13, 14, 15, 8, 9, 10, @@ - > 770,7 +770,7 @@ static inline void hinic_rq_cqe_be_to_cpu32(void *dst_le3= 2, >=20 > /* l2nic just use first 128 bits */ > wqe_le[0] =3D _mm_shuffle_epi8(wqe_be[0], shuf_mask); -#elif > defined(__ARM64_NEON__) > +#elif defined(RTE_ARCH_ARM64) > volatile uint8x16_t *wqe_be =3D (volatile uint8x16_t *)src_be32; > uint8x16_t *wqe_le =3D (uint8x16_t *)dst_le32; > const uint8x16_t shuf_mask =3D {3, 2, 1, 0, 7, 6, 5, 4, 11, 10, diff --= git > a/drivers/net/hinic/hinic_pmd_tx.c b/drivers/net/hinic/hinic_pmd_tx.c > index 9d0264e67a..669f82389c 100644 > --- a/drivers/net/hinic/hinic_pmd_tx.c > +++ b/drivers/net/hinic/hinic_pmd_tx.c > @@ -7,7 +7,7 @@ > #include > #include > #include > -#ifdef __ARM64_NEON__ > +#ifdef RTE_ARCH_ARM64 > #include > #endif >=20 > @@ -203,7 +203,7 @@ >=20 > static inline void hinic_sq_wqe_cpu_to_be32(void *data, int nr_wqebb) {= - > #if defined(__X86_64_SSE__) > +#if defined(RTE_ARCH_X86_64) > int i; > __m128i *wqe_line =3D (__m128i *)data; > __m128i shuf_mask =3D _mm_set_epi8(12, 13, 14, 15, 8, 9, 10, @@ - > 217,7 +217,7 @@ static inline void hinic_sq_wqe_cpu_to_be32(void *data, > int nr_wqebb) > wqe_line[3] =3D _mm_shuffle_epi8(wqe_line[3], shuf_mask); > wqe_line +=3D 4; > } > -#elif defined(__ARM64_NEON__) > +#elif defined(RTE_ARCH_ARM64) > int i; > uint8x16_t *wqe_line =3D (uint8x16_t *)data; > const uint8x16_t shuf_mask =3D {3, 2, 1, 0, 7, 6, 5, 4, 11, 10, @@ -237= ,7 > +237,7 @@ static inline void hinic_sq_wqe_cpu_to_be32(void *data, int > nr_wqebb) >=20 > static inline void hinic_sge_cpu_to_be32(void *data, int nr_sge) { -#if > defined(__X86_64_SSE__) > +#if defined(RTE_ARCH_X86_64) > int i; > __m128i *sge_line =3D (__m128i *)data; > __m128i shuf_mask =3D _mm_set_epi8(12, 13, 14, 15, 8, 9, 10, @@ - > 248,7 +248,7 @@ static inline void hinic_sge_cpu_to_be32(void *data, int > nr_sge) > *sge_line =3D _mm_shuffle_epi8(*sge_line, shuf_mask); > sge_line++; > } > -#elif defined(__ARM64_NEON__) > +#elif defined(RTE_ARCH_ARM64) > int i; > uint8x16_t *sge_line =3D (uint8x16_t *)data; > const uint8x16_t shuf_mask =3D {3, 2, 1, 0, 7, 6, 5, 4, 11, 10, > -- > 2.23.0