Re: [dpdk-stable] please help backporting some patches to LTS release 18.11.11

[Ruifeng Wang <Ruifeng.Wang@arm.com>]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, November 25, 2020 4:24 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dpdk stable <stable@dpdk.org>; Ajit Khaparde
> (ajit.khaparde@broadcom.com) <ajit.khaparde@broadcom.com>;
> Akhil.goyal@nxp.com; Alexander Kozyrev <akozyrev@mellanox.com>;
> Anatoly Burakov <anatoly.burakov@intel.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; Ankur Dwivedi <adwivedi@marvell.com>;
> Apeksha Gupta <apeksha.gupta@nxp.com>; Archana Muniganti
> <marchana@marvell.com>; Beilei Xing <beilei.xing@intel.com>; Bernard
> Iremonger <bernard.iremonger@intel.com>; Brian Johnson
> <brian.johnson@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Chenbo Xia <chenbo.xia@intel.com>;
> Chengchang Tang <tangchengchang@huawei.com>; Chenxu Di
> <chenxux.di@intel.com>; Chunsong Feng <fengchunsong@huawei.com>;
> David Marchand <david.marchand@redhat.com>; Dekel Peled
> <dekelp@mellanox.com>; Dharmik Thakkar <Dharmik.Thakkar@arm.com>;
> Didier Pallard <didier.pallard@6wind.com>; Erik Gabriel Carrillo
> <erik.g.carrillo@intel.com>; Fady Bader <fady@mellanox.com>; Fan Zhang
> <roy.fan.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>;
> Gagandeep Singh <g.singh@nxp.com>; Gregory Etelson
> <getelson@mellanox.com>; Guinan Sun <guinanx.sun@intel.com>; Guy
> Tzalik <gtzalik@amazon.com>; Hailin Xu <hailinx.xu@intel.com>; Harman
> Kalra <hkalra@marvell.com>; hemant.agrawal@nxp.com; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Huisong Li
> <lihuisong@huawei.com>; Igor Chauskin <igorch@amazon.com>; Igor
> Romanov <igor.romanov@oktetlabs.ru>; Jack Min <jackmin@mellanox.com>;
> Jeff Guo <jia.guo@intel.com>; Jesse Brandeburg
> <jesse.brandeburg@intel.com>; Jiaqi Min <jiaqix.min@intel.com>; Jun W
> Zhou <junx.w.zhou@intel.com>; Kalesh AP <kalesh-
> anakkur.purayil@broadcom.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Lance Richardson
> <lance.richardson@broadcom.com>; Lijian Zhang <Lijian.Zhang@arm.com>;
> Long Li <longli@microsoft.com>; Luca Boccassi <bluca@debian.org>; Lunyuan
> Cui <lunyuanx.cui@intel.com>; Matan Azrad <matan@mellanox.com>;
> Matan Azrad <matan@nvidia.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Michael Baum <michaelba@nvidia.com>;
> Michal Krawczyk <mk@semihalf.com>; Min Hu <humin29@huawei.com>;
> Min Wang <wangmin3@huawei.com>; Mohsin Shaikh
> <mohsinshaikh@niometrics.com>; Morten Brørup
> <mb@smartsharesystems.com>; Nan Chen <whutchennan@gmail.com>;
> Nikhil Rao <nikhil.rao@intel.com>; Nipun.gupta@nxp.com; Olivier Matz
> <olivier.matz@6wind.com>; Ophir Munk <ophirmu@mellanox.com>; Ori
> Kam <orika@mellanox.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>; Pavan Nikhilesh
> <pbhagavatula@marvell.com>; Phil Yang <Phil.Yang@arm.com>; Qiming Yang
> <qiming.yang@intel.com>; Qingmin Liu <qingmin.liu@broadcom.com>; Qi
> Zhang <qi.z.zhang@intel.com>; Radu Bulie <radu-andrei.bulie@nxp.com>;
> Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>; Ralf Hoffmann
> <ralf.hoffmann@allegro-packets.com>; Randy Schacher
> <stuart.schacher@broadcom.com>; Remy Horton <remy.horton@intel.com>;
> Reshma Pattan <reshma.pattan@intel.com>; Shiri Kuzin <shirik@nvidia.com>;
> Shougang Wang <shougangx.wang@intel.com>; Shy Shyman
> <shys@mellanox.com>; Somnath Kotur <somnath.kotur@broadcom.com>;
> Stephen Hemminger <stephen@networkplumber.org>; Suanming Mou
> <suanmingm@mellanox.com>; Tao Zhu <taox.zhu@intel.com>; Tiwei Bie
> <tiwei.bie@intel.com>; Venkat Duvvuru
> <venkatkumar.duvvuru@broadcom.com>; Viacheslav Ovsiienko
> <viacheslavo@mellanox.com>; Viacheslav Ovsiienko
> <viacheslavo@nvidia.com>; Wei Huang <wei.huang@intel.com>; Wei Hu
> <xavier.huwei@huawei.com>; Wei Ling <weix.ling@intel.com>; Wei Zhao
> <wei.zhao1@intel.com>; Xiaolong Ye <xiaolong.ye@intel.com>; Xueming Li
> <xuemingl@nvidia.com>; Yingya Han <yingyax.han@intel.com>; Yu Jiang
> <yux.jiang@intel.com>; Yunjian Wang <wangyunjian@huawei.com>; nd
> <nd@arm.com>
> Subject: Re: please help backporting some patches to LTS release 18.11.11
> 
> 25/11/2020 03:44, Ruifeng Wang:
> > Hi Kevin,
> >
> > 76a4ed5b3  Ruifeng Wang     crypto/armv8: fix mempool object returning
> > //This patch should be dropped from missed list and not backported. The
> issue it fixes doesn't exist in 18.11 branch.
> 
> Why it is marked as fixing a commit from 2017?

This was a mistake on fix tag. 
The patch changed two lines of code. Fix tag was generated for both of the lines which involves two commits.
However, issue was introduced by only the later patch.
> 
> > Reply for some patches from Phil Yang:
> >
> > 059a23108  Phil Yang        app/testpmd: enable burst stats for noisy VNF
> mode
> > 030c21641  Phil Yang        eventdev: relax SMP barriers with C11 atomics
> > e84d9c62c  Phil Yang        eventdev: remove redundant reset on timer
> cancel
> > 1028d63eb  Phil Yang        eventdev: use C11 atomics for lcore timer armed
> flag
> > //These patches should be dropped from missed list and not backported.
> They are optimization or not critical bug fix.
> 
> Why they are marked with Cc: stable?

Discussion in the thread:
http://patches.dpdk.org/patch/71351/
Because one of bug fix patch in the patch needed to be backported, and it was
hard to use rte_atomic* API to do the fix, so C11 atomic built-in was used. To keep code in stable
release clean, decision was made to backport all other patches in the patch set that involves
C11 atomic built-in.
> 
>