From: Feifei Wang <Feifei.Wang2@arm.com>
To: David Marchand <david.marchand@redhat.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Olivier Matz <olivier.matz@6wind.com>
Cc: dev <dev@dpdk.org>, nd <nd@arm.com>,
dpdk stable <stable@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>
Subject: [dpdk-stable] 回复: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param
Date: Thu, 30 Jul 2020 10:16:01 +0000 [thread overview]
Message-ID: <VI1PR08MB302367FEBF1CB40F3C411948C8710@VI1PR08MB3023.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yMzOZ536bbsw4fLu_af_m3hJy5RkPhdMuibH0WZcaktg@mail.gmail.com>
Hi, David, Konstantin and Honnappa
> -----邮件原件-----
> 发件人: David Marchand <david.marchand@redhat.com>
> 发送时间: 2020年7月30日 0:00
> 收件人: Feifei Wang <Feifei.Wang2@arm.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Olivier Matz <olivier.matz@6wind.com>
> 抄送: dev <dev@dpdk.org>; nd <nd@arm.com>; dpdk stable
> <stable@dpdk.org>; thomas@monjalon.net
> 主题: Re: [dpdk-dev] [PATCH v1 1/2] ring: fix the misdescription of the param
>
> On Wed, Jul 29, 2020 at 8:31 AM Feifei Wang <feifei.wang2@arm.com>
> wrote:
> >
> > When enqueue one element to the ring, the param "obj" should be the
> > object to be added into the ring. The object is of type void*.
>
> I understand void * as a pointer to an object you don't know the type of.
> I would keep the current description.
>
Sorry for my commit message cannot express my view clearly.
Following is my supplementary explanation of this:
First, the APIs to be changed are:
1. rte_ring_mp_enqueue
2. rte_ring_sp_enqueue
3. rte_ring_enqueue
Second, Let's use an example to explain this:
1. We call API in form: rte_ring_enqueue(r, obj).
2. Current function header indicates that we will have ring[idx] = *obj.
3. However, this is not the case, what we eventually have is: ring[idx] = obj.
So I think the current function header is misleading or
maybe the implementation of above three functions need to be changed.
> Honnappa, Konstantin, Olivier ?
>
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > ---
> > lib/librte_ring/rte_ring.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
> > index da17ed6d7..418536b61 100644
> > --- a/lib/librte_ring/rte_ring.h
> > +++ b/lib/librte_ring/rte_ring.h
> > @@ -276,7 +276,7 @@ rte_ring_enqueue_bulk(struct rte_ring *r, void *
> const *obj_table,
> > * @param r
> > * A pointer to the ring structure.
> > * @param obj
> > - * A pointer to the object to be added.
> > + * A pointer (object) to be added.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2020-07-30 10:16 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200729063105.11299-1-feifei.wang2@arm.com>
2020-07-29 6:31 ` [dpdk-stable] " Feifei Wang
2020-07-29 15:59 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 16:24 ` Ananyev, Konstantin
2020-07-29 19:34 ` Honnappa Nagarahalli
2020-07-30 10:16 ` Feifei Wang [this message]
2020-07-31 5:26 ` Honnappa Nagarahalli
2020-07-29 6:31 ` [dpdk-stable] [PATCH v1 2/2] test/ring: fix wrong param passed to the enqueue APIs Feifei Wang
2020-07-29 13:48 ` [dpdk-stable] [dpdk-dev] " David Marchand
2020-07-29 14:16 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-29 14:21 ` [dpdk-stable] " David Marchand
2020-07-29 15:03 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-29 21:24 ` [dpdk-stable] " Honnappa Nagarahalli
2020-07-30 10:28 ` [dpdk-stable] 回复: " Feifei Wang
2020-07-31 6:25 ` Feifei Wang
[not found] ` <20200805061421.13037-1-feifei.wang2@arm.com>
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 1/4] test/ring: fix wrong parameter " Feifei Wang
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 2/4] test/ring: fix wrong size used in memcmp Feifei Wang
2020-08-26 20:51 ` Honnappa Nagarahalli
2020-08-27 9:05 ` [dpdk-stable] 回复: " Feifei Wang
2020-08-05 6:14 ` [dpdk-stable] [PATCH v2 3/4] test/ring: fix the wrong number of enq/deq elements Feifei Wang
2020-08-26 20:51 ` Honnappa Nagarahalli
2020-08-27 8:54 ` [dpdk-stable] 回复: " Feifei Wang
[not found] ` <20200911161002.19816-1-feifei.wang2@arm.com>
2020-09-11 16:09 ` [dpdk-stable] [PATCH v3 2/6] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-14 4:28 ` Honnappa Nagarahalli
2020-09-11 16:10 ` [dpdk-stable] [PATCH v3 4/6] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-14 4:31 ` Honnappa Nagarahalli
2020-09-11 16:10 ` [dpdk-stable] [PATCH v3 5/6] test/ring: fix wrong size used in memcmp Feifei Wang
2020-09-14 4:37 ` Honnappa Nagarahalli
2020-09-14 9:20 ` David Marchand
[not found] ` <20200914143350.18650-1-feifei.wang2@arm.com>
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 2/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 4/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-14 14:33 ` [dpdk-stable] [PATCH v4 5/7] test/ring: fix wrong size used in memcmp Feifei Wang
[not found] ` <20200915062749.21374-1-feifei.wang2@arm.com>
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 1/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 2/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-15 6:27 ` [dpdk-stable] [PATCH v5 3/7] test/ring: fix wrong size used in memcmp Feifei Wang
[not found] ` <20200920114856.20697-1-feifei.wang2@arm.com>
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 1/7] test/ring: fix wrong parameter passed to the enqueue APIs Feifei Wang
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 2/7] test/ring: fix wrong number of enq/deq elements Feifei Wang
2020-09-20 11:48 ` [dpdk-stable] [PATCH v6 3/7] test/ring: fix wrong size used in memcmp Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB302367FEBF1CB40F3C411948C8710@VI1PR08MB3023.eurprd08.prod.outlook.com \
--to=feifei.wang2@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).