From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00067.outbound.protection.outlook.com [40.107.0.67]) by dpdk.org (Postfix) with ESMTP id 739981C01; Mon, 29 Oct 2018 03:57:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AzHP7U26FANl8fcGw/PFvZkKu985KuPrO4aC0M3GczA=; b=mLZ5nRYu8ckslrKi5OlW4yob1GZQAxzrVTcdaJKJMi+RHVblBaMqE7L62W18PvrmIczS/N/T0Hq7bFWb66PcdeganSlXYWCwCB4+71SnvZm3LmMQJEVr8hcq8lHxqxHC7zk6WLgrSzOHOlL0zjYzHid0zJj72XdJFoORL8Zpgtk= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB3488.eurprd08.prod.outlook.com (20.177.59.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.25; Mon, 29 Oct 2018 02:57:17 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::d46a:1de3:53cd:3e49]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::d46a:1de3:53cd:3e49%4]) with mapi id 15.20.1273.027; Mon, 29 Oct 2018 02:57:17 +0000 From: "Gavin Hu (Arm Technology China)" To: Jerin Jacob , Thomas Monjalon CC: "dev@dpdk.org" , Honnappa Nagarahalli , "stable@dpdk.org" , Ola Liljedahl , "olivier.matz@6wind.com" , "chaozhu@linux.vnet.ibm.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" Thread-Topic: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail Thread-Index: AQHUZeLht2NjggOSDE2ZyYOtLzEKsqUi+lcwgBA/wQCAAAXIAIAAA34AgAAF24CAAjz78A== Date: Mon, 29 Oct 2018 02:57:17 +0000 Message-ID: References: <1537172244-64874-2-git-send-email-gavin.hu@arm.com> <1874944.OrACW1nkDZ@xps> <20181027150024.GA2294@jerin> <17713879.gC9jYcxDUo@xps> <20181027153355.GA9367@jerin> In-Reply-To: <20181027153355.GA9367@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB3488; 6:g5k1Y55rlBeIGFfvXT2SugbDzn5eMT5YwovNYTnZXot/jR6spbi+tXa89mlulF8hfIxhjq5TW/ovUdhKVLCCefw0MjmkT5293o1SuxmLJlLOfZKwIqeJ58smiGirMGDu98wkDLO/HdK/QePMVokulAlRiXQBRPgb4Ud/jU0UBEzdB6RRXkLikhrjhFrbA3hQdjTIF2++FAjsT6kpbjw4DrsHZxoyZ10Iws+OVegqGY26xYFwcU8E71Q7Wy5tcvNyoBRLmoLdzTquPOyuu9Jb7Htez6Vn0XtfV01M7Oa7spZlrW2cmdCmaqb0YeFRSLymNRGbAPuBhslyDdoLKHMpwDA7lqJWKryVjCWpFIqoe3/Z6Qu1KMsXo9hTTrF3sb1M12HN7PdJAn8T+2yLh9/jd83ynyCKCT5w995mzhSpzOx8g08AxOwYvMxgpulJA7y+n1OhRLCs2+OxkYMkZoKZHw==; 5:9xY6CSTft4n0WJHXy1WcBid3Qf0pHExGv5LfuOMlVFX+RRVxb5zuNwJmXxAFtsJZgexbWX88CTLJceMajbdcP9xqtmMlRdBtgcgG3fgG98D5wVzXpS8PoG58pT63QWaIffXrjaxtb9YdCn32uY0C1GsDPP/v96CFUL6zcRM+ha4=; 7:OBZBEcZlP80p+xK/U9Bu8O5+s1c9MK8M/xIiu381wo7Gj0nf0Jhwa1bKkga6e1fmSJarpo7pae8qgwJFoUgfCP1TqQMi5pErUoEhNl+f7fcq7VRS4g+6vlN1HSdrFfDaiMHZPkdEvwP6FnBupedprA== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: c4e78ea9-5e96-4e04-fee4-08d63d4a3ccf x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB3488; x-ms-traffictypediagnostic: VI1PR08MB3488: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(104084551191319)(228905959029699)(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:VI1PR08MB3488; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB3488; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(396003)(136003)(376002)(346002)(366004)(13464003)(199004)(189003)(40434004)(9686003)(81166006)(81156014)(55016002)(106356001)(66066001)(8936002)(33656002)(53936002)(68736007)(476003)(446003)(186003)(97736004)(6246003)(14454004)(6436002)(11346002)(86362001)(14444005)(5024004)(478600001)(105586002)(72206003)(486006)(256004)(25786009)(229853002)(110136005)(4326008)(316002)(54906003)(7736002)(5660300001)(305945005)(74316002)(6506007)(53546011)(26005)(76176011)(2906002)(8676002)(7696005)(55236004)(102836004)(93886005)(5250100002)(71190400001)(71200400001)(2900100001)(3846002)(99286004)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3488; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ZfkVdNJbITkmBrd4kBYa0nkDmDOf5c6tMV31EgULs/jHrHIPT5+OM6RNiHjqyXbTeHHRt1HZ+BopohMAKPO6Y7JMal/aTOczbnqYfw+/9UBve0e6nr0IIhUyJjovQPllViCwRNqA2ZTgYzzpJFlkN4yKApGRohZw3Bo9PJKMJNZsat4zZor3P4Jsoj4xaRjFI8BxUie+3Ddj/OgmUqvjrEsK/6A1QrcnGigyUWDaYkdYpvVb7oz1EvRBc9SQqDOtWpVvxMZS1WvzJj4qF6z5k9c5aAlgZ0eYBgnijX9bF2zXnxrAsd37wtwRNOSW6zybC7J2JNbT2FBuxocfkSmvzRNsQR9d4Q7P6QXPFKBfFLA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4e78ea9-5e96-4e04-fee4-08d63d4a3ccf X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 02:57:17.5079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3488 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 02:57:20 -0000 Hi Thomas and Jerin, The patches were extensively reviewed by Arm internally, as the 1st patch w= as not able to be concluded, I created a new patch series(2 patches). How can I clean up this mess? 1. make all the previous patches Superseded? 2. We have two more new patches, should I submit the 4 patches (the old 2 p= atches + 2 new patches) with V2? Best Regards, Gavin > -----Original Message----- > From: Jerin Jacob > Sent: Saturday, October 27, 2018 11:34 PM > To: Thomas Monjalon > Cc: Gavin Hu (Arm Technology China) ; dev@dpdk.org; > Honnappa Nagarahalli ; stable@dpdk.org; > Ola Liljedahl ; olivier.matz@6wind.com; > chaozhu@linux.vnet.ibm.com; bruce.richardson@intel.com; > konstantin.ananyev@intel.com > Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store = of > the tail > > -----Original Message----- > > Date: Sat, 27 Oct 2018 17:13:10 +0200 > > From: Thomas Monjalon > > To: Jerin Jacob > > Cc: "Gavin Hu (Arm Technology China)" , > "dev@dpdk.org" > > , Honnappa Nagarahalli > , > > "stable@dpdk.org" , Ola Liljedahl > > , "olivier.matz@6wind.com" > > , "chaozhu@linux.vnet.ibm.com" > > , "bruce.richardson@intel.com" > > , "konstantin.ananyev@intel.com" > > > > Subject: Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and > > store of the tail > > > > > > 27/10/2018 17:00, Jerin Jacob: > > > From: Thomas Monjalon > > > > 17/10/2018 08:35, Gavin Hu (Arm Technology China): > > > > > Hi Jerin > > > > > > > > > > As the 1st one of the 3-patch set was not concluded, I submit thi= s 2- > patch series to unblock the merge. > > > > > > > > The thread is totally messed up because: > > > > - there is no cover letter > > > > - some different series (testpmd, i40e and doc) are in the = same > thread > > > > - v4 replies to a different series > > > > - this version should be a v5 but has no number > > > > - this version replies to the v3 > > > > - patchwork still shows v3 and "v5" > > > > - replies from Ola are not quoting previous discussion > > > > > > > > Because of all of this, it is really difficult to follow. > > > > This is probably the reason of the lack of review outside of Arm. > > > > > > > > One more issue: you must Cc the relevant maintainers. > > > > Here: > > > > - Olivier for rte_ring > > > > - Chao for IBM platform > > > > - Bruce and Konstantin for x86 > > > > > > > > Guys, it is really cool to have more Arm developpers in DPDK. > > > > But please consider better formatting your discussions, it is > > > > really important in our contribution workflow. > > > > > > > > I don't know what to do. > > > > I suggest to wait for more feedbacks and integrate it in -rc2. > > > > > > This series has been acked and tested. Sure, if we are looking for > > > some more feedback we can push to -rc2 if not it a good candidate to > > > be selected for -rc1. > > > > It has been acked and tested only for Arm platforms. > > And Olivier, the ring maintainer, was not Cc. > > > > I feel it is not enough. > > Sure, More reviews is already better. But lets keep as -rc2 target. > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.