From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00079.outbound.protection.outlook.com [40.107.0.79]) by dpdk.org (Postfix) with ESMTP id 1E62E91; Thu, 1 Nov 2018 10:56:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b73d9SubaadiAQNd5W4zcoXUB446QF2Eh8ULG51a7HI=; b=DDpWP9yJwfCeKz6JGjre/byS0nVGp1FkdzsHFJg4aumH+gqXPmzy6viwK2mqclVQcEVjjSUKP4QoeMl5DQQZCtu2yt4ZH7VO5ZQpFfDC0Hl0lz7ogN3lUpllUbjZeXbNTllo0I7zUiobuSs60rsFF2bWzJ2QuUsKQf22Pbi6CEs= Received: from VI1PR08MB3167.eurprd08.prod.outlook.com (52.133.15.142) by VI1PR08MB0431.eurprd08.prod.outlook.com (10.162.12.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Thu, 1 Nov 2018 09:56:24 +0000 Received: from VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::d46a:1de3:53cd:3e49]) by VI1PR08MB3167.eurprd08.prod.outlook.com ([fe80::d46a:1de3:53cd:3e49%4]) with mapi id 15.20.1294.024; Thu, 1 Nov 2018 09:56:24 +0000 From: "Gavin Hu (Arm Technology China)" To: Stephen Hemminger CC: "dev@dpdk.org" , "thomas@monjalon.net" , "olivier.matz@6wind.com" , "chaozhu@linux.vnet.ibm.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" , "jerin.jacob@caviumnetworks.com" , Honnappa Nagarahalli , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/2] ring: synchronize the load and store of the tail Thread-Index: AQHUcQQ4G5FMirPwikKe2LdJxEv4XaU56koAgADFw3A= Date: Thu, 1 Nov 2018 09:56:23 +0000 Message-ID: References: <1540981587-88590-1-git-send-email-gavin.hu@arm.com> <1540981587-88590-2-git-send-email-gavin.hu@arm.com> <20181031150750.62454627@xeon-e3> In-Reply-To: <20181031150750.62454627@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR08MB0431; 6:MmafeNqXqpU8okbY96UVI5Fs2JZvvD3JRqJA4NSGwFbJ3Mh7/0gI7qW2rmeKSIJE3QT4IyUW3xR5e5eI3QMGmiPaeoNYItJ1mJPiwl0+AkpcMo/S/MPUCIhrnpc253J2CuwN143p7X7NzVDKtBQLH1969nONPb3je0gjNKvlCJowEv9J85xAlSyf5LxcPD/UCWQkYumICMxVhpIr6hKEcOUnzm7E8KdhY9etlELXgkuRqsDE9lB8Ci3MxYTrIPnppyzch4EAwB1oNYzpdeIvChH0FmF1I53R6b8cCebbnlEa+nWaBXEfumR9hOsdgt6i0Jtc1ILtDBxK1ozh69tjp262TjJULg2/S+gutPH6m4DJF1NDdqUl6CBujwUFEfgrTsS02Q8jZcmJMLnjRtq+/Kl22bEWTQq1uJbWm/RQN4F4GUJVStUo9NBInYoKcPHZ5KwyqugTuSAD15o/ReUthw==; 5:w/jG17SX9xNyJ1NGbTlXp8ZQwnsgDW3dFsVUFrc+87nqUPJsP2xDknjQYJOv3DdcifIHXVB3DUyKw99U3Jlq1gNWQnZkmKD8YaDb3HUa5WP7o+xChhlfS69sMBqlxpA3j8B5pZqJYdLn3PBaojdmuooIjS3/o28bjvMBCvNJy/4=; 7:EaGK41gNGUIZD1CbWKhoAhrQyGHPB2jY6vc9LunYrAywjVeVBW7kzr1+fsQWm2MmV2aiiHcyud8XrOA9mn+Rem4Fu5lfb5WoYICGsQhy6M4wcTFT0tMYN1nmf8haRc5G0Ik/+ARvPKF/CFW5chedkg== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: f0feebaa-de22-484c-d323-08d63fe0487d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR08MB0431; x-ms-traffictypediagnostic: VI1PR08MB0431: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(104084551191319)(228905959029699)(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:VI1PR08MB0431; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB0431; x-forefront-prvs: 0843C17679 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(39860400002)(346002)(376002)(136003)(40434004)(13464003)(189003)(199004)(72206003)(14454004)(229853002)(99286004)(25786009)(76176011)(81166006)(7696005)(8936002)(5250100002)(478600001)(8676002)(5660300001)(68736007)(81156014)(74316002)(97736004)(305945005)(33656002)(71190400001)(6916009)(2906002)(71200400001)(3846002)(6116002)(7736002)(9686003)(102836004)(486006)(55236004)(5024004)(14444005)(256004)(55016002)(446003)(11346002)(106356001)(316002)(6436002)(26005)(476003)(105586002)(66066001)(6246003)(54906003)(53546011)(6506007)(186003)(2900100001)(4326008)(53936002)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB0431; H:VI1PR08MB3167.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: d1f+9sQk/nNjlFlfvb5ypOfPninPrCdrcgVYkJuHj2ufzCV/TCtW0Z0Cn5cTAGJBGFPFyV6jnqrhXTXSU0Hi30mKdO0eIvR6PPjO+FCruZtITXQ/im8S8oVqO1611SBOj6thCotyu5SNf0yLRme0Ul2gYyQUclA+UidLhJomjqv2NNKWCajmDzN7um4aIpGoEXpLe2BEZ0aCObfwRBHXzuIBxl+B1q1taY0yaFbsdtp5JqUxSAJncLTS01WmAgGPDBIKfg8Vs9n3v3JBgp2ODbep1jlPP1DJEN+CReS7pXYj5AyHbIGydirdF3+KqSh40guvRBK0a54l3GlpoQlZB5GanbczdWHUj8jU2qqwi8A= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0feebaa-de22-484c-d323-08d63fe0487d X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2018 09:56:23.9112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB0431 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/2] ring: synchronize the load and store of the tail X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 09:56:26 -0000 > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, November 1, 2018 6:08 AM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; thomas@monjalon.net; olivier.matz@6wind.com; > chaozhu@linux.vnet.ibm.com; bruce.richardson@intel.com; > konstantin.ananyev@intel.com; jerin.jacob@caviumnetworks.com; > Honnappa Nagarahalli ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/2] ring: synchronize the load and sto= re > of the tail > > On Wed, 31 Oct 2018 18:26:26 +0800 > Gavin Hu wrote: > > > -/* > > - * The subtraction is done between two unsigned 32bits > value > > +/* load-acquire synchronize with store-release of ht->tail > > + * in update_tail. > > + */ > > +const uint32_t cons_tail > > Please don't mix declarations and code. Although it is sometimes used in > DPDK, in general the style is to have declarations at the start of the bl= ock > scope. Thanks for review, your comment was address in v4. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.