[dpdk-stable] 答复: please help backporting some patches to LTS release 17.11.7

[dpdk-stable] 答复: please help backporting some patches to LTS release 17.11.7

[Joyce Kong (Arm Technology China)]

Hi Yongseok,

The below two patches can't be backported, as the previous patches/files which they were based on were not applied into the branch 17.11.
e8af2f1f11   Joyce Kong       rwlock: reimplement with atomic builtins
9b47ed438a  Joyce Kong       config: enable more than 128 cores for arm64

Best Regards,
Joyce

> -----邮件原件-----
> 发件人: Yongseok Koh <yskoh@mellanox.com>
> 发送时间: Tuesday, July 23, 2019 9:40 AM
> 抄送: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Akhil.goyal@nxp.com; Alejandro Lucero
> <alejandro.lucero@netronome.com>; Anatoly Burakov
> <anatoly.burakov@intel.com>; Andrew Rybchenko
> <arybchenko@solarflare.com>; Andrius Sirvys <andrius.sirvys@intel.com>;
> Bernard Iremonger <bernard.iremonger@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Chas Williams <chas3@att.com>; Chenbo Xia
> <chenbo.xia@intel.com>; David Christensen <drc@linux.vnet.ibm.com>; David
> Hunt <david.hunt@intel.com>; David Marchand
> <david.marchand@redhat.com>; Erik Gabriel Carrillo
> <erik.g.carrillo@intel.com>; Fan Zhang <roy.fan.zhang@intel.com>; Ferruh
> Yigit <ferruh.yigit@intel.com>; Gaetan Rivet <gaetan.rivet@6wind.com>; Gavin
> Hu (Arm Technology China) <Gavin.Hu@arm.com>; hemant.agrawal@nxp.com;
> Hyong Youb Kim <hyonkim@cisco.com>; Igor Romanov
> <igor.romanov@oktetlabs.ru>; Ilya Maximets <i.maximets@samsung.com>;
> Jens Freimann <jfreimann@redhat.com>; jerinj@marvell.com; John Daley
> <johndale@cisco.com>; John McNamara <john.mcnamara@intel.com>; Joyce
> Kong (Arm Technology China) <Joyce.Kong@arm.com>; Keith Wiles
> <keith.wiles@intel.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Marcin Hajkowski
> <marcinx.hajkowski@intel.com>; Matias Elo <matias.elo@nokia.com>; Mattias
> Rönnblom <mattias.ronnblom@ericsson.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Mohammad Abdul Awal
> <mohammad.abdul.awal@intel.com>; Nikhil Rao <nikhil.rao@intel.com>;
> Nithin Dabilpuram <ndabilpuram@marvell.com>; Oleg Polyakov
> <olegp123@walla.co.il>; Pallantla Poornima <pallantlax.poornima@intel.com>;
> Qi Zhang <qi.z.zhang@intel.com>; Rahul Lakkireddy
> <rahul.lakkireddy@chelsio.com>; Rami Rosen <ramirose@gmail.com>; Rasesh
> Mody <rmody@marvell.com>; Shahaf Shuler <shahafs@mellanox.com>;
> Shahed Shaikh <shshaikh@marvell.com>; Somnath Kotur
> <somnath.kotur@broadcom.com>; Stephen Hemminger
> <stephen@networkplumber.org>; Tiwei Bie <tiwei.bie@intel.com>; Vishal
> Kulkarni <vishal@chelsio.com>; Wei Zhao <wei.zhao1@intel.com>; Wenjie Sun
> <findtheonlyway@gmail.com>; Yuan Peng <yuan.peng@intel.com>
> 主题: please help backporting some patches to LTS release 17.11.7
>
> Hi commit authors (and maintainers),
>
> I didn't manage to apply following commits from upstream to stable branch
> 17.11:
> conflict happens or compilation failed. Can the authors/maintainers check the
> following list and backport those patches belong to you?
>
> Also, there's the list of missing patches from previous releases. Please take a
> look and respond.
>
> FYI, branch 17.11 is located at tree:
>    git://dpdk.org/dpdk-stable
>
> It'd be great if you could do that in one or two weeks. Also, please add a
> heading line like below before the commit log body:
>     [ backported from upstream commit xxx ]
>
> Example:
> http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c4831394c7d194
> 4d8ec27d52c22997f20d19718e
>
> Also please mention the target LTS in the subject line, as we have more than
> one at the same time, for example:
>
>     [PATCH 17.11] foo/bar: fix baz
>
> With git send-email, this can be achieved by appending the parameter:
>
>     --subject-prefix='17.11'
>
> Please let me know if you have any comments, say, need more time, or it's
> worthless to backport it. And please send it to "stable@dpdk.org", but not
> "dev@dpdk.org".
>
> Thanks.
>
> Yongseok
>
> ---
> 98e91784d9  Adrien Mazarguil net/failsafe: fix source port id in Rx packets
> 261fb94185  Akhil Goyal      crypto/dpaa: fix session destroy
> 3243f7c0d8  Alejandro Lucero net/nfp: fix potential integer overflow
> e2c3639abf  Andrew Rybchenko net/sfc: fix logging from secondary process
> cf6a73fc3f  Andrew Rybchenko net/sfc: fix speed capabilities reported in
> device info
> 902f389f9b  Andrius Sirvys   drivers/net: fix shifting 32-bit signed variable
> 31 times
> 70d284ab82  Bruce Richardson eal: tighten permissions on shared memory
> files
> d7bce0058a  Chas Williams    net/bonding: fix link status
> 2b0e0eba2c  Chenbo Xia       app/testpmd: fix return value check
> 70b2c7f12c  David Christensen examples/power: fix build with some disabled
> PMDs
> 94d655468c  David Marchand   app/testpmd: add missing newline when
> showing statistics
> c185d42cb4  David Marchand   app/testpmd: extend forwarding statistics
> to 64 bits
> 1598c72959  David Marchand   eal: fix core list validation with disabled
> cores
> 646d3f20aa  David Marchand   net/bonding: fix packet count type for LACP
> 1d6cab8a91  David Marchand   net/bonding: fix slave id types
> 92b5ea41bb  Erik Gabriel Carrillo eventdev: update references to removed
> function
> e7347a8aff  Hyong Youb Kim   net/enic: allow flow mark ID 0
> 593f17668f  Hyong Youb Kim   net/enic: fix endianness in VLAN match
> 4445a0f4c7  Hyong Youb Kim   net/enic: fix inner packet matching
> c09eb93529  Hyong Youb Kim   net/enic: fix max MTU calculation
> 6e54c8ac5c  Hyong Youb Kim   net/enic: fix VLAN inner type matching for
> old hardware
> d7316eae1a  Hyong Youb Kim   net/enic: fix VXLAN match
> 6c0cc77a2d  Igor Romanov     net/sfc: fix MTU change to check Rx scatter
> consistency
> ac30699e9c  Igor Romanov     net/sfc: improve TSO header length check in
> EFX datapath
> 23d25f1a40  Ilya Maximets    net/virtio: add barriers for extra descriptors
> on Rx split
> 2344395df2  Ilya Maximets    vhost: fix passing destroyed device to destroy
> callback
> e8af2f1f11  Joyce Kong       rwlock: reimplement with atomic builtins
> fe252fb695  Joyce Kong       test/rwlock: benchmark on all available cores
> 49757b6845  Konstantin Ananyev examples/ipsec-secgw: fix SPD no-match
> case
> 92433e3473  Marcin Hajkowski power: fix thread-safety environment
> modification
> 7727ad9107  Mattias Rönnblom power: fix cache line alignment 11d5253a3e
> Maxime Coquelin  vhost: prevent disabled rings to be processed with
> zero-copy
> b045785f92  Mohammad Abdul Awal vhost: fix null pointer checking
> 339677f870  Nikhil Rao       eventdev: fix Rx adapter event flush
> 368ba98aea  Nithin Dabilpuram app/testpmd: fix Tx VLAN and QinQ
> dependency
> efa28ae847  Oleg Polyakov    net/tap: fix getting max iovec
> 968e9c14f3  Pallantla Poornima net/nfp: fix possible buffer overflow
> 756cea41e9  Qi Zhang         net/i40e: fix scattered Rx enabling
> c387effde8  Qi Zhang         net/iavf: enable more link speed
> c979b04e74  Rahul Lakkireddy net/cxgbe: update Chelsio T5/T6 NIC device
> ids
> ed55533e98  Rasesh Mody      net/bnx2x: fix MTU for jumbo frame
> 401b744da2  Shahaf Shuler    app/testpmd: fix mempool free on exit
> 60f9a63457  Shahed Shaikh    net/qede: fix Tx packet prepare for tunnel
> packets
> f06515964a  Stephen Hemminger net/bnxt: silence IOVA warnings
> 618bbdab47  Stephen Hemminger net/bnxt: suppress spurious error log
> 869bf6d222  Stephen Hemminger net/ring: fix coding style
> 8f37e38241  Stephen Hemminger net/virtio: fix buffer leak on VLAN insert
> 8f66bc4ac3  Tiwei Bie        net/virtio: add barrier in interrupt enable
> 2a2904fa9c  Tiwei Bie        vhost: fix potential use-after-free for memory
> region
> d767436ee5  Tiwei Bie        vhost: fix potential use-after-free for zero
> copy mbuf
> 041d37b2ef  Tiwei Bie        vhost: restore mbuf first when freeing zmbuf
> df68e75a79  Vishal Kulkarni  net/cxgbe: fix missing checksum flags and
> packet type
> 169a9fed1f  Wei Zhao         app/testpmd: fix hex string parser support
> for flow API
> f9fa1bb464  Wei Zhao         net/avf: fix admin queue interrupt for ICE
> 054617fd82  Wenjie Sun       vhost: fix deadlock in driver unregister
>
>
> ---[ List of missing patches from previous releases ]---
>
> 80ad678ae7  Ajit Khaparde    net/bnxt: fix MTU setting
> 6f93b2aa2d  Ajit Khaparde    net/bnxt: remove excess log messages
> 5bf10cdb67  Ajit Khaparde    net/bnxt: set a VNIC as default only once
> 2932ee2ad8  Akhil Goyal      crypto/dpaa2_sec: fix FLC address for
> physical mode
> 7712a1c660  Alejandro Lucero net/nfp: fix live MAC changes not supported
> 0c15f3c010  Ali Alnubani     net/mlx5: fix initialization of struct members
> 605eb4d596  Arek Kusztal     crypto/qat: fix message for CCM when setting
> unused counter
> 4dc73ff704  Arek Kusztal     crypto/qat: fix message for NULL algo setting
> unused counter
> 054d1be48c  Beilei Xing      net/i40e: fix Rx instability with vector mode
> 3c4c76cf17  Damjan Marion    net/i40e: fix 25G AOC and ACC cable
> detection on XXV710
> f21bb93126  David Hunt       test/power: handle p-state mode
> 1fd1aa0c91  Fan Zhang        crypto/aesni_mb: fix queue pair free
> 5b4557ec8d  Ferruh Yigit     app/testpmd: fix displaying RSS hash functions
> a8b52dafee  Ferruh Yigit     doc: fix vhost library version in release notes
> 9757358342  Ferruh Yigit     fix global variable issues
> c06aee624d  Ferruh Yigit     net/bnxt: fix uninitialized variable access
> c8b506e4b6  Ferruh Yigit     service: fix possible null access
> 89da5e006f  Fiona Trahe      crypto/qat: fix digest in wireless auth case
> 2a7bb4fdf6  Fiona Trahe      doc: add GCM AAD limitation in qat guide
> ed42d18458  Gautam Dawar     net/sfc/base: fix out of bounds read when
> dereferencing sdup
> dbdbc4a2e9  Honnappa Nagarahalli hash: fix key store element alignment
> 0d7853a4da  Ilya Maximets    vhost-user: drop connection on message
> handling failures
> 13ffe6059e  Jerin Jacob      doc: clarify VLAN and QinQ Tx offload
> prerequisite
> c23e465944  Jerin Jacob      mbuf: fix offload flag name and list
> 5bd5f7b3ae  Jiayu Hu         doc: add GRO limitations in programmers
> guide
> 9b47ed438a  Joyce Kong       config: enable more than 128 cores for
> arm64
> d87152e796  Konstantin Ananyev examples/ipsec-secgw: fix crypto-op might
> never get dequeued
> e0dac065f2  Konstantin Ananyev examples/ipsec-secgw: fix inbound SA
> checking
> f394c63d2d  Martin Harvey    net/sfc/base: fix PreFAST warnings because
> of unused return
> d4ff2135eb  Maxime Coquelin  vhost: enforce avail index and desc read
> ordering
> 55e411b301  Qi Zhang         bus/pci: fix resource mapping override
> 188d0bda2b  Qi Zhang         net/i40e/base: fix partition id calculation for
> X722
> 54f4a22dc1  Qi Zhang         net/i40e/base: improve the polling
> mechanism
> b72611a274  Qi Zhang         net/i40e/base: read LLDP config area with
> correct endianness
> 3fcde631cb  Rami Rosen       net/i40e: fix config name in comment
> 853c782496  Rasesh Mody      net/bnx2x: fix dynamic logging
> c1752a36b0  Sachin Saxena    net/dpaa: fix link speed based on MAC type
> 1a611fdaf6  Shahaf Shuler    net/mlx5: support missing counter in
> extended statistics
> 51fafb89a9  Somnath Kotur    net/bnxt: get rid of ff pools and use VNIC info
> array
> b8ffdcc0ba  Wei Zhao         net/ixgbe: fix Rx LRO capability offload for
> x550
> aa28ec5d27  Wenzhuo Lu       ethdev: fix invalid configuration after failure
> a830900063  Xiaoxin Peng     net/bnxt: reduce polling interval for valid bit
> 36c5dc8e5d  Xiaoyun Li       net/i40e: fix overwriting RSS RETA
> ff30a020bb  Yanglong Wu      net/ixgbe: fix TDH register write
> 2d28bb5ddd  Yipeng Wang      hash: remove unnecessary pause
> d31c844435  Zhirun Yan       net/avf: fix Tx offload mask
> 0eaa1f8c75  Zhirun Yan       net/i40e: clear VF reset flags after reset
> 38827a0481  Zhirun Yan       net/i40e: fix port close
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.7

[Stephen Hemminger]

On Mon, 22 Jul 2019 18:40:23 -0700
Yongseok Koh <yskoh@mellanox.com> wrote:

> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch 17.11:

> f06515964a  Stephen Hemminger net/bnxt: silence IOVA warnings
> 618bbdab47  Stephen Hemminger net/bnxt: suppress spurious error log

These should be reviewed by bnxt maintainers
> 869bf6d222  Stephen Hemminger net/ring: fix coding style

This is a style only patch not needed for stable.

> 8f37e38241  Stephen Hemminger net/virtio: fix buffer leak on VLAN insert

This should just be merged, easy to do.

Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.7

[Yongseok Koh]

> On Jul 25, 2019, at 12:03 AM, Joyce Kong (Arm Technology China) <Joyce.Kong@arm.com> wrote:
> 
> Hi Yongseok,
> 
> The below two patches can't be backported, as the previous patches/files which they were based on were not applied into the branch 17.11.
> e8af2f1f11   Joyce Kong       rwlock: reimplement with atomic builtins
> 9b47ed438a  Joyce Kong       config: enable more than 128 cores for arm64

Thanks for reply.
Removed those from the list.

Yongseok

Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.7

[Yongseok Koh]

> On Jul 26, 2019, at 11:14 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> On Mon, 22 Jul 2019 18:40:23 -0700
> Yongseok Koh <yskoh@mellanox.com> wrote:
> 
>> Hi commit authors (and maintainers),
>> 
>> I didn't manage to apply following commits from upstream to stable branch 17.11:
> 
>> f06515964a  Stephen Hemminger net/bnxt: silence IOVA warnings
>> 618bbdab47  Stephen Hemminger net/bnxt: suppress spurious error log
> 
> These should be reviewed by bnxt maintainers

Copying bnxt maintainers.

>> 869bf6d222  Stephen Hemminger net/ring: fix coding style
> 
> This is a style only patch not needed for stable.

Removed from the list.

>> 8f37e38241  Stephen Hemminger net/virtio: fix buffer leak on VLAN insert
> 
> This should just be merged, easy to do.

I just trimmed the original patch and merged.

Thanks,
Yongseok

Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.7

[Somnath Kotur]

Hi Yongseok,

On Fri, Aug 2, 2019 at 6:07 AM Yongseok Koh <yskoh@mellanox.com> wrote:
>
>
> > On Jul 26, 2019, at 11:14 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > On Mon, 22 Jul 2019 18:40:23 -0700
> > Yongseok Koh <yskoh@mellanox.com> wrote:
> >
> >> Hi commit authors (and maintainers),
> >>
> >> I didn't manage to apply following commits from upstream to stable branch 17.11:
> >
> >> f06515964a  Stephen Hemminger net/bnxt: silence IOVA warnings
> >> 618bbdab47  Stephen Hemminger net/bnxt: suppress spurious error log
> >
> > These should be reviewed by bnxt maintainers

Have reviewed them both, the 2nd patch (618bbdab47) is not applicable
to 17.11 as it does not even have that spurious error log
while the 1st one does not apply because of the shift from RTE_LOG to
PMD_DRV_LOG mechanism post 17.11...
Having said that don't think it's that important for it go to stable
now i guess unless anybody else differs with that?
Basically, we don't need these 2 patches to  be applied to 17.11

Thanks
Som
>
> Copying bnxt maintainers.
>
> >> 869bf6d222  Stephen Hemminger net/ring: fix coding style
> >
> > This is a style only patch not needed for stable.
>
> Removed from the list.
>
> >> 8f37e38241  Stephen Hemminger net/virtio: fix buffer leak on VLAN insert
> >
> > This should just be merged, easy to do.
>
> I just trimmed the original patch and merged.
>
> Thanks,
> Yongseok
>

Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.7

[Yongseok Koh]

> On Aug 2, 2019, at 1:02 AM, Somnath Kotur <somnath.kotur@broadcom.com> wrote:
> 
> Hi Yongseok,
> 
> On Fri, Aug 2, 2019 at 6:07 AM Yongseok Koh <yskoh@mellanox.com> wrote:
>> 
>> 
>>> On Jul 26, 2019, at 11:14 AM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>>> 
>>> On Mon, 22 Jul 2019 18:40:23 -0700
>>> Yongseok Koh <yskoh@mellanox.com> wrote:
>>> 
>>>> Hi commit authors (and maintainers),
>>>> 
>>>> I didn't manage to apply following commits from upstream to stable branch 17.11:
>>> 
>>>> f06515964a  Stephen Hemminger net/bnxt: silence IOVA warnings
>>>> 618bbdab47  Stephen Hemminger net/bnxt: suppress spurious error log
>>> 
>>> These should be reviewed by bnxt maintainers
> 
> Have reviewed them both, the 2nd patch (618bbdab47) is not applicable
> to 17.11 as it does not even have that spurious error log
> while the 1st one does not apply because of the shift from RTE_LOG to
> PMD_DRV_LOG mechanism post 17.11...
> Having said that don't think it's that important for it go to stable
> now i guess unless anybody else differs with that?
> Basically, we don't need these 2 patches to  be applied to 17.11

Removed it from the list.

Thanks for reply!
Yongseok

Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.7

[Hyong Youb Kim (hyonkim)]

> -----Original Message-----
> From: Yongseok Koh <yskoh@mellanox.com>
> Sent: Tuesday, July 23, 2019 10:40 AM
[...]
> Subject: please help backporting some patches to LTS release 17.11.7
> 
> Hi commit authors (and maintainers),
> 
> I didn't manage to apply following commits from upstream to stable branch
> 17.11:
> conflict happens or compilation failed. Can the authors/maintainers check
> the
> following list and backport those patches belong to you?
[..]
> e7347a8aff  Hyong Youb Kim   net/enic: allow flow mark ID 0
> 593f17668f  Hyong Youb Kim   net/enic: fix endianness in VLAN match
> 4445a0f4c7  Hyong Youb Kim   net/enic: fix inner packet matching
> c09eb93529  Hyong Youb Kim   net/enic: fix max MTU calculation
> 6e54c8ac5c  Hyong Youb Kim   net/enic: fix VLAN inner type matching for old
> hardware
> d7316eae1a  Hyong Youb Kim   net/enic: fix VXLAN match

Hi,

You can drop these patches. They depend on several non-fix commits,
and are not critical.

Thank you.
-Hyong

Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.7

[Yongseok Koh]

> On Aug 8, 2019, at 10:28 PM, Hyong Youb Kim (hyonkim) <hyonkim@cisco.com> wrote:
> 
>> -----Original Message-----
>> From: Yongseok Koh <yskoh@mellanox.com>
>> Sent: Tuesday, July 23, 2019 10:40 AM
> [...]
>> Subject: please help backporting some patches to LTS release 17.11.7
>> 
>> Hi commit authors (and maintainers),
>> 
>> I didn't manage to apply following commits from upstream to stable branch
>> 17.11:
>> conflict happens or compilation failed. Can the authors/maintainers check
>> the
>> following list and backport those patches belong to you?
> [..]
>> e7347a8aff  Hyong Youb Kim   net/enic: allow flow mark ID 0
>> 593f17668f  Hyong Youb Kim   net/enic: fix endianness in VLAN match
>> 4445a0f4c7  Hyong Youb Kim   net/enic: fix inner packet matching
>> c09eb93529  Hyong Youb Kim   net/enic: fix max MTU calculation
>> 6e54c8ac5c  Hyong Youb Kim   net/enic: fix VLAN inner type matching for old
>> hardware
>> d7316eae1a  Hyong Youb Kim   net/enic: fix VXLAN match
> 
> Hi,
> 
> You can drop these patches. They depend on several non-fix commits,
> and are not critical.

Thanks for the reply.
The patches have been removed from the list.

Yongseok