patches for DPDK stable branches
 help / color / Atom feed
From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
To: Zhang Xiao <xiao.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
	"marcdevel@gmail.com" <marcdevel@gmail.com>,
	"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [dpdk-dev] net/ixgbe: fix X553 wrong speed capability
Date: Wed, 25 Sep 2019 07:04:09 +0000
Message-ID: <VI1PR08MB53760986800D33BDA8CB1E0C8F870@VI1PR08MB5376.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <1569379794-54847-1-git-send-email-xiao.zhang@intel.com>

Hi Xiao,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang Xiao
> Sent: Wednesday, September 25, 2019 10:50 AM
> To: dev@dpdk.org
> Cc: wenzhuo.lu@intel.com; Zhang Xiao <xiao.zhang@intel.com>;
> marcdevel@gmail.com; stable@dpdk.org
> Subject: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability
> 
> The speed capability of X553 1GbE should be ETH_LINK_SPEED_1G |
> ETH_LINK_SPEED_100M | ETH_LINK_SPEED_10M rather than
> ETH_LINK_SPEED_1G |
> ETH_LINK_SPEED_10G. Correct it to fix the issue.
> 
> Fixes: e274f5732225 ("ethdev: add speed capabilities")
> Cc: marcdevel@gmail.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Zhang Xiao <xiao.zhang@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 7eb3d05..e7c4ce3 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3843,6 +3843,11 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info)
>  	dev_info->flow_type_rss_offloads = IXGBE_RSS_OFFLOAD_ALL;
> 
>  	dev_info->speed_capa = ETH_LINK_SPEED_1G |
> ETH_LINK_SPEED_10G;
Look through the following code, 100M and 1G is more common to across x530 to x550 devices, while 10M and 10G is specific.
Here 10G should be replaced by 100M and you can save some comparisons in the following code.
/Gavin

> +	if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T ||
> +			hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L)
> +		dev_info->speed_capa = ETH_LINK_SPEED_10M |
> +			ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G;
> +
>  	if (hw->mac.type == ixgbe_mac_X540 ||
>  	    hw->mac.type == ixgbe_mac_X540_vf ||
>  	    hw->mac.type == ixgbe_mac_X550 ||
> --
> 2.7.4


  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25  2:49 [dpdk-stable] " Zhang Xiao
2019-09-25  7:04 ` Gavin Hu (Arm Technology China) [this message]
2019-09-25  8:16   ` [dpdk-stable] [dpdk-dev] " Zhang, Xiao
2019-09-25  9:06     ` Gavin Hu (Arm Technology China)
2019-09-30 10:45 ` Ye Xiaolong
2019-09-30 10:47 ` Ye Xiaolong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR08MB53760986800D33BDA8CB1E0C8F870@VI1PR08MB5376.eurprd08.prod.outlook.com \
    --to=gavin.hu@arm.com \
    --cc=dev@dpdk.org \
    --cc=marcdevel@gmail.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox