From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96495A0613 for ; Wed, 25 Sep 2019 09:04:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 691E52C36; Wed, 25 Sep 2019 09:04:26 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140057.outbound.protection.outlook.com [40.107.14.57]) by dpdk.org (Postfix) with ESMTP id D8F892BB5; Wed, 25 Sep 2019 09:04:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSvBINuxorqa43BikBWS/Ms22+x0Tvi+dlmbA22XKt4=; b=PlgxRMpXV0YD9Fw26MUsdAGIwqcHZskdzmG0vqMno3UQsSSfd2vKEEc18+MMFd4n2VxuNEMs8ablV3pBdWES0eTbrTaRZ+s80N08mj9k6da03La1T39M7wAKAqE6FeJIZTAmX8KpF+gwLA7JKDL64nedjx3u/K7D6UJlLGs+UM8= Received: from HE1PR0802CA0004.eurprd08.prod.outlook.com (2603:10a6:3:bd::14) by VI1PR08MB3408.eurprd08.prod.outlook.com (2603:10a6:803:7c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.23; Wed, 25 Sep 2019 07:04:19 +0000 Received: from DB5EUR03FT021.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::205) by HE1PR0802CA0004.outlook.office365.com (2603:10a6:3:bd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20 via Frontend Transport; Wed, 25 Sep 2019 07:04:18 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT021.mail.protection.outlook.com (10.152.20.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20 via Frontend Transport; Wed, 25 Sep 2019 07:04:17 +0000 Received: ("Tessian outbound 3fba803f6da3:v33"); Wed, 25 Sep 2019 07:04:17 +0000 X-CR-MTA-TID: 64aa7808 Received: from f29f11e78ebb.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.12.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id E41EC2A6-EC73-4296-93AD-7CDBD2234F7F.1; Wed, 25 Sep 2019 07:04:12 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f29f11e78ebb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 25 Sep 2019 07:04:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LQ7Lg9rseIrAbDiBpYDlmdu1xUCuxhZH0V5HZoINBm5+bsN35LPbF2RXJgyEi4sIBQGm6EgOliQ3WNIE7NCUSVJKEyVbpEz7fS2qogfQvIUaSEuQnBHLAzMb0cgVfFxoUXJK0p0XdouERlq1uWhd3mCWj+LNA5NhHL/5fqZwCbJyNwJMY+w5FTs6K/YLmhaAQmbvC2Q9DlGLzwjaQpaj5ExJ+A4UtMetsEmkVtRVsOT+VNJ634cgcHO1PpbX4alrB/dPGEPCXed8g7wieU5IM05YTBKuJ6N0dZSoXz3gPOFBW9YF8daPtJEUM3gwxyumBEuJIbquIuq6wY5z223ppg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSvBINuxorqa43BikBWS/Ms22+x0Tvi+dlmbA22XKt4=; b=G+jib576OBK1TrxQp1VQ+LDcTCt7tQj/cs5qbbzCwJTg7x+Zq5ulM3B89BLznHN78pGRD4v/BjV2uixKg3V++UAvQeo1e8s6M57zChz8kDp48iC2Xud5g8O14lvKM0hzWs+Y+rps7if7hGu2QpvDTgIk+NLMVUsUlnG3ZspDs9WITJmMX4dhdEbW5j5kWwTtylMPaU8QM/J+Sn4qzM7wJpF3xVSxAprldsSMbCYIspPba6Uk9q2pF6n4pmNXfgNwS2t7YUmc8J/RGjQoIcR5x3O+/QKSixvgOmcVuKkj6KTKGw/znBZbfbHyFNLOETzgE4lZ5DQRjXZjCMvORkun0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HSvBINuxorqa43BikBWS/Ms22+x0Tvi+dlmbA22XKt4=; b=PlgxRMpXV0YD9Fw26MUsdAGIwqcHZskdzmG0vqMno3UQsSSfd2vKEEc18+MMFd4n2VxuNEMs8ablV3pBdWES0eTbrTaRZ+s80N08mj9k6da03La1T39M7wAKAqE6FeJIZTAmX8KpF+gwLA7JKDL64nedjx3u/K7D6UJlLGs+UM8= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB5342.eurprd08.prod.outlook.com (52.133.244.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20; Wed, 25 Sep 2019 07:04:10 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707%3]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 07:04:10 +0000 From: "Gavin Hu (Arm Technology China)" To: Zhang Xiao , "dev@dpdk.org" CC: "wenzhuo.lu@intel.com" , "marcdevel@gmail.com" , "stable@dpdk.org" , nd Thread-Topic: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability Thread-Index: AQHVc0wohur5eZKy4kCIAzebL8wiP6c75MTA Date: Wed, 25 Sep 2019 07:04:09 +0000 Message-ID: References: <1569379794-54847-1-git-send-email-xiao.zhang@intel.com> In-Reply-To: <1569379794-54847-1-git-send-email-xiao.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: da0bb299-bb51-4566-81d9-57a3f20e994b.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 9fc41259-5b09-4e00-ecb5-08d7418694d8 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB5342; X-MS-TrafficTypeDiagnostic: VI1PR08MB5342:|VI1PR08MB3408: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:3826;OLM:3826; x-forefront-prvs: 01713B2841 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(346002)(396003)(39860400002)(366004)(13464003)(199004)(189003)(5660300002)(74316002)(86362001)(7736002)(4326008)(6246003)(305945005)(66446008)(76116006)(71190400001)(64756008)(71200400001)(33656002)(66476007)(66556008)(26005)(66946007)(6506007)(102836004)(53546011)(55236004)(2906002)(3846002)(6116002)(2501003)(186003)(76176011)(99286004)(8936002)(81166006)(81156014)(8676002)(110136005)(316002)(6436002)(54906003)(14454004)(66066001)(478600001)(486006)(256004)(55016002)(446003)(7696005)(11346002)(476003)(9686003)(25786009)(229853002)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB5342; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: uNBnVUdRrUoe/Wdh6IAMJ1L4kuGgjMLdz5XcSaYdJyBYmy+i1Z7Sir9DzMOArqZDMl1an9YNQQgeYA23UfNJghDUAlKPX6aZzBSZA3Bon4g/ofRIniTRtaj3eqgYDVGhz2S1dRnctQP/sjr6TE8yOX5xP2qhtiAbBzL8zQAoMz4lJkEkBMabmXC0r66WxvRpTk9EsW+8U1WXlHGMadX4bhURivZj7r/QLaAaBNfoO7eK1oJe5+76EBXO+kMU32V30Auc1eTGoUuh3eN6akCRWNAXPKonvQXTRH5wdnJuUjKGEdujKeKtu0JUAe8/aKtwutI6DeWHFgyIT9yp++btrlxot1c3+mWy+RFbv554WQRG5DoyJXXI5ZAeji8AJ+yyFWkIs8T8evrI6Y3R6YSs/akk+eGJJzCvqmuhQqwM+vc= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5342 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT021.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(39860400002)(396003)(346002)(13464003)(189003)(199004)(50466002)(2501003)(74316002)(8746002)(486006)(81156014)(8936002)(99286004)(53546011)(22756006)(478600001)(14454004)(9686003)(8676002)(76176011)(52536014)(6506007)(55016002)(86362001)(46406003)(23726003)(26826003)(3846002)(6116002)(33656002)(70586007)(26005)(47776003)(70206006)(7696005)(356004)(66066001)(81166006)(54906003)(336012)(5660300002)(102836004)(11346002)(4326008)(186003)(229853002)(2906002)(316002)(126002)(305945005)(97756001)(446003)(476003)(25786009)(6246003)(450100002)(7736002)(110136005)(76130400001)(63350400001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3408; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 0bce2e53-bffb-4c79-6f97-08d74186906e X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB3408; NoDisclaimer: True X-Forefront-PRVS: 01713B2841 X-Microsoft-Antispam-Message-Info: Y6fCAq4tjKJ+mslRvAcpyy53pbapnUeHPuP2P9r2z88e+zxErMhoduJEhvrhSvgBRA+Ady1gvoCKdq0j3fNJu6JU9PdNV+tBPlDTE4i75iMDIMy6s31t0S7GtcN9M4kg1vajymeTgJmlGzYSixAMG8ikJWjijHwij+ngmNWmQkh7IEPRAMvT6982ieMMqc5pM366Ez4dHcBnOjtUuaNsv47vb9UYxUmd+60z041/YYqseZtXbxeMU9kZKql0gu7a8xw2fHvWH1WF5GWkpfDGbbi8bBLTkJUL8+4e3LY32PPHBPrFsQyW7kEz7f9GDXlbeNmzI73snOsxvedRvDvrHmj3/7ZXKaONBmWAh3Z24HKKygLHXBlBZJCf09YMnbD6U/PmM70DNKgYKONkBC+Ynr9MY5mhzBrb+gLgzCoLPxs= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2019 07:04:17.4011 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9fc41259-5b09-4e00-ecb5-08d7418694d8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3408 Subject: Re: [dpdk-stable] [dpdk-dev] net/ixgbe: fix X553 wrong speed capability X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Xiao, > -----Original Message----- > From: dev On Behalf Of Zhang Xiao > Sent: Wednesday, September 25, 2019 10:50 AM > To: dev@dpdk.org > Cc: wenzhuo.lu@intel.com; Zhang Xiao ; > marcdevel@gmail.com; stable@dpdk.org > Subject: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability >=20 > The speed capability of X553 1GbE should be ETH_LINK_SPEED_1G | > ETH_LINK_SPEED_100M | ETH_LINK_SPEED_10M rather than > ETH_LINK_SPEED_1G | > ETH_LINK_SPEED_10G. Correct it to fix the issue. >=20 > Fixes: e274f5732225 ("ethdev: add speed capabilities") > Cc: marcdevel@gmail.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Zhang Xiao > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 7eb3d05..e7c4ce3 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3843,6 +3843,11 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > dev_info->flow_type_rss_offloads =3D IXGBE_RSS_OFFLOAD_ALL; >=20 > dev_info->speed_capa =3D ETH_LINK_SPEED_1G | > ETH_LINK_SPEED_10G; Look through the following code, 100M and 1G is more common to across x530 = to x550 devices, while 10M and 10G is specific. Here 10G should be replaced by 100M and you can save some comparisons in th= e following code. /Gavin > + if (hw->device_id =3D=3D IXGBE_DEV_ID_X550EM_A_1G_T || > + hw->device_id =3D=3D IXGBE_DEV_ID_X550EM_A_1G_T_L) > + dev_info->speed_capa =3D ETH_LINK_SPEED_10M | > + ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G; > + > if (hw->mac.type =3D=3D ixgbe_mac_X540 || > hw->mac.type =3D=3D ixgbe_mac_X540_vf || > hw->mac.type =3D=3D ixgbe_mac_X550 || > -- > 2.7.4