From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BEA6A0613 for ; Fri, 30 Aug 2019 10:34:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBBFA1E8AD; Fri, 30 Aug 2019 10:34:00 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150059.outbound.protection.outlook.com [40.107.15.59]) by dpdk.org (Postfix) with ESMTP id ED93B1E8AD; Fri, 30 Aug 2019 10:33:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/cgM94rxbpz8aHU7ERXZ4tjOM8kVYkS+uYmWejLf4XI=; b=Mv4Mg78T2MQWf3K8n1aPOb4yfjB7sg6d4ASx/iQP++cShQ2/Osy/2R+GK1l8V2UonKFtFDB8/aNDULT9M5lSGpL/wgZlgJXGg1xz1Hx/0+E2xxLcgHsBH5028kzu9sa7xKVL2H6MBMFZohWUMzgWqoQDspTcF7OpYri4vy47LUs= Received: from VI1PR08CA0181.eurprd08.prod.outlook.com (2603:10a6:800:d2::11) by DB8PR08MB4956.eurprd08.prod.outlook.com (2603:10a6:10:e0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Fri, 30 Aug 2019 08:33:58 +0000 Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::207) by VI1PR08CA0181.outlook.office365.com (2603:10a6:800:d2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2220.16 via Frontend Transport; Fri, 30 Aug 2019 08:33:57 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2220.16 via Frontend Transport; Fri, 30 Aug 2019 08:33:56 +0000 Received: ("Tessian outbound d33df262a6a7:v27"); Fri, 30 Aug 2019 08:33:54 +0000 X-CR-MTA-TID: 64aa7808 Received: from 3c3ce502e64e.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.14.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id F8CDD2E2-3273-45B3-85BE-0EE8C91012B4.1; Fri, 30 Aug 2019 08:33:49 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3c3ce502e64e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Aug 2019 08:33:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lw1QdBoOiORrv3CYt9EyE4NFfucTWh2WwFQZxWnHbAdsRfTc1IfkY16mxg45ZyA6znV259cNjzp0X2NtDdPZiTNTdph/0pPvwG5I19iOpo748lY6FmCrVBc1+hZnTcI1RsySLzcIbI1kvDXV5G4U2Dzc+EWPhHgVfk5y3jpdF24dG5pZwHRVYiAGGMzbOVTNI9hCcE/lis0aOkFgjYPaWZWHhcGcFXZeJvLqktJcc6cUx6DlDxLsaSxi6YMhYC+Upz4Eg6N9UXS2Z6errWTevY/KeHvGBKU2JvUBSUsYwDea5u+zF+qLEu4x/HGlfN8sz96Z1BODb5z3RiDDta0AoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/cgM94rxbpz8aHU7ERXZ4tjOM8kVYkS+uYmWejLf4XI=; b=P3UBEVld9QPVM1Zbw50e7lQMCmJiWKlgDCDwrllNPb574GyKxlkhCz42KgZ10s6eOBRpur/bRR6kKklLwHBUFOx1d7yRnwW63yueZ/lfV9xuhDAJtnwoYVTiggOPS+Q0XZBjbpbvAsZib/JK7rBgLt6P0L9MJnLk4GejDGlrTDD3rkbcNifoHzrPuD9t4lPe9Rv5TxEnaxLeCB4SVxUMlLRSzQM2EbEt5YmrEjKnDKCtvvZFtxOFHhwKczMEKY9YA1hCdnxB0O8r/85cD/n1qgnMs59SS1Ag6SGLcd4FQQUDcYu7cNg4Qpqj7oVYeymJ3TgCBjvP+6H3Kvid3UbZuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/cgM94rxbpz8aHU7ERXZ4tjOM8kVYkS+uYmWejLf4XI=; b=Mv4Mg78T2MQWf3K8n1aPOb4yfjB7sg6d4ASx/iQP++cShQ2/Osy/2R+GK1l8V2UonKFtFDB8/aNDULT9M5lSGpL/wgZlgJXGg1xz1Hx/0+E2xxLcgHsBH5028kzu9sa7xKVL2H6MBMFZohWUMzgWqoQDspTcF7OpYri4vy47LUs= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB3680.eurprd08.prod.outlook.com (20.177.61.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2199.21; Fri, 30 Aug 2019 08:33:47 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::dc84:8edf:ba9f:faeb]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::dc84:8edf:ba9f:faeb%2]) with mapi id 15.20.2220.013; Fri, 30 Aug 2019 08:33:47 +0000 From: "Gavin Hu (Arm Technology China)" To: Honnappa Nagarahalli , "dev@dpdk.org" CC: nd , "thomas@monjalon.net" , "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "qi.z.zhang@intel.com" , "bruce.richardson@intel.com" , "stable@dpdk.org" , nd Thread-Topic: [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered for aarch64 Thread-Index: AQHVXe1YnHVIcyTWKE2sE3AE6gItIacTXnsA Date: Fri, 30 Aug 2019 08:33:47 +0000 Message-ID: References: <1565693011-33998-1-git-send-email-gavin.hu@arm.com> <1565693011-33998-2-git-send-email-gavin.hu@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 67c349dd-bf65-47cb-896a-87518cbf7478.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 194e221c-64f9-4d49-2ea8-08d72d24cc68 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB3680; X-MS-TrafficTypeDiagnostic: VI1PR08MB3680:|DB8PR08MB4956: X-MS-Exchange-PUrlCount: 2 x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1303;OLM:1303; x-forefront-prvs: 0145758B1D X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(366004)(39860400002)(376002)(396003)(13464003)(199004)(189003)(2906002)(33656002)(305945005)(14444005)(256004)(52536014)(110136005)(2501003)(316002)(229853002)(14454004)(5660300002)(54906003)(74316002)(478600001)(53936002)(966005)(102836004)(55236004)(9686003)(6306002)(66066001)(26005)(8676002)(6246003)(7696005)(81166006)(6506007)(6116002)(3846002)(53546011)(486006)(55016002)(81156014)(66476007)(66556008)(86362001)(476003)(64756008)(66446008)(11346002)(66946007)(446003)(186003)(76116006)(76176011)(6436002)(71190400001)(71200400001)(8936002)(4326008)(7736002)(25786009)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3680; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: VwBuB7btL8xfoTtLae8V4tadJSZoNo4eRJNZvFPMbBhX2RrQlj9UKN3jtAe5MIAv1uxiFmv1ggjprLnZaseBiMFzsoXK4ZEHDN2lRWYLMLJWdMjjuToX6CP8PQa7b7Y4mf5D84Mvu4ZI5CVGoFql1kMgKjy3vTzaBauVoH8w57euzmfgehq9++5n1jojQBFENrjiT8p9gF0PodPgFgClzfw3T28lK15om/N6f8M9NJWwXZGvtgSDCG7rfvy4WJ2JWzgC79QF4PakSZnTmPCbTBnG1irLsdLnGgzTyxLOjIF77UoumqQJsd+zgs1GKseAakTRkfKquF+csTu7vbwHeVDmPHXk7/NpTQrzPedTMoQgNbmMd4rmoBogSDXtykahFlWj4vwHowJ0m5uzw0k31N0DUdNrJTYZRD0DBWHcQdo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3680 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(39860400002)(376002)(346002)(2980300002)(199004)(189003)(13464003)(478600001)(966005)(26826003)(14454004)(53546011)(126002)(97756001)(86362001)(6116002)(3846002)(14444005)(22756006)(446003)(336012)(23726003)(63370400001)(11346002)(186003)(102836004)(26005)(476003)(33656002)(8936002)(47776003)(76176011)(63350400001)(81166006)(66066001)(8676002)(99286004)(52536014)(8746002)(74316002)(486006)(7696005)(81156014)(356004)(7736002)(5660300002)(46406003)(54906003)(110136005)(25786009)(316002)(6506007)(2501003)(50466002)(6306002)(9686003)(6246003)(4326008)(70586007)(70206006)(76130400001)(450100002)(305945005)(229853002)(55016002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB8PR08MB4956; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 23615c48-7bd5-45b1-e5ac-08d72d24c6fe X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DB8PR08MB4956; NoDisclaimer: True X-Forefront-PRVS: 0145758B1D X-Microsoft-Antispam-Message-Info: 5dCz4UjW9QkPdWTzRM7kWfkePaylDZzLb2aWgDqUI2ZPZR3+icrffLxOl5XYk30LBu83e2wO9FkW5RPAVtDIhgwUlPQtpOUgDIGH7j0o/OHYZLYwSRDXLN3TOAVyIAHCMXZuFkrXiYr4sg8rsxoIFUEkPSDEf2lifVcqFO7ZdrxZ2GRHHoTFnzJY1b0D0R5BUcWs6NzsL6kWVNEZ8eAUzhiFw03tcemc6xBtOH2fE3KQqpbRgiuZ+zM9Xr+E0ETs5LpCwnG8eLSkZTsx9yp/bALFSctwberJvwCzTTBRtY+PVR/IYwRKMyNqJtMosJ9b9qV6xWhp78RLZIc7n2krB9rtkmkjmH1efkrGESh5ueAAyYDlipj8aSNZgU+lpPg/NKDSQGUL399Kwrsqi/DPrRVlkXvpEgO+oXoyHfpuQVE= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2019 08:33:56.6916 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 194e221c-64f9-4d49-2ea8-08d72d24cc68 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4956 Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered for aarch64 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Honnappa, > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Thursday, August 29, 2019 6:10 AM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; thomas@monjalon.net; jerinj@marvell.com; > pbhagavatula@marvell.com; qi.z.zhang@intel.com; > bruce.richardson@intel.com; stable@dpdk.org; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered = for > aarch64 >=20 > Thanks Gavin, few comments are inline >=20 > > -----Original Message----- > > From: Gavin Hu > > Sent: Tuesday, August 13, 2019 5:44 AM > > To: dev@dpdk.org > > Cc: nd ; thomas@monjalon.net; jerinj@marvell.com; > > pbhagavatula@marvell.com; Honnappa Nagarahalli > > ; qi.z.zhang@intel.com; > > bruce.richardson@intel.com; stable@dpdk.org > > Subject: [PATCH 1/2] net/i40e: desc loading is unnecessarily ordered fo= r > > aarch64 > > > > For x86, the descriptors needs to be loaded in order, so in between two > > descriptors loading, there is a compiler barrier in place. > IMO, we can skip the above as this change applies to Arm platforms. Inste= ad, > capture this in the code in comments to explain why the ordering of the > loads is not required. This will help others reading the code. As the line of code was removed, there is no suitable place to add a commen= t. Instead adding it in the commit log makes the story complete and easy to un= derstand.=20 > [1] For aarch64, a > > patch [2] is in place to survive with discontinuous DD bits, the barrie= rs can > be > > removed to take full advantage of out-of-order execution. > > > > 50% performance gain in the RFC2544 NDR test was measured on > ThunderX2. > > 12.50% performan gain in the RFC2544 NDR test was measured on > Ampere > > eMAG80 platform. > > > > [1] > > > http://inbox.dpdk.org/users/039ED4275CED7440929022BC67E7061153D71 > > 548@ > > SHSMSX105.ccr.corp.intel.com/ > > [2] https://mails.dpdk.org/archives/stable/2017-October/003324.html > > > > Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Ruifeng Wang > > Reviewed-by: Steve Capper > > --- > > drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c > > b/drivers/net/i40e/i40e_rxtx_vec_neon.c > > index 83572ef..5555e9b 100644 > > --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c > > +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c > > @@ -285,7 +285,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, > > struct rte_mbuf **rx_pkts, > > /* Read desc statuses backwards to avoid race condition */ > > /* A.1 load 4 pkts desc */ > > descs[3] =3D vld1q_u64((uint64_t *)(rxdp + 3)); > > - rte_rmb(); > > > > /* B.2 copy 2 mbuf point into rx_pkts */ > > vst1q_u64((uint64_t *)&rx_pkts[pos], mbp1); > > -- > > 2.7.4