From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19695A0613 for ; Wed, 25 Sep 2019 11:06:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E83282AA0; Wed, 25 Sep 2019 11:06:32 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by dpdk.org (Postfix) with ESMTP id 46490DE3; Wed, 25 Sep 2019 11:06:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKxKm0Ia4jqHONro/8bIG7HebypbVs8O2fiZjMYWc7s=; b=K2UOfQx0UyLbF+cNqkHyQdCSoz7IdhkUXzzTUgCp6hD/GT7p/+Kf8h1nkJmZMxXfWZkOU9jNu0iOKpcx/8yIFGfGnwyYbCi1oP6taUfJm6QK8WCURsvXJ92cio7ICgBWO6kkM8+tT+TRA0glLC/29r7dUmyzss3asWSSv8Mt2rQ= Received: from VI1PR0802CA0011.eurprd08.prod.outlook.com (2603:10a6:800:aa::21) by AM5PR0802MB2435.eurprd08.prod.outlook.com (2603:10a6:203:9e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.23; Wed, 25 Sep 2019 09:06:26 +0000 Received: from VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::204) by VI1PR0802CA0011.outlook.office365.com (2603:10a6:800:aa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.23 via Frontend Transport; Wed, 25 Sep 2019 09:06:26 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT015.mail.protection.outlook.com (10.152.18.176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20 via Frontend Transport; Wed, 25 Sep 2019 09:06:25 +0000 Received: ("Tessian outbound 927f2cdd66cc:v33"); Wed, 25 Sep 2019 09:06:23 +0000 X-CR-MTA-TID: 64aa7808 Received: from c62499150a6f.1 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.13.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 32BB24E0-E755-4CE8-B2C9-C016EEB2315F.1; Wed, 25 Sep 2019 09:06:18 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c62499150a6f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 25 Sep 2019 09:06:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aAstErVJ+IQ2pCHxj+Hh3UT6+em8DAr1uOgr6BqsnKSp3ckeiSlKLkZMjOeLpViQ9gZjYc0UdJCTGjPhRsZ6olrdNAcVR7SsyJ43C+FC7VjXtKDEyvxd8JIvhPdt2uMkY/T/fNh/aVhAxkhhcXokOCGWxV1mMn3QNVXNDztrK4BqUvGeCk7EJSTVg9I5xyINvHuNx/GKV7IPp2RJoDLbJecRD5PCKKVmpxBs7DEfx1JjOhKgon8gTdBX/BT36M+Mykg19yOmticzpuEwxJQXFKsZ+1zLB16gELzVvNlpVPIzkj7gWqtmClK5l2/Q0ChUzZ2YOV9u82E21J935xJ0EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKxKm0Ia4jqHONro/8bIG7HebypbVs8O2fiZjMYWc7s=; b=GQqlW9Sb9KX/2FMnUxzn4qfIm1XPe0/30XDF45SlrL+HJ+vROF8fFdy3H4E4P9l+HN9hDPrXbxl85osSqlQ8s2SZ2c1af1FGWxPLoWBr6zykWyE5P/Kt7luH8lC1UwUG1ZPmgZNWh1X0C+LzlNNjMy5xkNpa4aoG70h9cYU6rNZDc7gteyDY+SFbw5K5SEW0Zu7jc1z+Zwvxinjm1R/vy1ZF68XXTHIezlvZlWi3E/4Tgjz0toDc9i9Fwfw3LQ/zonK34Xalwi8MnGrRnz9EZULgjBEH7gbxH0T9dRceocUTaImgXQXs1SEkZesRJgc87z2dtf5rtvlc9940AP2QeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZKxKm0Ia4jqHONro/8bIG7HebypbVs8O2fiZjMYWc7s=; b=K2UOfQx0UyLbF+cNqkHyQdCSoz7IdhkUXzzTUgCp6hD/GT7p/+Kf8h1nkJmZMxXfWZkOU9jNu0iOKpcx/8yIFGfGnwyYbCi1oP6taUfJm6QK8WCURsvXJ92cio7ICgBWO6kkM8+tT+TRA0glLC/29r7dUmyzss3asWSSv8Mt2rQ= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB3183.eurprd08.prod.outlook.com (52.133.15.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2284.20; Wed, 25 Sep 2019 09:06:16 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::c09a:49d3:eab2:f707%3]) with mapi id 15.20.2284.023; Wed, 25 Sep 2019 09:06:16 +0000 From: "Gavin Hu (Arm Technology China)" To: "Zhang, Xiao" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "marcdevel@gmail.com" , "stable@dpdk.org" , nd , nd Thread-Topic: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability Thread-Index: AQHVc0wohur5eZKy4kCIAzebL8wiP6c75MTAgAAnlgCAAAzE0A== Date: Wed, 25 Sep 2019 09:06:16 +0000 Message-ID: References: <1569379794-54847-1-git-send-email-xiao.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 9a0c2062-4895-4b1d-bd68-2d39d293f790.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 7095d3df-961e-4b2c-b885-08d74197a47b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR08MB3183; X-MS-TrafficTypeDiagnostic: VI1PR08MB3183:|AM5PR0802MB2435: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; x-forefront-prvs: 01713B2841 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(199004)(189003)(13464003)(256004)(2501003)(55016002)(71200400001)(71190400001)(66066001)(9686003)(478600001)(6436002)(4326008)(6246003)(229853002)(11346002)(476003)(102836004)(486006)(14454004)(446003)(76176011)(186003)(99286004)(7696005)(6506007)(55236004)(26005)(53546011)(6116002)(3846002)(52536014)(2906002)(86362001)(76116006)(5660300002)(66446008)(64756008)(66556008)(66476007)(66946007)(33656002)(25786009)(8676002)(8936002)(81166006)(81156014)(74316002)(305945005)(54906003)(316002)(7736002)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3183; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: 7rk+W1vR4OYowC+7qUaVLA5xTywMTIorOqi4JkoWAZi86lwaokdYBqYuSFSU14DwW2lsPdcj5laEJu5E+x6BmPRppgtgKLhxVPDPVyOLWMkwdDsz6qtQSkc+xxsSXQppVzbmh44IlSUxdOy8IV8KBlARwKvx2w5QtIy8j3KUvOthsrwDIbYxqUSjtu3trIfeoNF3SqWZEOcY5zXTFydWooZPI0O2H4hYBujGxeKqnzZwYHo0UdL5TNikcYByzpE9R5lEX1DVCUaWXAnnyMTJQyTmK4x47WO9HeXkcfrtgTEDHPiKdsHnr/xfgQr2JFMfZL1EwIkK3Y5PXshytThklfsKiNXCRMX2VHEFN4ovmO0J3gYcK0yFD8b5uvOju3fLKMebaUW08EtvRH/3+6vMUDWQv59sAAFWivbTv/rx83g= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3183 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(346002)(39860400002)(136003)(199004)(189003)(13464003)(450100002)(5660300002)(86362001)(76130400001)(2906002)(8936002)(97756001)(47776003)(54906003)(11346002)(478600001)(110136005)(52536014)(46406003)(3846002)(446003)(50466002)(2501003)(4326008)(23726003)(6116002)(70586007)(70206006)(63350400001)(22756006)(186003)(6506007)(102836004)(229853002)(305945005)(26005)(33656002)(7696005)(356004)(53546011)(14454004)(486006)(126002)(476003)(26826003)(6246003)(336012)(8676002)(76176011)(66066001)(55016002)(9686003)(81156014)(99286004)(316002)(36906005)(7736002)(81166006)(8746002)(74316002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0802MB2435; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 2e985268-3804-4ffc-0e8a-08d741979f4e X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600167)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM5PR0802MB2435; NoDisclaimer: True X-Forefront-PRVS: 01713B2841 X-Microsoft-Antispam-Message-Info: stdOthlLNwNXtLy+z4ZTqk6XCdS0r4p9cf11RCg+RrqLNAkF0DO8+iqcfZ6F5St/44e6HgdfNFRoyfqoljPFo8Q2LDYF2wH/GrZSTqeKPr0LKvNyv0HJvUVV9h4jnzJcLWN0tYgLDm/F6bUF4dy1Yq0y0wLoy4jXdxoc07NedHG3pAHwbHmLFy+GMdynxCmZHYsvcvL88ipceX2F3xss+YLmhBzoEbSDn6KWqfyZWT3F9s2WNxW1wBr6ZtKRadW4DE4JbLfgvwcSP0QELtsPih8hYSoW6iylEsh7TD1xLYJ1EIEQcs9AUL2wYkX6HDWm+FJrqLls1v7K8zwjE+XfypiUeCg9BPI0Hzn3MABFBwn6PXVA1hjeEhUzoZWnckP12HcI4z42K2dLj+rf8ctE//PkFgJwn/wJLtqeObpSO2I= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2019 09:06:25.0292 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7095d3df-961e-4b2c-b885-08d74197a47b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2435 Subject: Re: [dpdk-stable] [dpdk-dev] net/ixgbe: fix X553 wrong speed capability X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Xiao, > -----Original Message----- > From: Zhang, Xiao > Sent: Wednesday, September 25, 2019 4:16 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: Lu, Wenzhuo ; marcdevel@gmail.com; > stable@dpdk.org; nd > Subject: RE: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability >=20 > Hi Gavin, >=20 > > -----Original Message----- > > From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > > Sent: Wednesday, September 25, 2019 3:04 PM > > To: Zhang, Xiao ; dev@dpdk.org > > Cc: Lu, Wenzhuo ; marcdevel@gmail.com; > > stable@dpdk.org; nd > > Subject: RE: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability > > > > Hi Xiao, > > > > > -----Original Message----- > > > From: dev On Behalf Of Zhang Xiao > > > Sent: Wednesday, September 25, 2019 10:50 AM > > > To: dev@dpdk.org > > > Cc: wenzhuo.lu@intel.com; Zhang Xiao ; > > > marcdevel@gmail.com; stable@dpdk.org > > > Subject: [dpdk-dev] net/ixgbe: fix X553 wrong speed capability > > > > > > The speed capability of X553 1GbE should be ETH_LINK_SPEED_1G | > > > ETH_LINK_SPEED_100M | ETH_LINK_SPEED_10M rather than > > ETH_LINK_SPEED_1G > > > | ETH_LINK_SPEED_10G. Correct it to fix the issue. > > > > > > Fixes: e274f5732225 ("ethdev: add speed capabilities") > > > Cc: marcdevel@gmail.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Zhang Xiao > > > --- > > > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > > index 7eb3d05..e7c4ce3 100644 > > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > > @@ -3843,6 +3843,11 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, > > > struct rte_eth_dev_info *dev_info) > > > dev_info->flow_type_rss_offloads =3D IXGBE_RSS_OFFLOAD_ALL; > > > > > > dev_info->speed_capa =3D ETH_LINK_SPEED_1G | > ETH_LINK_SPEED_10G; > > Look through the following code, 100M and 1G is more common to across > x530 > > to x550 devices, while 10M and 10G is specific. > > Here 10G should be replaced by 100M and you can save some > comparisons in > > the following code. >=20 > Sorry, I am not quite clear about your comments here. > Do you mean I should change the logic of the legacy code to make it short= er > or there is some mistake here? > This code is not only for x540 and x550, but also for 82598, 82599, x550e= m, > etc. Here if I replace 10G with 100M, still need add lots of other > comparisons. >=20 > Xiao Functionally the old code is ok. I just want to make it look better and save some comparisons.=20 Since not all NICs are listed here and 1G and 10G are more common, that's o= k.=20 >=20 > > /Gavin > > > > > + if (hw->device_id =3D=3D IXGBE_DEV_ID_X550EM_A_1G_T || > > > + hw->device_id =3D=3D > IXGBE_DEV_ID_X550EM_A_1G_T_L) > > > + dev_info->speed_capa =3D ETH_LINK_SPEED_10M | > > > + ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G; > > > + > > > if (hw->mac.type =3D=3D ixgbe_mac_X540 || > > > hw->mac.type =3D=3D ixgbe_mac_X540_vf || > > > hw->mac.type =3D=3D ixgbe_mac_X550 || > > > -- > > > 2.7.4