patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] missing ring memory barrier in 17.11
@ 2019-10-01  7:41 Thomas Monjalon
  2019-10-01  8:48 ` Luca Boccassi
  2019-10-08  6:41 ` Gavin Hu (Arm Technology China)
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-10-01  7:41 UTC (permalink / raw)
  To: bluca, Gavin Hu
  Cc: stable, honnappa.nagarahalli, Nipun Gupta, Konstantin Ananyev

Hi Luca, Gavin,

It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before slots")
should be backported in 17.11.

This patch is missing because the root cause is wrongly identified.
It is referenced as
	Fixes: c9fb3c62896f ("ring: move code in a new header file")
in 18.02, but in reality it is from 17.05:
	Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")

Do you agree?



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] missing ring memory barrier in 17.11
  2019-10-01  7:41 [dpdk-stable] missing ring memory barrier in 17.11 Thomas Monjalon
@ 2019-10-01  8:48 ` Luca Boccassi
  2019-10-01 14:05   ` Honnappa Nagarahalli
  2019-10-08  6:41 ` Gavin Hu (Arm Technology China)
  1 sibling, 1 reply; 4+ messages in thread
From: Luca Boccassi @ 2019-10-01  8:48 UTC (permalink / raw)
  To: Thomas Monjalon, Gavin Hu
  Cc: stable, honnappa.nagarahalli, Nipun Gupta, Konstantin Ananyev

On Tue, 2019-10-01 at 09:41 +0200, Thomas Monjalon wrote:
> Hi Luca, Gavin,
> 
> It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before
> slots")
> should be backported in 17.11.
> 
> This patch is missing because the root cause is wrongly identified.
> It is referenced as
> 	Fixes: c9fb3c62896f ("ring: move code in a new header file")
> in 18.02, but in reality it is from 17.05:
> 	Fixes: 0dfc98c507b1 ("ring: separate out head index
> manipulation")
> 
> Do you agree?

Hi,

Makes sense to me, and it applies cleanly (after accounting for the
source file name change). I'll queue it up for 17.11.8.

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] missing ring memory barrier in 17.11
  2019-10-01  8:48 ` Luca Boccassi
@ 2019-10-01 14:05   ` Honnappa Nagarahalli
  0 siblings, 0 replies; 4+ messages in thread
From: Honnappa Nagarahalli @ 2019-10-01 14:05 UTC (permalink / raw)
  To: Luca Boccassi, thomas, Gavin Hu (Arm Technology China)
  Cc: stable, Nipun.gupta, Konstantin Ananyev, nd

China team is on holiday. Yes, we should apply this patch to 17.11

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Tuesday, October 1, 2019 3:48 AM
> To: thomas@monjalon.net; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>
> Cc: stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Nipun.gupta@nxp.com; Konstantin
> Ananyev <konstantin.ananyev@intel.com>
> Subject: Re: missing ring memory barrier in 17.11
> 
> On Tue, 2019-10-01 at 09:41 +0200, Thomas Monjalon wrote:
> > Hi Luca, Gavin,
> >
> > It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before
> > slots")
> > should be backported in 17.11.
> >
> > This patch is missing because the root cause is wrongly identified.
> > It is referenced as
> > 	Fixes: c9fb3c62896f ("ring: move code in a new header file") in
> > 18.02, but in reality it is from 17.05:
> > 	Fixes: 0dfc98c507b1 ("ring: separate out head index
> > manipulation")
> >
> > Do you agree?
> 
> Hi,
> 
> Makes sense to me, and it applies cleanly (after accounting for the source file
> name change). I'll queue it up for 17.11.8.
> 
> --
> Kind regards,
> Luca Boccassi

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] missing ring memory barrier in 17.11
  2019-10-01  7:41 [dpdk-stable] missing ring memory barrier in 17.11 Thomas Monjalon
  2019-10-01  8:48 ` Luca Boccassi
@ 2019-10-08  6:41 ` Gavin Hu (Arm Technology China)
  1 sibling, 0 replies; 4+ messages in thread
From: Gavin Hu (Arm Technology China) @ 2019-10-08  6:41 UTC (permalink / raw)
  To: thomas, bluca
  Cc: stable, Honnappa Nagarahalli, Nipun.gupta, Konstantin Ananyev

Hi Thomas, Luca,

Thanks for reminding and sorry for late response(due to long holiday).

I have ported the patch and already sent to the stable mailing list, please help check and merge, thanks!

Best Regards,
Gavin

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, October 1, 2019 3:42 PM
> To: bluca@debian.org; Gavin Hu (Arm Technology China)
> <Gavin.Hu@arm.com>
> Cc: stable@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Nipun.gupta@nxp.com; Konstantin
> Ananyev <konstantin.ananyev@intel.com>
> Subject: missing ring memory barrier in 17.11
>
> Hi Luca, Gavin,
>
> It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before slots")
> should be backported in 17.11.
>
> This patch is missing because the root cause is wrongly identified.
> It is referenced as
>       Fixes: c9fb3c62896f ("ring: move code in a new header file")
> in 18.02, but in reality it is from 17.05:
>       Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation")
>
> Do you agree?
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01  7:41 [dpdk-stable] missing ring memory barrier in 17.11 Thomas Monjalon
2019-10-01  8:48 ` Luca Boccassi
2019-10-01 14:05   ` Honnappa Nagarahalli
2019-10-08  6:41 ` Gavin Hu (Arm Technology China)

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox