From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DC04A2F6B for ; Tue, 8 Oct 2019 08:41:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6EA132AB; Tue, 8 Oct 2019 08:41:16 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130045.outbound.protection.outlook.com [40.107.13.45]) by dpdk.org (Postfix) with ESMTP id A3E781BF61 for ; Tue, 8 Oct 2019 08:41:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NiLa+jloHGDU5Ik+Dh1JcUX4/P0iDE0a8gLWUAWb+Xg=; b=nQluQipkpD7NVN+6+SQFrD/nFhBBoJm+W76DmnKz4apq807omsVB7JjxWO5+TV0oitPwKSCQ311AXOCCPtn1DbvhGVIc/byYyUzKMOY41/ddcStRrmKQug4IcS4Io/B9X+emj283ISZUNv2pnxdjyEvE+b4PAsUtWt5cjFyN7AU= Received: from VI1PR0802CA0008.eurprd08.prod.outlook.com (2603:10a6:800:aa::18) by AM0PR08MB5300.eurprd08.prod.outlook.com (2603:10a6:208:18e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Tue, 8 Oct 2019 06:41:12 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::209) by VI1PR0802CA0008.outlook.office365.com (2603:10a6:800:aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2327.24 via Frontend Transport; Tue, 8 Oct 2019 06:41:12 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Tue, 8 Oct 2019 06:41:10 +0000 Received: ("Tessian outbound 0cf06bf5c60e:v33"); Tue, 08 Oct 2019 06:41:07 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9c33aaccd7f7.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.12.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 19FF2919-8A0A-4043-8038-7C75C6AD5773.1; Tue, 08 Oct 2019 06:41:02 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c33aaccd7f7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 08 Oct 2019 06:41:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O6keAQtGcdhnpvqAirJiXqgNaw/bb7O10EW1j/2C3vIcdINjg2DfeaaGvE7YJnPZokpwprA1On/+3UNetdSTjKuwf62+jZy/MyRbaoNaQf3Qi6qg0TQo0SS6LOIYHRtMB13XMCJCJhs/eSn1d+9RI/DDYErhD+p7L3/ZbMZwcjYSb8HDccqg1AriLqP1PF1hQtpQacS3f/AE6uXd77eJbp9AB5hjMILX44aRu/5/5VSrN2/HDa6FbtT5l7FtS7AYqi6DImHOJDJC9S2N/oXk3+RgpLAQ8IR7DCnGVsa3oBGEwQucw+FnFBWP5//mr1ZjyR96XV1dRTYm5FBJ+ApZkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1mGqdLnDUlZVfXcYPgp/OEiXqggcp3H7JUDfVyK4+k=; b=YrrelZyfs6EplsLxH9YbgSqXj4D+f9H+1RAdK82OvSYE+Ms1qP5ZY7Gjl/0pRMQhql6qSyI17b9ajJwe1s4HwxnAdPTJM7um7yU6O4grHaloZ52vhx/hyfEZT0gF6/eCjAWkY4kJiO7SXLkbEZl5a8rPliTEPLE/lixebppSxx5cdtEMHKGR6GU045uaopnZranpCrAvViXZItdDjV5FfErnpjCh8A6QlSkL3rAvG2o6q0eYHf+vwtBvfFbBumhNAuMYBv1Q7IiO15e6nMAqSbDRcvFQAbFfKInNRI+U6bglUpab1ESwcQgmKyUpkAjaYbIy/DfCP77KSUD/XJxSzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1mGqdLnDUlZVfXcYPgp/OEiXqggcp3H7JUDfVyK4+k=; b=ym0IfX1E01En+QyEzXnAJZOXS52k8Bju8Rmmaj/1ysiXVfUg4OWsMa82TGV2I3QVEkA90jnmQrFNoFWoeVKiamJUPJut20KoPm9VGNN94ll4doEgHHnUMharNblAqfw0PitEzteHHdK+/bRDju57TctyglOHJUYxEGFItA7CMpk= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB5472.eurprd08.prod.outlook.com (52.133.246.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.23; Tue, 8 Oct 2019 06:41:00 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::f8ea:be13:4728:f5fc]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::f8ea:be13:4728:f5fc%4]) with mapi id 15.20.2327.026; Tue, 8 Oct 2019 06:41:00 +0000 From: "Gavin Hu (Arm Technology China)" To: "thomas@monjalon.net" , "bluca@debian.org" CC: "stable@dpdk.org" , Honnappa Nagarahalli , "Nipun.gupta@nxp.com" , Konstantin Ananyev Thread-Topic: missing ring memory barrier in 17.11 Thread-Index: AQHVeCu6MiIQCoSEIkugdVS+cCwHp6dQVfmQ Date: Tue, 8 Oct 2019 06:41:00 +0000 Message-ID: References: <2613008.bAPQ5MWe9V@xps> In-Reply-To: <2613008.bAPQ5MWe9V@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 140bdd79-c63b-4a65-9f33-916ff5847bee.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 1977ebec-3549-4a16-87ae-08d74bba819c X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VI1PR08MB5472:|VI1PR08MB5472:|AM0PR08MB5300: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; x-forefront-prvs: 01842C458A X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(39860400002)(346002)(376002)(136003)(13464003)(189003)(199004)(6116002)(256004)(54906003)(86362001)(66476007)(186003)(26005)(66446008)(66556008)(64756008)(99286004)(74316002)(7736002)(66946007)(305945005)(102836004)(71200400001)(7696005)(71190400001)(76176011)(6506007)(53546011)(3846002)(81156014)(8676002)(316002)(110136005)(446003)(81166006)(476003)(11346002)(55236004)(76116006)(486006)(8936002)(25786009)(4744005)(6246003)(478600001)(5660300002)(2501003)(4326008)(229853002)(66066001)(6436002)(55016002)(9686003)(33656002)(14454004)(52536014)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB5472; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: M96uGfMHPFm5eAsfdZvE8YZE9hKVbHZr478vVwdSPwm3kHxEbF3mQUC8Cx67A7mneGPjRtGibF/CXrEqr8AmddPECzfp5VWf5X4wiGfpTCTiw91E5nqoHKdLCiQl0PluwcYTqtp2MPzZrr5C7kZolc/hI0SVDqTjJ2Jzlxv9/QldUeby2F2i7baWnoHwHp6Ao4C4tI5DhaDgOybkxTDohba0nqIDUfkdoM6g93mA6U6YUs2ZrV8mk7sOdoZ61NJU5cvIUqYgmIay9qpsrufa2uxhfOwEq63K3EXFmGjyPIr4AVVaC0cqHEgeBeEwNfxh9NznhpvZyqAeVo8KwIN2Ib8cD/fcyfpQmzVmM9FQs2G8kqD22F9x1kF9xWIuvZcqRFlXNMoK6f3A8Ml5RnZESZ9XyVnSUBkIujDd5OUF1Ic= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5472 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(376002)(396003)(136003)(199004)(40434004)(189003)(13464003)(478600001)(50466002)(102836004)(26826003)(36906005)(316002)(70206006)(54906003)(70586007)(2501003)(336012)(52536014)(7696005)(305945005)(26005)(33656002)(14454004)(7736002)(74316002)(5660300002)(5024004)(25786009)(63350400001)(76176011)(46406003)(86362001)(14444005)(22756006)(99286004)(66066001)(229853002)(53546011)(76130400001)(126002)(81156014)(97756001)(4326008)(9686003)(446003)(81166006)(47776003)(8936002)(23726003)(8676002)(110136005)(6116002)(186003)(8746002)(6506007)(2906002)(55016002)(107886003)(356004)(11346002)(6246003)(476003)(3846002)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB5300; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 1e806ff4-52a4-48c5-35af-08d74bba7bb4 X-Forefront-PRVS: 01842C458A X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Apsf669d5QZSlbAOiwZJwbq7lf3ak0DXW3Bcs9CeYohV9BnVNHK/7royR85TrDprr+ATAn6pNMTvqA/u4iw4R880tRR/lBvnoL4i68heUf3NFZy3GV6KDWuZsx0GHaBWLyguOFNzGm33jX9eHpoe0xu7Z0KPo+WeaV2Loi/LwUWSTCtxsqR8m2dOFpBLeCry16BUu/XCZR3vkSAgiyrW0wx5csATzTAZDS0FVUhnD8zdtTC9zafbMPAV7HqGlfoU2/kz1ORRyUc7NNgYBCt5TJjG2F+VH7yfLSjTg9Ww51TUbzJnv+i+Wxgh5kxCNYgXbaJz/A9qej/OeE4dS60uefGF5jeW9lxXiLS3JCDNQfqxkW/8qJiqmiDdtucfsj8rttdNqobnIre+LbtgOMpTIR/Ig3oXXcEt6hW04S0oV7I= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2019 06:41:10.5643 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1977ebec-3549-4a16-87ae-08d74bba819c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5300 Subject: Re: [dpdk-stable] missing ring memory barrier in 17.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Thomas, Luca, Thanks for reminding and sorry for late response(due to long holiday). I have ported the patch and already sent to the stable mailing list, please= help check and merge, thanks! Best Regards, Gavin > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, October 1, 2019 3:42 PM > To: bluca@debian.org; Gavin Hu (Arm Technology China) > > Cc: stable@dpdk.org; Honnappa Nagarahalli > ; Nipun.gupta@nxp.com; Konstantin > Ananyev > Subject: missing ring memory barrier in 17.11 > > Hi Luca, Gavin, > > It seems the fix 85cffb2eccd9 ("ring: enforce reading tail before slots") > should be backported in 17.11. > > This patch is missing because the root cause is wrongly identified. > It is referenced as > Fixes: c9fb3c62896f ("ring: move code in a new header file") > in 18.02, but in reality it is from 17.05: > Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") > > Do you agree? > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.