From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Steve Capper <Steve.Capper@arm.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-stable] [PATCH v3 1/3] test/rcu: fix the compiling error for armv8.2
Date: Thu, 21 Nov 2019 11:23:50 +0000 [thread overview]
Message-ID: <VI1PR08MB5376D11F5DC438937A69AD668F4E0@VI1PR08MB5376.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <2954535.brShQIuEvG@xps>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Thursday, November 21, 2019 6:19 AM
> To: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Steve Capper
> <Steve.Capper@arm.com>
> Cc: stable@dpdk.org; dev@dpdk.org; nd <nd@arm.com>;
> david.marchand@redhat.com
> Subject: Re: [dpdk-stable] [PATCH v3 1/3] test/rcu: fix the compiling error for
> armv8.2
>
> 11/11/2019 06:41, Gavin Hu:
> > With "-march=armv8.2-a" specified, a compiling error generated:
> > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> > expressions of different signedness: ‘unsigned int’ and ‘int’
> > [-Werror=sign-compare]
> >
> > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Steve Capper <steve.capper@arm.com>
> > ---
> > --- a/app/test/test_rcu_qsbr.c
> > +++ b/app/test/test_rcu_qsbr.c
> > /* Skip one update */
> > - if (i == (RTE_MAX_LCORE - 10))
> > + if (i == (unsigned int)(RTE_MAX_LCORE - 10))
>
> For N1 SDP, RTE_MAX_LCORE = 4.
> So this test weird.
> Why not using rand() to find a number between 0 and max ?
>
> You are hiding a real failure with a forced type casting.
>
> Please reviewers, explain why you think it is the right thing to do?
>
Thanks for pointing out this issue, will fix in next release.
next prev parent reply other threads:[~2019-11-21 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1564616902-13861-1-git-send-email-gavin.hu@arm.com>
2019-07-31 23:32 ` [dpdk-stable] [PATCH 1/2] " Gavin Hu
2019-07-31 23:48 ` [dpdk-stable] [PATCH v2 1/3] " Gavin Hu
2019-11-11 5:41 ` [dpdk-stable] [PATCH v3 " Gavin Hu
2019-11-20 22:18 ` Thomas Monjalon
2019-11-21 11:23 ` Gavin Hu (Arm Technology China) [this message]
2019-11-25 3:36 ` [dpdk-stable] [PATCH v4] test/rcu: fix build for small number of cores Gavin Hu
2019-11-25 22:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB5376D11F5DC438937A69AD668F4E0@VI1PR08MB5376.eurprd08.prod.outlook.com \
--to=gavin.hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Steve.Capper@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).