Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk

["Niklas Söderlund" <niklas.soderlund@corigine.com>]

Hi Ferruh,

Thanks for your continues effort in dealing with NFP patches.

On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote:
> On 2/8/2023 9:15 AM, Chaoyong He wrote:
> > From: Peng Zhang <peng.zhang@corigine.com>
> > 
> > 48-bit DMA address is supported in the firmware with NFDk, so enable
> > this feature in PMD now. But the firmware with NFD3 still just
> > support 40-bit DMA address.
> > 
> > RX free list descriptor, used by both NFD3 and NFDk, is also modified
> > to support 48-bit DMA address. That's OK because the top bits is always
> > set to 0 when assigned with 40-bit DMA address.
> > 
> > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx")
> > Cc: jin.liu@corigine.com
> > Cc: stable@dpdk.org
> > 
> 
> Why a backport is requested? As far as I understand this is not fixing
> anything but extending device capability. Is this a fix?

I agree this is a bit of a grey zone. We reasoned this was a fix as we 
should have done this from the start in the commit that added support 
for NFDk. Are you OK moving forward with this as a fix or would you 
prefer we resubmit without the request to backport?

> 
> > Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> 

-- 
Kind Regards,
Niklas Söderlund