From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA62341CA9 for ; Wed, 15 Feb 2023 18:47:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FBBA42D2D; Wed, 15 Feb 2023 18:47:28 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2119.outbound.protection.outlook.com [40.107.102.119]) by mails.dpdk.org (Postfix) with ESMTP id C9C43410DD; Wed, 15 Feb 2023 18:47:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c9j24Mv4KkH4Xkm+iZM4urxqcoJN/CEDxBWoGHu4zdPPwq1XR1He44jNsHxzdnQ66fw9zv80y7N3FU+wPBqqTuR4jnfdEovBtKIVtzqlJtRBKFjBNPgrp1WXvVNroqOheHE83+2S3WIqoTIS0fi3C1tRIB6zEtfAeo9pi1VLiiUcbRrBMTRrd/OdnQvj/8x+wsXHhb/DwtKU2NOLu9YFhuOlKlYXculDlYwfpHnPT/k8Rgmdw+67xpmKxVNAXjamLZhkR26gbM6E5nXkQHEMrjzLXGUucuo6rN/O/e973X3FDG0NKeB0xITVf17/0MFVqAIb8jSYyXSDLD0wWySJ7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YHftsZwjmXYtD7LE9KcSGW4NNIwE5jF9KaKr8pc1Gdw=; b=B6PWqPCi4jos13A3DcsNWT69cwhh1vXmNA66y8ZBrRsyo92c8g5x5II2v46wlF5GNp1mK02NuhR+V0pj+TD9GkpwXxsNNf+xbJLu3jwowTr+RAuCwG7oWRisOZKAT2of9TDyszlV4BZdh0FDKJt+9o79hOARoXQwfiwj2NB6wEMK/3d3Zqsw5Uo1x9VCXMz6Y8vTuCtxOFisPnl5QZ48HT8g6+bxM/Obo4NN8P+g6WejMIEoSireW5HAWEkszYPyGRe934oIHJ9ne5SsRHIguMD8pmZKoPH66qBo31Z0jnWJfjIMyxFv/5sQe6yKpEwo67HVh+zUjUhLPsh/PG2NcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHftsZwjmXYtD7LE9KcSGW4NNIwE5jF9KaKr8pc1Gdw=; b=K3JsoOu7GDHUSjHXWi7vdVvXaQ9OVg4Wfja7CzHuKUN8Za6RfGsgLyQdEelcmz6C+sjafr5TYJuxbtpQxJjT78ZiLMUJGnH9cIyVtt+OJ9SMShn9iL54rHp4povTySUMiCqDsysuwci+7qRKf3KRM/94SaG/CnfC3zYJ0+0qg7o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) by SJ0PR13MB6152.namprd13.prod.outlook.com (2603:10b6:a03:4e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Wed, 15 Feb 2023 17:47:24 +0000 Received: from SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::90b0:f667:bccd:64ba]) by SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::90b0:f667:bccd:64ba%9]) with mapi id 15.20.6086.026; Wed, 15 Feb 2023 17:47:23 +0000 Date: Wed, 15 Feb 2023 18:47:11 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Ferruh Yigit Cc: Chaoyong He , dev@dpdk.org, Luca Boccassi , Kevin Traynor , oss-drivers@corigine.com, Peng Zhang , jin.liu@corigine.com, stable@dpdk.org Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk Message-ID: References: <20230208091544.22122-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: GVYP280CA0007.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:fa::27) To SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB6037:EE_|SJ0PR13MB6152:EE_ X-MS-Office365-Filtering-Correlation-Id: 03181f5d-baf5-4311-e8ce-08db0f7cb177 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4UcR+qYMUl7eVNJ6tjLB/br0qGIrs/tNfriwxF6jVKOAMZ2akBQxUVjy7W6WRhg9Su0NF5X6QXtWDirzK+ToKhXZz6DLmbNIvV7N+XhXXDD2mW2apfugGv5q1eMSt1Mc7NE00LfFWAv5/xFMlx+gOyC1ONoLw2MMUTSylhfmLXKfIYX9pHc7hjLBUx7AiFvFKOBIJM7yF/FUs4eH1/eI6NTSbuTm/THeWF5ssJnCVlrp0p77Bl3Cy5HuKCbP+WsDD2jiU1wCFFI8R3awxiMlDKIvpTKHLTDW7OaPlhJwg+Q6xYX+W0jFVjc2WJ82rJIpUyZDAlzpirzNYwm/ueNZcqQ4/Sdtau1cqa7rr2s5QSl9R5KIBQmrNZyYxx9HN4T2MGwclnAyPZ4RKhqfXjy8yx0Jr4poOfXLiio5+gyxGb4s7+YKrElbZdaQlKZQYfLaIJhinxmPxsyr7ChxBr4Hb9/vLS3Dm09zzRDe6UuHvDAuCpS/taBBGY3rhjjrJS+DcU32Y45hHSqXybRRfEMAshX0PEKqLjrIxNMz2gaJQalymNqvO/jyqz6peBiTLdJcrbD+1cNT/eKm/m23b70yRdYYUO2pvyIb3IDYaqLwMbEuIkg8G2vtpAQN9xKrFMf+Y3AkudVT6C2TJcVujjODHXXDBp1BUx9SPb6U2NYPbOFKsU+V+SaxbjAcBwZgd/uCqrXheVmjWzty/p8sGBuT4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB6037.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(136003)(366004)(39840400004)(376002)(346002)(451199018)(66899018)(4326008)(2906002)(8936002)(41300700001)(5660300002)(66476007)(66556008)(54906003)(8676002)(66946007)(6916009)(316002)(86362001)(26005)(186003)(52116002)(6512007)(6506007)(6666004)(6486002)(53546011)(478600001)(9686003)(38350700002)(38100700002)(66574015)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?r7EDyoOIK5ras+/RmCxZuVw12Td4iYExf3EALhdmJyMgbTSBg1NFqWcXnX?= =?iso-8859-1?Q?ZO4VNNPdFSIwXSD4IVs4mVSH4Kxg05Kt1SstWfMdIaqwO8VYf5LOyQG0vM?= =?iso-8859-1?Q?JQhZXnYF7XkeGNgoGIHrZXjDf0eMF7FwotT0xiDAZnc8WTfwGsvUrcIynS?= =?iso-8859-1?Q?dJgTVzhS2zgHjjVgR2t/Q9kQJww9Y6dvs6q5WKuNSXwKSk4774NG4E7uqj?= =?iso-8859-1?Q?yVXB1Lr5NoLEIdhBLhrfhN9pVwN9CAGI9BzH+C/dW8YXnC2ZI4PS8cIQjM?= =?iso-8859-1?Q?w876TLsmrTOaCziHke6Wj+l6pFpy6lM+WbSUhMyjHutE5TxFPbL8svfAmH?= =?iso-8859-1?Q?4OD8R9qNV2tURXB84PVchI8yxSdgR7WKKAOvgiBaAKsR2ebwLUWuDslTbP?= =?iso-8859-1?Q?3a1H858u9DJlzrFbQSnMJ8KOpl7SpmDX3eOrfAK+eMiElL6k+39REC8Z2z?= =?iso-8859-1?Q?hnroxvN5raQXQj83jj8++5ymQTXPtYwM7JIUoc8Tn8xY0gOLkpySXKT/DN?= =?iso-8859-1?Q?jzVG3hSBmttM7wx3FcCOkbnwn3XuepCf0dY/vMHzTkMZFb4SovIi16XMOs?= =?iso-8859-1?Q?OJIsspK87VbUSX9HVrTc7+mER8BPNA6g1FVw++asJDiURos3w5eperLRxV?= =?iso-8859-1?Q?XgmxmwtWc4bjfa10bA5KC8XNwyGFWpSGbzXaRVviAA0Z+1hW3t2zAhYcV/?= =?iso-8859-1?Q?vBBRfhxFkzhTfhYuD5u7ma6/XWkdBlf+7DuwUsnb8VmyBuYOBx3FmSOLIU?= =?iso-8859-1?Q?2wq9bJTigcQixveCNzjXc4ra+5eL16iZ+KzLbexsKnENLMxhK1a5H0hyQL?= =?iso-8859-1?Q?5+X4XN293VsahX5JqBnfrbT8dWq30s+ddL0BJP7Zk5b4/YuI24rzqV1woI?= =?iso-8859-1?Q?e/4E8wOY6UjspTBnwdahlnh3NnHgwr3nhaCcwLnXlVkRjK/yAv7pSFe3Nv?= =?iso-8859-1?Q?FuzPH7WSOeq4qqVc14i4e7jy/ecgc0pIsHBE8tI+ecerF1lzm7TXMveM3/?= =?iso-8859-1?Q?HFQpNyqp9ozReTOMKv23LseBowHBURimVBagTislh3Hu2tglNlE30b2AD3?= =?iso-8859-1?Q?2NX3xe76jGZF3AUS9zMz3GU9+8nlsvongpXE4l1lmeEIyoKWQz2Z44cYjc?= =?iso-8859-1?Q?PaEMInFuWOEPWwQGlBZxfEYWzknY94YIYVEgcbbWV51n65WuB1HS2wv+2G?= =?iso-8859-1?Q?mQmjQsbYOKsWY7/W3qbNt3h0Xk1FoyJXhsWom63Lk1nBTD3PslG0ant6XL?= =?iso-8859-1?Q?eR/1XRUEyHmnfphMafNHGRSuI/JJ5SvxFIroS8wJPcDv/W/b09V4cAwbhf?= =?iso-8859-1?Q?Xzjn6KoVAdyA7kv0MqRtbYplPmZYSbyVJoH7hdMDiX2n2VDPNqaFVBQPTq?= =?iso-8859-1?Q?8GOI8m6K8N7G++kgAAwkzq0omvaM5Q5BvCimyfCTwurXtObdcWTqLfGU4c?= =?iso-8859-1?Q?lPKF6rumT41pvrerpIaB1GiZUWM0QEi1eomRoyhyrgu2we5G1CSQysWWhX?= =?iso-8859-1?Q?CMgDjSitpW5pIpAlOk7ioFxcRrtQF9hOZQJ3wbZodrr785PLo5AG5z6DAx?= =?iso-8859-1?Q?14/etmUCmIwWR+19Lfoie0UrWJe6gIQZTJt7Fj5+AFv7BAmZS/eTha2wnu?= =?iso-8859-1?Q?HlIntgHvHyz4n2S33WP788+lz6bKO9p5XTFy0Sz1V4DNYqvrg7m3AoBQ?= =?iso-8859-1?Q?=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03181f5d-baf5-4311-e8ce-08db0f7cb177 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB6037.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 17:47:23.3031 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aoERrYIPPq3ukOUgVuyhYVyAdmK7Ntq+nD64fhwePWXqRL/eaJ2gaA+QUJYYa2T7B2XdcuRs+RlYqkPRlCHGQgSelm3L0Zn9NEQjsJJfMpA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR13MB6152 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Ferruh, Thanks for your continues effort in dealing with NFP patches. On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote: > On 2/8/2023 9:15 AM, Chaoyong He wrote: > > From: Peng Zhang > > > > 48-bit DMA address is supported in the firmware with NFDk, so enable > > this feature in PMD now. But the firmware with NFD3 still just > > support 40-bit DMA address. > > > > RX free list descriptor, used by both NFD3 and NFDk, is also modified > > to support 48-bit DMA address. That's OK because the top bits is always > > set to 0 when assigned with 40-bit DMA address. > > > > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > > Cc: jin.liu@corigine.com > > Cc: stable@dpdk.org > > > > Why a backport is requested? As far as I understand this is not fixing > anything but extending device capability. Is this a fix? I agree this is a bit of a grey zone. We reasoned this was a fix as we should have done this from the start in the commit that added support for NFDk. Are you OK moving forward with this as a fix or would you prefer we resubmit without the request to backport? > > > Signed-off-by: Peng Zhang > > Reviewed-by: Chaoyong He > > Reviewed-by: Niklas Söderlund > -- Kind Regards, Niklas Söderlund