From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EF5841C43 for ; Wed, 8 Feb 2023 18:14:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7285F41153; Wed, 8 Feb 2023 18:14:17 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1ED9F40141; Wed, 8 Feb 2023 18:14:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675876455; x=1707412455; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=BhT8HPX2issMKlzSBA0clGYIbCvEVJnjZCvNxosQi2Y=; b=OKZjEd+pj2jtp6WufWvov5rRkJPFrBVF9IRTw2w6mNI+ud9KX22is4/C 6LAtfknlhAG0CrrtEpm/KNAGvCtvppEMmBbu0828aXLUUl40dTmHsFxGa CXedGSu1NauqEdIcuhSFUd8lIrB/AjAkkyHbg1srUmlemBcGFnvF6R6sC 75tPsTBNHnbXDacpR8GSimn1llGeYMLF5jzqZjHfpeAol+vVM/jEL4SR/ OZejKQS+AFIG7mZuMYJfErlh6WZwlgPy9XCZKt8uAw4u2kroXi/7sJctb 943spFC7grl/fdtN85DoBvSFCB0D+ZT5iL+yzUxTrFk1zDqrWUuHgu/Fw w==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="309509268" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="309509268" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 09:11:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="699719111" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="699719111" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 08 Feb 2023 09:11:53 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 09:11:52 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 8 Feb 2023 09:11:52 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 8 Feb 2023 09:11:52 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 8 Feb 2023 09:11:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XkuKeM2H/KclNjwo5C1BwiZ6Y3lttQtCIZfVJ3Z29fZ+rhRkYW3Iw5HjT+afkcDp5WISHBtMlQ/6m93SfDOs/JYXBNdOiNkZRn6gsx1ztiqav1Ora6z8fsZ2Oj0sp2Lc5Ag4DbgFx1/0EAK7mdbmomLCgldbXPue36hK4s322kahN1KLv6g8avHiYytOgqgcmZlAkIPsQyxtof1sfAjsUP2gh0HiiBs9dgx/WhH5/g+Wq/apzIOsoYHpSdA3pjTLyh4vonRwe5leVbBAAgPvu34IXuVgm+qXyRXKKhfXMJa/2JQE7XyJ2RgaE1eoj4bCnbJhtjDhE2lJ+fFJg9ibUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ZxjGD/mnx8KZi8t+Cf8W94KJBZBf05LwM1OiB1PhTQ=; b=db0nDs24Uri+IZQ5H9wpuwFqwB8x8uOYNGqpMYOJ0wYtHRq7T6KGDvHfUaitGkeguZ46xfXrTGm+JbYSe4b+YbZNB5H4vqOoCWK9xpbGvZ0+fTiOuqPlf6e6ev4s/I/D0AUwrMud2jlE1Jn0lEzy2AZAChS5xO6SqwER+d5X7OuxY9YsSUzH8r0WaG/zqXzMDkOlv4jC18x4B8so+SqEnP3Ucm5nJCNGQBIMJSvGJ3f2ncsCm3IGitgK60cfT/ihgHU51rjUWJhkK1T7uNTrQ5HN/Zydb1Snz34Z1XJHkwx91FG2wMWJx578fE4ns0odD0L9AM8MxNFfA/kr90JerQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM6PR11MB4673.namprd11.prod.outlook.com (2603:10b6:5:2a4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Wed, 8 Feb 2023 17:11:49 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::aaba:abb7:8794:def%9]) with mapi id 15.20.6086.017; Wed, 8 Feb 2023 17:11:49 +0000 Date: Wed, 8 Feb 2023 17:11:43 +0000 From: Bruce Richardson To: CC: , Keith Wiles Subject: Re: [PATCH] build: fix invalid characters in toolchain definitions Message-ID: References: <20230207152200.122227-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230207152200.122227-1-bruce.richardson@intel.com> X-ClientProxiedBy: LO4P123CA0115.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM6PR11MB4673:EE_ X-MS-Office365-Filtering-Correlation-Id: b6a32592-e0b9-4638-9748-08db09f790e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F0AFeDohUYFGrGCPF1V5Jm07SEVtP04a17CwbS9S42kawZWJGiMx3haIqwVycLJXRzfshro+waI+TmRUGD04/kdUiDzXHz2civP85wvIECZsubLTlFMc/r7qXWlENW7ESiVM8+TvRL2d7StMK7CD/cxnaAXNAIt25L0WEHvAE2GR+nRguCCjq0BC5RD+wRd6vp9jFYxI1E5/h0eZeEnx4Z7dE0JGKU1nQFoa6+N2iLDOG+I7LO+/A5RZ2c2cjtSrFuvTqoYLfHQldKPJ9oR908IfB1Gdh0RNSy7+Z+kwV45Y6M8XYXoAXqMBG9PYTR4n/RDUe9g6PUFJIKErGDe2dWxgWfEzhDCzXfmclJ0j6LuJlBWaKK6jKEbmQEPyaVPY+Jl5EWevEoEQd4RrWUBKqjeRiBiwN2zJOQ3JP3KurvpylpBQe/RNcnAN3PfHRZB84x2N3R0xq605hh1wzYtPhp/wLycIpBCN1bNEsyCjABoeR/zGlBx96sEN6NGMZyaVi4jxGooc34spP9iGS3ynj1otNDK4Qfpy6pMh4LxkZ0FCOG46H0YrxDGHWV3xzLQxb3ZIm+ZwCZKQH+eni0pOaD9inN4igQhQt1yLKKgiu0bxSl5NqviE1ZOO+YdTyutrTfjGlZZ5os2q5d0RJHxcpw8ywCbsQmCTOB/HbJAYQs+IZSKMVgcMR9ewQNyZ+f7xGUWahOQxunum3A26rZI/Z7yrtzEdBhwMwG8G5e5xf44= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(366004)(346002)(39860400002)(136003)(396003)(451199018)(316002)(966005)(478600001)(6486002)(83380400001)(186003)(6512007)(26005)(44832011)(66556008)(6506007)(5660300002)(86362001)(450100002)(6916009)(66476007)(4326008)(66946007)(41300700001)(8676002)(38100700002)(2906002)(8936002)(6666004)(107886003)(82960400001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JPfgVuMnw4mz28Kacz23kyR/XZXcef00T0Qlfl3rlaTlnm1Q/N2zliEsfas8?= =?us-ascii?Q?YQZW245WcoowA4RYaGS0nfpXkEpO9urxUWRqZ4PPz67SJ4zGiquLGbn5Zt64?= =?us-ascii?Q?/EcK1GXVOMQxjsnhz/ASXfHsVDrumLQf0FNNyKP/LfKiiKYPnhV0SNwQj5WV?= =?us-ascii?Q?z/EqZ2TDtNdY3/oxkvOlP1VaXNxVl3ek/5PUa6/zvRacBeS+MNlIejp0OAIf?= =?us-ascii?Q?atXlyfqDI+0fN5dyHL5LWBz2Q3lgn9sqCspSLuoWaEKOruprOECS8G72cnW1?= =?us-ascii?Q?tnEgtyD9YnZYz/UzHNSRZq60Fw41BFh2In0EMTn35tfi0CNr7Ju6mOJO9qP9?= =?us-ascii?Q?Eb4QCf7OKYGuUVCcuPbYgoZvkBGFsElYW3UyhecyxqT5Kv2zUyV2Bvsi2bVk?= =?us-ascii?Q?i5ZG92W/5vi4RIRkevXzM4IWDN6GNfsFa0jeGt2Q4Pa1c8MvLQYnBQHso/87?= =?us-ascii?Q?Tj7akIthrfs2V48r0SLPOEoT1o8b9E2XFYi3ctmYVeBfBGIqP4NAX8YZ5yqi?= =?us-ascii?Q?5Q6sbNo7reZMlGN/9BhxVjOYrQMONEUS2lB9MXyyyHathGCJnR3tx+0B8gP4?= =?us-ascii?Q?/PqcUPXacz8rKleD66xQEhvUTOrwScuHah8UevqJKNDWdpslMF/h45sHZ01u?= =?us-ascii?Q?fxCVRlmLdNxNGmSZQ9pyq5qDFXUbR8VApLeh7vdEsBIuAnCBVVJ5MDH96/lF?= =?us-ascii?Q?t8vaLxOeuIkqGS9E1hQMVU+8YuaslD8rPctuVVnQ6NGW53B6gQQuUsphyC6+?= =?us-ascii?Q?ueKGqCFDU2ttT2EpidfM9cpjCdTcBHaCwpzOGafqDzl1b0fg7SbvNCxLz5PS?= =?us-ascii?Q?6DgfDEsZS4skkbXZ8CHNdHDeJ0fnpfF7wIllWhN4e+ENsZVodAkKLJpew/8X?= =?us-ascii?Q?XqXiJW1AAaSe73esuw3uZpkOguIHbhJbLDeRvyYQpQbsuIEMNg2n41SxJVeX?= =?us-ascii?Q?BGh85L396JY7fZZNzYTiFnqY7uwEsB9Z1k5KEq+Ui3x3QnuYWev1Sfne1l2P?= =?us-ascii?Q?3RALUYbUt7q6qm5EKpfD51RTiq7gp1Vje61lpn4ZoA1EiZ5s0NM3kNOK873+?= =?us-ascii?Q?ZaBtY7pYJeEN0qTogg+8JXHMMqtgbgjWn9De05HIdUoDNMCVQ8MACw1ilv01?= =?us-ascii?Q?aFZcrLjWTfgFVjNLRmWxIoHMLeYZqVKolNVh0LHJAzLBHT3CCBsHDnRezKKy?= =?us-ascii?Q?+9DdE8ioBfeM94MjUKohHTJvnIqhadF3dYE5E8EKx3IOAyYwAdA6YDolX2KO?= =?us-ascii?Q?gBbe16M88knMDEnxAQvWgwKD06rpeYGNe8YGmkNTsdjk5R/LkuRA26FP1QBX?= =?us-ascii?Q?0FOd3gkjMqRMVEYjkTk63niYo4TwU9T0CI5h8Lcxre1Fs/wz3o3w7x9TyW5q?= =?us-ascii?Q?iFlf5/L0HfYZlDF0YlZb1a+qmAvrq8RAolDYiIlTFhBb7b4SfroYvl2GOH79?= =?us-ascii?Q?WRpC7FcdCQdpVpjOcHojNf5uotpPBT/AQpFzz2RpQWN2+aKbnMwWpsqHpAbR?= =?us-ascii?Q?YjQqXe7uVkHvgxTmKQghXuknWm9c5xDOooNiUHPCLL17VVlyiGNxVWhPAccM?= =?us-ascii?Q?/UtJldJooEi+6EKDLMtf9yUjJgJmhyyEF0c3lUpzsRxFu6cwQsocSG/7ov1y?= =?us-ascii?Q?JcfKjG/FGnt9JNHbHXHb3Cc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b6a32592-e0b9-4638-9748-08db09f790e2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2023 17:11:49.6804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /wWWatW+JUl5/QnHBhanCCjM5VaDD5daIcNajooCJMBBGQOeUjsH74AR+Unvg5KyzmXo05YFyqrukVd22On/V3FBdx7JID5nOXajT1k3ego= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4673 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Feb 07, 2023 at 03:22:00PM +0000, Bruce Richardson wrote: > When using "icx" (Intel(R) oneAPI DPC++/C++ Compiler) to build DPDK, > meson reports the toolchain as "intel-llvm"[1]. This value is used > directly to define the RTE_TOOLCHAIN macros, which means that we end up > with the invalid macro name "RTE_TOOLCHAIN_INTEL-LLVM", and getting the > compiler warning: > > ./rte_build_config.h:422:28: warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions] > > This can be fixed, and the macro generation made more robust generally, > by adding "underscorify()" on the string. This replaces the "-", and > any other invalid characters, with "_" [2]. > > [1] https://mesonbuild.com/Reference-tables.html#compiler-ids > [2] https://mesonbuild.com/Reference-manual_elementary_str.html#strunderscorify > > Fixes: afd18fa21b5e ("build: set toolchain info during meson configure") > Cc: stable@dpdk.org > > Reported-by: Keith Wiles > Signed-off-by: Bruce Richardson > --- Resending Keith's ack, since patchwork doesn't seem to have picked it up from Keith's email. Acked-by: Keith Wiles