From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 81C83A00C4
for <public@inbox.dpdk.org>; Wed, 4 Jan 2023 17:22:48 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 75CFC42B8E;
Wed, 4 Jan 2023 17:22:48 +0100 (CET)
Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com
[148.163.155.12])
by mails.dpdk.org (Postfix) with ESMTP id 8F1D340041;
Wed, 4 Jan 2023 17:22:46 +0100 (CET)
Received: from pps.filterd (m0127842.ppops.net [127.0.0.1])
by mx0b-002c1b01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
304DOM4r024973; Wed, 4 Jan 2023 08:22:45 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com;
h=date : from : to :
cc : subject : message-id : references : content-type : in-reply-to :
mime-version; s=proofpoint20171006;
bh=HCWz9VWfMG4t1NplB/O0NWaxWEhOWkdb6J7YcWQzy7E=;
b=0r1BeAKkceFn5ei+znBW5fs8IuUXP5a8uVbe5wJnEiYfvchPuyKzm6BsVrHjXuO9AA66
WDv1PHCimOEqZoUZyVSM/QZrusQ3yUMGo+/uTDTlvMcn8tfXeJoR7Dx3kpCKcX2lL1Y7
lo9rIIEZuQhJXa+AFRCSfQGI3U66PHSFlW/XXJqPvKWktSTg/ybdAwXBthp2FWswDi3J
8V2HCgmwXvWgrAiwZAc2NH3Ii+RHDStyT/trfgfe61yYazRZBQb5Ifl+Jk66disnEIBf
EClQUnPfEmY66EKzzikovD5nIVFT9p9Rwy3oDSEKY8r2jzd0oTeqKx6+vMZbfq1vsc2a 8w==
Received: from nam11-co1-obe.outbound.protection.outlook.com
(mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173])
by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 3mtn9mp7qp-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Wed, 04 Jan 2023 08:22:45 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=b7pxFt4d4TRJdX+KRhHA+riEBs4/3RmOSz6zScYrQhC/Kmg8KpimajL5TLf97eK/sBfO8/x/HOs6kjgvhQ14i2y6Zb7dAAXR4tAhdKs3szNOPbr+G0TXcNrU/aQHi6ACbf/q3wL7QrjkjpK8jLpGdEEII7vn8HOMAZPcUJ7RM8EEJ32euIZl5vnNTuZYnM/GWA9hAY3Qq4KBdl0celk8gC0fNL+gllwLgshfsDtDLvc2p5ltCuxGOQ1ftBZdWILRFzjU589thHpHWyPsU8L2LTui+7UIS8UTQODuzv1Xs3dUNuLxunxTBA4BDOHeQihnItnUD4EHHHJ5RfXhhvmgPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=HCWz9VWfMG4t1NplB/O0NWaxWEhOWkdb6J7YcWQzy7E=;
b=jExEgNARMZVIrbb2MgAAxr9ThTi5dOoNs/6/NmZucjoQwaQGE+0L3ModAbaop7gamx5PUeVw40AhwTxgMhaQJwcKgzQYxp+f6K7sxli92xKpaOfcR1cCdhQsP15dw6SiwXT6ZVejsMMAxEEjO5p/2U6PTl5lRWJ4KFiuUkxrmgv8b4PurTzvLEBzMFE5L7HK555CTBBYwgRmdPFXhSP8xTJXKi9h8ZISFqt2NEj097rT7TQbVqwkzDYITkpML4XQQXa3nTdcXzaELayPspT3KcTjqjloLUlT1eQQ+MALvOIxv0YkklWnYDiCKXEseQQDwdMP2nBX1znz/V3WZ/pL8w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com;
dkim=pass header.d=nutanix.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=HCWz9VWfMG4t1NplB/O0NWaxWEhOWkdb6J7YcWQzy7E=;
b=r95fQQ40amcTgsXJMGss1143Y5JQAPUvpNzVfM+a3GhTaws0KYPPxlmfpEvuEpcSLjfLKPCSkjwTs6/wXrFwtebir8v4CMO4+be2paxUMEB9X/v6OlTyzj/rfHVXWSxGfeZr5zLR7EPAUilJGFOyg1DByRBQImHWPyV1slkryENV/oElPkBFR+bIa0Q5iCLjYBgpQaO+srBUBe8If9cdatoUmWGy/VrOdU7U+keK+cIj4NH32er+FQDZ8yK1VBvhya/JoDbfeKW0L16WQRKVJ4ML38h8FJWgAxa9fqkLe7rL395mTHQ29kITtRfkUzvIJPTQVgzsIKEJwrrO/g295A==
Received: from BY5PR02MB6115.namprd02.prod.outlook.com (2603:10b6:a03:1b2::26)
by CY8PR02MB9129.namprd02.prod.outlook.com (2603:10b6:930:94::10)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Wed, 4 Jan
2023 16:22:41 +0000
Received: from BY5PR02MB6115.namprd02.prod.outlook.com
([fe80::f49e:9fd9:136e:9b42]) by BY5PR02MB6115.namprd02.prod.outlook.com
([fe80::f49e:9fd9:136e:9b42%3]) with mapi id 15.20.5944.019; Wed, 4 Jan 2023
16:22:41 +0000
Date: Wed, 4 Jan 2023 16:22:36 +0000
From: John Levon <john.levon@nutanix.com>
To: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt
Message-ID: <Y7WnzOfnTuP2ysTD@movementarian.org>
References: <20230103185732.2007210-1-ashish.sadanandan@gmail.com>
<20230104000030.187857-1-ashish.sadanandan@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230104000030.187857-1-ashish.sadanandan@gmail.com>
X-Url: http://www.movementarian.org/
X-ClientProxiedBy: LO4P123CA0224.GBRP123.PROD.OUTLOOK.COM
(2603:10a6:600:1a6::13) To BY5PR02MB6115.namprd02.prod.outlook.com
(2603:10b6:a03:1b2::26)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BY5PR02MB6115:EE_|CY8PR02MB9129:EE_
X-MS-Office365-Filtering-Correlation-Id: 16b76edc-c808-4bc5-60cc-08daee6fe6df
x-proofpoint-crosstenant: true
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kevIHTtjPwVcnF9HahihNfxjBg5bizslK/Mj1ciYF6QKbYE71Zq/iCwHdzCBxyF/0AvRaM1aLx/txXjaF9ESjvW2DBia/2kUbaE4zLMzp46KYCbMlLqQLFAXAQ2qT5wYS+eslUR1QdBwf5Q0fRZ6QZMRWiuU3NjnG6QeJoPvDSnca7Pz0IsDmpYenNI8ri/Ni/JhvvRwI/yhZj5oGjGO8tmfq93WMwJvIm3lst+HreN3JSqKJUY2mTfH7NGSDy7jLRCVE4flqZ0VvU4PKHEVKSWNOXqGHaAloTFVPEHc0JdKJG3h/zGMInz+mKGtXQYckcoBkbf2SitDn26oUva3m8F9gypqoecaYs/L+PckD0TDfP8VnScRxQ53zKEd3M4oxjgPrQpBk5HTVi5rnlJhYHEW9ydWmo3qzYxkKtdw79+ivAEYo2gYgcC2HMikYBm9sz0h5wHl0IwqpL5anIhRBbLoGUgi378gKrk5nXOYmgLJmB0gzr6oQH8s9BKQnOEREpSF+vdqRhKURPZqK70T5sOPVAy1JDTcMAWuSHk9ZEFbhrKk4443uyyzYJZ6U/kbvNUer4D6ZHLrNy8YLqmrY5ekvZ2M5eHH64eSE4IfgVDch3GiF7qltQNjTDEgXrWEQw3ih092tdMbbumjAL1YwygEgmPD2Sb5KaC+tDsTbRJW+77dIYvexjJIzv8Bs1Ih
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BY5PR02MB6115.namprd02.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230022)(346002)(136003)(376002)(39860400002)(396003)(366004)(451199015)(6512007)(186003)(9686003)(26005)(86362001)(36756003)(38100700002)(2906002)(6916009)(316002)(44832011)(5660300002)(66556008)(66946007)(8936002)(4744005)(4326008)(66476007)(8676002)(6666004)(41300700001)(6506007)(478600001)(6486002)(14583001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?22GLpXQq/gu5TIUIi2fdQGAYWso2YpUNGAJxYqvJyH2KppaXhJ1y9aRIUWtD?=
=?us-ascii?Q?p0Zwa2KJ0bagh3huTTKiHNAjTLDbqoO2bHikee4u/GOskZVBzfuVmzpWDhJ5?=
=?us-ascii?Q?bqopDHLsaHCwXAAbbveOEL+FHM07leMVARGWfCD5+oukL+PDvBVhVQEGQSuj?=
=?us-ascii?Q?Rok8ycqhlo9oPc779bglUBuh/xISkeaELBMWiKmqbMBKWEWBGKe8FYj5NeUN?=
=?us-ascii?Q?rd+DOuzU+tlNMUb8oR7k0jpcGU7wj/Y5tixSaw+yXYkS3Kw+kDibZS1aRiA9?=
=?us-ascii?Q?P71SBBTFuFVqC51aiyAsXFnmHIgPaUDuLMupts8yZy+Ywcvj1jptFLcVyUej?=
=?us-ascii?Q?u+Y5aEdTSSW8CczA6cM2dxYhRKs7j3L5XUEtgfgUbZ28ukHKuyIjm8Np6dhL?=
=?us-ascii?Q?Omh0XLmC1KkugAPCe4tVQQl2CC/yekK2CBNKpKt1UgvtGX3lQTQ65qxepWbc?=
=?us-ascii?Q?dHWZrOLYIUUbZwnPTXGUakZA0WA6ewL0d7prAySSCbuk5YVd/2ew+ZD/Jy49?=
=?us-ascii?Q?Eenngsgs3wdZKl8B7qSeQRuwhIvrjBKHn0qMn3tu8Zinr1ZxjOYwn7MZKFCI?=
=?us-ascii?Q?v4X6Ldgmvdf7g8toLTVAjwftZlND52WiQ9hSHFFC7YGbNN+EzY3Bt0vuz2pB?=
=?us-ascii?Q?vDRg4cBGI1qH0PwHaf1vtCwBM1hj01P0DI4WfXWb9z8Mt5zZ35E5i6aavotp?=
=?us-ascii?Q?f7voBOj/I+DumFXGVqbkSsfYaKSKsxNPAqPuckYxgga45DbUWrKZ68etJ5x9?=
=?us-ascii?Q?ymVvpqAlygp5TtizWUNbM4aSAmhx7z7lfGXFsD0MSLEltvHLy6SktFLofT6A?=
=?us-ascii?Q?tg5gx/IfRInVzgL4rqN2Malo3nWWUuuVMWZCGjLsdIUf4NzejQQN6RfZ9/Vn?=
=?us-ascii?Q?6w1UNEwsTTo+w+mwByeb5QVb+XLSMMimiUXbv/8eIUgmb/sfANyb/7/pUPq3?=
=?us-ascii?Q?UaNNVxHDj+xsZzsVzXJeNrnrMVPkPjm8kuB5WvN7uDXTHR3oLpbnM3GRml50?=
=?us-ascii?Q?cZhY7xaQrZe+U4nW+NTJR0NZ7cH6siYAWXqqGiEm40QrRiq0kZGgIKZiJq9E?=
=?us-ascii?Q?ZUXUd336m5E0JQ79S8KZKbFcFwInnVqNeklZ5J1ZoT0uy//0Ua2GndnrrhbG?=
=?us-ascii?Q?wGaIJe4UNaaKx6tKfR0QrXgj/k18ntcZBdDQSuQfKeA6Nr8r58d/cq6F4odC?=
=?us-ascii?Q?vkRyfeI3CxVfcS3tHg8c3jCUrRd1XCIfMYwSIHpgWciY5A/OZywtO7N2+9le?=
=?us-ascii?Q?eknsKvQ4InK688psen9MswUFiNuKHZ+5PYhBbaZxoSfOF1Zk6N5UnPjJa9h5?=
=?us-ascii?Q?j/xU0KkjPHnZeGy7ODBqbpZBNQbu2v6+x5LSQ6ux3c45qxDnDAb611c/Xk3J?=
=?us-ascii?Q?AdIkQ6M+tCSTMcjXECD0HXL7XHIyyu1RX57sBr/gd6yMj/8huZ1IihwWCnoK?=
=?us-ascii?Q?+1vnifNZeUv5ZHMwTYEa+xKYLumbRgR/B+IahTwcs8i0zLKV91ZjCi64C+6q?=
=?us-ascii?Q?YDjlfs9N7BH2UPuSkMOniYxkNSkCNiT1xq3nW0QrJ9grm17j3go0cTCk+SG5?=
=?us-ascii?Q?iMIBM36FXb3BgsMETdiXeioEjAQfHRaTxl/jJb7Z?=
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16b76edc-c808-4bc5-60cc-08daee6fe6df
X-MS-Exchange-CrossTenant-AuthSource: BY5PR02MB6115.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2023 16:22:41.0244 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hjWTqHSa7auKUtk09LCsASPNwTJ+vgc5nwNy4YU+qfKkmVYP2QEdgrAmyCQCMsJI0HIjKDHBA43eY+ompKc2FA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR02MB9129
X-Proofpoint-GUID: GFSITRJQBduI_IwiBLAc4ChjUmUedIPJ
X-Proofpoint-ORIG-GUID: GFSITRJQBduI_IwiBLAc4ChjUmUedIPJ
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
definitions=2023-01-04_07,2023-01-04_02,2022-06-22_01
X-Proofpoint-Spam-Reason: safe
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
On Tue, Jan 03, 2023 at 05:00:30PM -0700, Ashish Sadanandan wrote:
> The code added for allowing --huge-dir to specify hugetlbfs
> sub-directories has a bug where it incorrectly matches mounts that
> contain a prefix of the specified --huge-dir.
Sorry for the trouble & thanks for the fix.
> + /*
> + * Ignore any mount where hugepage_dir is not a parent path of
> + * the mount
> + */
> + else if(hugepage_dir_len > mountpt_len &&
> + internal_conf->hugepage_dir[mountpt_len] != '/') {
> continue;
> }
Shouldn't this comment say "Ignore any mount that is not a parent path of
hugepage_dir" ?
regards
john