From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C52954237E for ; Mon, 9 Jan 2023 11:24:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C201142D13; Mon, 9 Jan 2023 11:24:15 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4928A4067C; Mon, 9 Jan 2023 11:24:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673259853; x=1704795853; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=02u/JYo1NNoDJh6vvZ538NP4bCFLVrkRBSIDKMnYuJI=; b=V0xrSj3vyshkJfu9VQKzveu+dV1yQZj1mXm867RVCIgqJ0KDcrdthQnB 2lmsbZVPm92X/1dJ88k8BQjpx7LPhd9pB806vZfSBYEwXwITk73zaE+l3 lf4VsXeO4/wUHjBQc5TO/KZV0FF0oEKl/R/r72CQuFOMBww1bA4puJbZQ 3l4vU4+mhPP5qw8TACeG93mND9p8hTPwIxZRiNtPc5fAhiHB1ImkQLJl7 I5dCMbz4OwSN2J1i7PhQZY1v7AoTv+KOVJ21hyamr7H+8de/TFTGPeQ0W PbGM1c8GPNp+Tf0M67QKaWuaTVXl3kDZ0pjGNlvu80RBjhYXnhYGvZRYb w==; X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="310634499" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="310634499" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 02:24:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10584"; a="656635350" X-IronPort-AV: E=Sophos;i="5.96,311,1665471600"; d="scan'208";a="656635350" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 09 Jan 2023 02:24:09 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 9 Jan 2023 02:24:09 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 9 Jan 2023 02:24:09 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 9 Jan 2023 02:24:09 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 9 Jan 2023 02:24:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJArayk6dxZr1vVD/IhitsgOfLMorbUEznyukYYByXvOC76XRsaE9MYhV/NU9lwGNeqY/giDeCgyFRb4IhcAkUhZAWKPxLLPDuTh9qgN+5tMcvwN5fdofwywilTnTiTHUx2woanSJsVTjXqE3rIbbc+QxWr9ex1Q36Zo2W49oOgR/OBPsvh/IlTKwHl2xfXqvNS7j82X3nyfYyqY+vYcemDxYNer/mGGyAClwySlT2bmFWAd7LrBWpcSPqxwk7CHEHT+qVcCcubnHLN0GoKxJwF3qSo8bFM4Wa97g7hpQn4lN14KgUvC8jHGZhKWTaQsJg6gwardF3Dio2MT+WuA2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=afsOSKt0zKcMaIz4XpkvQoKDaUBp0Shluk8lLbRiOFc=; b=DIudLR1IQFysx4wKw75SkTfoUk8In/fRzFudtbZMBh+8KjAK6uu2hoYJTX9BAc6OfRl2Ukn0EHUEYhYSDbGVjlx16o33uvAShnxoim38NPgXzh/AL1SFYcocoDNu/IxBtG0Naq8LDSwTEzmmGrkMfwYg+02btrbpWSOpe7XiekQsusBfQ80pW4kjNO3ufJBqwp8UZA28vbHA02Kp1wAbOgyRHo6jRnQ3KK9rIq164h3WDp3kVsunY1nJVOJm3EGwIjb8Bvmlr/+B60TzleqTLvUkKqzPM94tnOkAePM5Dar9dpPVhijfT9XfAUbvUz6vB/tus9wxwqxx3Ha5xBrBSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7509.namprd11.prod.outlook.com (2603:10b6:806:346::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 10:24:06 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4d9f:6867:2d53:9ee%8]) with mapi id 15.20.5986.018; Mon, 9 Jan 2023 10:24:06 +0000 Date: Mon, 9 Jan 2023 10:24:00 +0000 From: Bruce Richardson To: David Marchand CC: , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Subject: Re: [PATCH] hash: fix GFNI implementation build with GCC 12 Message-ID: References: <20230109100337.714937-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230109100337.714937-1-david.marchand@redhat.com> X-ClientProxiedBy: LO2P265CA0046.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::34) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7509:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b91b3bf-d348-47cd-05d3-08daf22ba307 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hHHLXCdV9T4BvSNGJ+bl4GH9qs4/h/pH5aXVK02KWdFJx5ZBd3MevwvFif+9ia1VU8J4jcJH3mu9QN/0PZ8pylYl7I290iGv/saA5kF2lGrJcnbDQ1lwwSo+YUFW2hiqx6VJpyxeGWnZUvICzMcWOe+4iCcX1Ntb9W3w2rUnLl6f+NHStr2FQyt8q/DeTdxDebGcvVQBvn7K24Uxh75wsY3gm/uYPOHdzrmKthI6KbOHkvqt0NfXAg7at2bi7v5lo3d6n9Y/ZnCkn+JrEDIxVgsqizukjkZnijqAJI6x8/5sDsX5zKzYMpNHC8xhE2eq8ts45V+uELi6J7BtEwm4II1oNa+UAs2nHy878HDYRiD8T9qc4WVqqpdaGxwJvgm5Gu6QGoy1txGt446nVa8G0UD9t+elqawZxPTFv3eXWHpexfikf8RQfja3pHzQ5DvUTcpVOGNix6Z+UMVnRbvHEPUUW57HV0SZzvAEMdH/RdShKRlBX7N8HzYs/xCqE9XK+ILIq5PxEpK7wJagc/K7kWgYrovkWI6FaQgwpI9gCmPLp9QNFd8wlq5C/eLdHCyx+fo4mWKZGf+IwV0V8FbJSGk40XigNu5zbKX6H2NDRE0t+ZXQXbOzRBeCYLg5EmBGx8/FV5JFHxZVIA+EB5mngbaTH3Oy/stzeqMUnu8n91k9pgE47LXvDyLhJxcKa6VK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(136003)(39860400002)(366004)(376002)(396003)(451199015)(2906002)(41300700001)(5660300002)(8936002)(82960400001)(38100700002)(86362001)(6506007)(66946007)(6666004)(54906003)(4326008)(6916009)(8676002)(66476007)(66556008)(316002)(83380400001)(478600001)(6486002)(44832011)(186003)(26005)(6512007)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0QzUGttWnlEOEZNYmpReEZPTjhvSGZKanB1U0FSTlRqRCtMNU0vYTh2Qy8w?= =?utf-8?B?T2loQVhzRWdsK0hXRzlkREtFZWxsSnM3N0Z0K255Qm44ajBHSVAwVlZzUkxp?= =?utf-8?B?aWpmR3JhYXRsckNveE9PUnVXZHR4NnZ0NU9HRXhHMG9IVmtJNUNTWWtGb3FG?= =?utf-8?B?UUVEOGZsdHo4USttQlV3OHBsMXhRU1FqcWpCUi8zU0ZXS3VWMDJ2eDhEZWQr?= =?utf-8?B?blhObTBrREpndENFT2pjNkQyVjB6d1doVTRLQzNqUVBlMXZFTGdPM282RFVB?= =?utf-8?B?cm9HbjRTaVVnT1VPZHVrcHgvczRUanQ0MkxUSWxzakxsSURUSjJpU0xwbHF2?= =?utf-8?B?eXNEcmFTWGNXOTZZRllZampnVnVHZENNS1hWWGVra3JkR3d6aUpjWVE4K002?= =?utf-8?B?TC9sVkNKdStDaEk2anE2ZjlCcGhxQWg0WUFoWndDc0psYUEwcmxyNHdab0N1?= =?utf-8?B?MTZ1UUFiMjBsdVpBTUhMbWUxL3NPb2UrZG80cjlBVWo1am1jNEY3d0VIN0RX?= =?utf-8?B?czNFMWtzQXdYY1llUUhxa21UaG9OVUNITXE1Z1ZVTzVkemdKeTNWai9pR3hE?= =?utf-8?B?a3FhdnlkbzBHZDJncnFQNHdGMk5YL0ttKzBCY1pYZHVkaEllN0tib2NrMXdp?= =?utf-8?B?WU9Uc1RBNnhDeEFuaHVoSW45R0hCQVNRMEZmZXNabWdnS0FoTXkzb0loWmhX?= =?utf-8?B?SVF2aC9OZnZmbkhhblZKcWozMGtpdlhYNXgvR1NZN0JxZ3R0cUY0K1BQWHVa?= =?utf-8?B?TmI1M21OWWJUUm9UMTdBL3RWRnFKZzNrNzltMHlPcU5GQ3M3R2xRdng5UG5s?= =?utf-8?B?ZjB1dThRNGxGb1hpVVpyRWhlOW13dm1mODRTdC9XNm5DZEY3SnJQNXdoSHp1?= =?utf-8?B?MnNZd2V1VnRYL2hsRFVrd0RCSFprMWdldy8wand5Y004SHIxMWZKVXhaZ1Iz?= =?utf-8?B?b2haaitpS3dQOCtLQWRZVlhUZTNmSnVtSXZ3U1QvSHkxR0YzcGg1SEpBTXJV?= =?utf-8?B?cW1MdDFTd2p5K0d0aFE1Q25ZN2NwUmYvTXdTODkxL010M2ZzakpEM3ljK0Vw?= =?utf-8?B?S1FhZlVwZFhzOEtnY05ydVVFUFR0djhEOU96cS9Fd3VkVjdNU0FaUmxyTll6?= =?utf-8?B?YWhXYW9QTXJhbUtUTUREV3ByTDVtcnU5aTBKRC9rTXRZT2doL1k4Q2ZWaUky?= =?utf-8?B?TFpvQ1ZmR2JjVE1WWitmYWtmSitiRXo4Y1l1dkdOczNpRUU2c3JJZEE4cW9k?= =?utf-8?B?RFh4RkUxdGlUdVNoVmc4TVRLZFhIbVNxZThUUlFQSWNxZStKWktnKzh1c2RO?= =?utf-8?B?OVRRa2JNUU5DUUxUb2R0SHNQUlFNUmsrZ0w2Y3BDWHZBVDRwRDZ1SWNvVG1h?= =?utf-8?B?Zi9tMDZ2eW1OTzgrNVh3d0M0ZDRQcStKMlp1aTMrcWVGcER3UVR5TFZuK211?= =?utf-8?B?K1RsODcyOGczMjYwVHYwL1A3U042SGpNQzd5QlkzUFlsdjJqS2cveVNxSWY0?= =?utf-8?B?bU8rR0tOQ3hXcFZYV0ZhZWlxY3Fya0pHaldJSzlpRE9UYVBGWTA3UUZzc3VX?= =?utf-8?B?WWhLd05ndGViQlBUOWRlZzRTeDF5WDZIUkNDUzlDVDN3NnBjMFhsbHU5MVcr?= =?utf-8?B?bVBpZ3YrdnRwSG1wYlQ5MTBWaGhyN1JTajlKVHJDWEhieHc1NVQ0cU5hb1pD?= =?utf-8?B?MjVyQSsxT0loWE1scGNiemQrWXFEQWQ4S3VkTzU4WEFsRUtldmtqZ2d1VmlY?= =?utf-8?B?TlhsMGkwSUZkY1FBNGxZUjI3c25EemozS1RWcmUzUkViRG94T2ZzcmwyRWJP?= =?utf-8?B?MDFkYWFDaDFZdnNHeFphS1VMY21NMEpDTnhpRmdVVWl1Ylh5ZnpsTHUwb1Q4?= =?utf-8?B?eHFlNDZXTzk4WEd0YzlvOWFya2tYSTU5eHRpa3I3U2VGYWxJTDFRRDJNYlJP?= =?utf-8?B?NTRZUzVDVXNlaGlnT1pIWFVWWk44OEV6MkVXM3VmaU55NS8vTW5lME1jbW5a?= =?utf-8?B?dmdodVord01nMi9hZDBUNGhRYlFDbEhQU3VUM0Y4NWRLZzh1Zk1nVm1oUm1T?= =?utf-8?B?YnM5cFI1VUJWWmV0Zy81TTlBRjF0bHQ0MEIvVjRJQk4wdnd3ZW4rR3MwNXZ5?= =?utf-8?B?TU1JNmw0YWx2SFFNNytyWWFLVUpWRTIzM3NVamVBSTBCeVhJcWtDc3k5MUZy?= =?utf-8?B?NUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7b91b3bf-d348-47cd-05d3-08daf22ba307 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 10:24:06.1352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AYckBSOgHZpYxNy4/0Egn6E5iFaaJgWo05HlGaCJ4HYe1Oviv/0Uce0Nz1N299dofbE/HDEfPpVZNqNf7iKVzM8sNtr34LYTK5MQw8YpYJo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7509 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Jan 09, 2023 at 11:03:37AM +0100, David Marchand wrote: > On a system that has AVX512F and GFNI, compiling fails with: > > In file included from /usr/lib/gcc/x86_64-redhat-linux/12/include/immintrin.h:71, > from /usr/lib/gcc/x86_64-redhat-linux/12/include/x86intrin.h:32, > from ../../../git/pub/dpdk.org/main/lib/eal/x86/include/rte_vect.h:31, > from ../../../git/pub/dpdk.org/main/lib/eal/x86/include/rte_memcpy.h:17, > from ../../../git/pub/dpdk.org/main/lib/mempool/rte_mempool.h:48, > from ../../../git/pub/dpdk.org/main/lib/mbuf/rte_mbuf.h:38, > from ../../../git/pub/dpdk.org/main/lib/net/rte_ip.h:33, > from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.h:25, > from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:7: > In function ‘_mm512_mask_permutexvar_epi8’, > inlined from ‘__rte_thash_gfni’ at > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:142:17, > inlined from ‘rte_thash_gfni’ at > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:182:20, > inlined from ‘rte_thash_adjust_tuple’ at > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:784:11: > /usr/lib/gcc/x86_64-redhat-linux/12/include/avx512vbmiintrin.h:97:20: > error: ‘tuple_bytes’ may be used uninitialized [-Werror=maybe-uninitialized] > 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __B, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 98 | (__v64qi) __A, > | ~~~~~~~~~~~~~~ > 99 | (__v64qi) __W, > | ~~~~~~~~~~~~~~ > 100 | (__mmask64) __M); > | ~~~~~~~~~~~~~~~~ > > And: > > In file included from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_gfni.h:17, > from ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.h:27: > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h: > In function ‘rte_thash_adjust_tuple’: > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:91:33: > note: ‘tuple_bytes’ was declared here > 91 | __m512i vals, matrixes, tuple_bytes, tuple_bytes_2; > | ^~~~~~~~~~~ > In function ‘_mm512_mask_permutexvar_epi8’, > inlined from ‘__rte_thash_gfni’ at > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:142:17, > inlined from ‘rte_thash_gfni’ at > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:182:20, > inlined from ‘rte_thash_adjust_tuple’ at > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash.c:784:11: > /usr/lib/gcc/x86_64-redhat-linux/12/include/avx512vbmiintrin.h:97:20: > error: ‘permute_mask’ may be used uninitialized [-Werror=maybe-uninitialized] > 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __B, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 98 | (__v64qi) __A, > | ~~~~~~~~~~~~~~ > 99 | (__v64qi) __W, > | ~~~~~~~~~~~~~~ > 100 | (__mmask64) __M); > | ~~~~~~~~~~~~~~~~ > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h: > In function ‘rte_thash_adjust_tuple’: > ../../../git/pub/dpdk.org/main/lib/hash/rte_thash_x86_gfni.h:92:30: > note: ‘permute_mask’ was declared here > 92 | __mmask64 load_mask, permute_mask, permute_mask_2; > | ^~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Set those variables to 0. > > Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > lib/hash/rte_thash_x86_gfni.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Hit this issue myself before, but somehow never got to pushing out a patch for it. Thanks for doing so. Acked-by: Bruce Richardson