From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A0298A0C4D
for <public@inbox.dpdk.org>; Tue, 27 Jul 2021 14:53:02 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 86B5A410F9;
Tue, 27 Jul 2021 14:53:02 +0200 (CEST)
Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com
[209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id B7E15410F0
for <stable@dpdk.org>; Tue, 27 Jul 2021 14:53:00 +0200 (CEST)
Received: by mail-wr1-f51.google.com with SMTP id e2so15095452wrq.6
for <stable@dpdk.org>; Tue, 27 Jul 2021 05:53:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to;
bh=L+a71Z4chNjt7t4vgXi7a2Mn/vR218QqVnhhNRBSUfw=;
b=H5E0bPyddzd1s3iu6yboKzVDbKvKtSYFyVtdVmR1JcmKV/5m+NSGMKgmv0LLv110cj
qeBCuSWA7yBU/h2I5iwB8TKwcCYFvf+FEdWe6YesTMQHYOQkRdw+mErrdODAEblEy32E
PdGuLapSjm3w85oPfj+QdW2pRKMyl8bTceSp2s7WJmmJQ3qC/Ig5jYOhfzT2D57/d5Ya
Feff3psKHyY9EY2rKBlYY2K0ePFnhRqu5BQCQa6DK8TGh13VZdkdQ7nf9J559ivaAC7/
X5ZsC5v+u4qqd30FhHhzgDDpAOq5Op1BB5ZRz0s4AbKVSmPtwf7ZrHIVQZIayyB1l6e8
KBpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to;
bh=L+a71Z4chNjt7t4vgXi7a2Mn/vR218QqVnhhNRBSUfw=;
b=casAreu83kGP9LPPCg5Ec4hYd0qRG/N0A6t2ET9/WUXNtG7nsoiycseWEcn2TZl3zw
xcI2sJSgydL9DLnLX0AfU5AdHV3KC1p/rINBmfPC5h3VZ/gQN2XmLiTTCh+G1bYGOf76
lDclO6tgWDMLCt5FKdJly03Xih/ARuPenQC5ESmoSd01Nin0RPXvWP13CTQap4usAPnY
GMBHlETQU+Lgzh8M7TqE6x0B0uINRxSaS3KUIFsn4MMtTXyG3ksO6NEOtja6i6kBSwrm
MJ3zjepSVAK6YMG0M8ohoZea+iq8DigR5FzPgHe4fqTawOhad2zckQTDvjEqvzJVEIzj
abQw==
X-Gm-Message-State: AOAM5320X2faGFadL8hLrz12W8HvpUbDSIln1wdZtMxjmllh2iwJK00d
sviJqIvR/eUmvVpe3cXyrQ2FVQ==
X-Google-Smtp-Source: ABdhPJxXTejQJNYzKB9jDJziJdzRYzUo0g7I08ywgqadJvcP9JuzD+u9kgbGpSIa8rJJfKqt0LjV4Q==
X-Received: by 2002:adf:e0c8:: with SMTP id m8mr24565148wri.261.1627390380378;
Tue, 27 Jul 2021 05:53:00 -0700 (PDT)
Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25])
by smtp.gmail.com with ESMTPSA id m9sm1968135wrz.75.2021.07.27.05.52.59
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 27 Jul 2021 05:52:59 -0700 (PDT)
Date: Tue, 27 Jul 2021 14:52:58 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Mohsin Kazmi <mohsin.kazmi14@gmail.com>, dev@dpdk.org, stable@dpdk.org,
david.marchand@redhat.com, maxime.coquelin@redhat.com,
andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com
Message-ID: <YQABqs5okRV4V5tZ@platinum>
References: <20210630110404.21209-1-mohsin.kazmi14@gmail.com>
<20210707094019.40945-1-mohsin.kazmi14@gmail.com>
<7265315.64hUE0sMR9@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7265315.64hUE0sMR9@thomas>
Subject: Re: [dpdk-stable] [PATCH v3] net: fix Intel-specific Prepare the
outer ipv4 hdr for checksum
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On Thu, Jul 22, 2021 at 09:56:25PM +0200, Thomas Monjalon wrote:
> +Cc more people for reviews.
>
> 07/07/2021 11:40, Mohsin Kazmi:
> > Preparation the headers for the hardware offload
"of" is missing after Preparation?
> > misses the outer ipv4 checksum offload.
> > It results in bad checksum computed by hardware NIC.
> >
> > This patch fixes the issue by setting the outer ipv4
> > checksum field to 0.
>
> nit: please write "IPv4" here and below.
>
> > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>