From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8CB0A0548 for ; Tue, 17 Aug 2021 12:59:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B23BC411A3; Tue, 17 Aug 2021 12:59:03 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id B4FBD40DF5; Tue, 17 Aug 2021 12:59:01 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id e15so24428989plh.8; Tue, 17 Aug 2021 03:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=py+EHXy2nrFQ7xo+fECelCAKO9TOpzP0V0K8gAOkfME=; b=Ozke5WUqJjySuNWb3B2bTig1K98AmgreECp6mO540G5ElxOGgbfD9PJzKnj1m4MJKK mtCEeG8Xw+wgX76NSDJ0oK8z8QaQO81fCH9fm+5exd5cNF2HXlsazb7hgWnIbjWYHVZ5 7JWZptHlJwQbJo1Hj88MRLQM0QVI4MB8MFJ0fT3lGBieDdTSwzRCaupOmo2Xa75Y57/O /BLnWDyO7Of86yg3DEQ7DpBCdTFkx2sG0tfk3btjVZnkzUlDOw7rDY4/ryjxErQYRFur SLqVrMAv7YgEPGAoEiqYGKNbiJBv1EoQtiqY3uG5lLvndWtY1zon0wKIXWDxBWpL02PZ B+lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=py+EHXy2nrFQ7xo+fECelCAKO9TOpzP0V0K8gAOkfME=; b=rCbwRuSphEwqquZWOshToe99llR53cQ6ShGZLPIdBq8VsLlCnBxQxZftgOyvuAB8yT a4Z54dkDkNF1ONXBh9GtXb0+Gho6qpR3lj42aP1XmzEU99e74mV8jL1RgP3qFbH9iRcD eXqQzIqiJjptmgrIuBHxWH/aVkWsKPxvUKZsN6x0QqX513lMmAfnNYwYOfRp/Wy/uTQQ T90+rDPxzFqO3LmpclrR9oP+nDatBwe+w85+9MhdAFxmyQg+Cm/tNuiA12KcBdQaB4oh MvdZNicZukMnaDUCI8WR8ZnaQ5fUnPlqG/+4a/w7htbDAwMqvYesFaVZmYT7EeCpIHqP Uj1A== X-Gm-Message-State: AOAM531Y1qF22Wkr1HyeMuS9KMPTFxofWnPO8kMY1zEF1jiGvvQ1qjRc o4+SFAt7n6gceNUBhYFZCFU= X-Google-Smtp-Source: ABdhPJwlQVvVL12zjLK5+XrOOo4sVUlnD9NXk0FNip+aTJ4eX3+AQkV2HfA45lypWWEkoHlAwbdQyQ== X-Received: by 2002:a65:5686:: with SMTP id v6mr3038967pgs.174.1629197940692; Tue, 17 Aug 2021 03:59:00 -0700 (PDT) Received: from gmail.com ([1.6.215.26]) by smtp.gmail.com with ESMTPSA id c2sm2304469pfp.138.2021.08.17.03.58.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Aug 2021 03:59:00 -0700 (PDT) Date: Tue, 17 Aug 2021 16:28:36 +0530 From: Nithin Dabilpuram To: "Li, Xiaoyun" Cc: "jerinj@marvell.com" , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: References: <20210816070943.26807-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Aug 17, 2021 at 01:43:27AM +0000, Li, Xiaoyun wrote: > > > > -----Original Message----- > > From: Nithin Dabilpuram > > Sent: Monday, August 16, 2021 18:56 > > To: Li, Xiaoyun > > Cc: jerinj@marvell.com; dev@dpdk.org; jia.guo@intel.com; stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run > > without outer chksum > > > > On Mon, Aug 16, 2021 at 08:48:20AM +0000, Li, Xiaoyun wrote: > > > Hi > > > > > > > -----Original Message----- > > > > From: Nithin Dabilpuram > > > > Sent: Monday, August 16, 2021 15:10 > > > > To: Li, Xiaoyun > > > > Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram > > > > ; jia.guo@intel.com; stable@dpdk.org > > > > Subject: [PATCH 1/2] app/testpmd: fix csumonly mode when run without > > > > outer chksum > > > > > > > > Donot use outer metadata when neither outer ip checksum nor outer > > > > udp checksum is enabled. PMD's will ignore the outer_l2_len and > > > > outer_l3_len in cases where none of the outer checksum is enabled > > > > and hence only l2_len and l3_len will be used to calculate the offsets for L2 > > or L3 header. > > > > > > I don't understand. > > > In process_outer_chksum, only PKT_TX_OUTER_IPV6 Will be set if it's ipv6 > > packets. > > > So PKT_TX_OUTER_IPV6 means this packet is tunnel ipv6 packet. So it actually > > needs outer l2 len and outer l3 len put them to hw. > > > At least i40e needs outer l2 len and outer l3 len as far as I know. > > > > Ok, do you mean m->outer_l2_len and m->outer_l3_len will be referred in i40e > > driver even when both DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM and > > DEV_TX_OFFLOAD_OUTER_UDP_CKSUM are not enabled in ethdev Tx offloads ? > > > > I thought as per spec, those fields will only be used when the Outer offloads are > > enabled. > > Checked again. You're right. Tx offloads are enough. Ack, thanks. > > > > > > > > > > > > > > Fixes: 3c32113a1aac ("app/testpmd: fix IPv6 tunnel checksum") > > > > Cc: jia.guo@intel.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Nithin Dabilpuram > > > > --- > > > > app/test-pmd/csumonly.c | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > > > > 607c889..38cc256 100644 > > > > --- a/app/test-pmd/csumonly.c > > > > +++ b/app/test-pmd/csumonly.c > > > > @@ -961,8 +961,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > > > (tx_offloads & > > > > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) || > > > > (tx_offloads & > > > > - DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) || > > > > - (tx_ol_flags & PKT_TX_OUTER_IPV6)) { > > > > + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)) { > > > > m->outer_l2_len = info.outer_l2_len; > > > > m->outer_l3_len = info.outer_l3_len; > > > > m->l2_len = info.l2_len; > > > > -- > > > > 2.8.4 > > >