From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0243A04FD for ; Mon, 23 May 2022 23:17:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5C8841611; Mon, 23 May 2022 23:17:07 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2138.outbound.protection.outlook.com [40.107.95.138]) by mails.dpdk.org (Postfix) with ESMTP id 9C35940156; Mon, 23 May 2022 23:17:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPe8ZiwSqV4xOiZzFTphoKvjZ8zdCOXdnrtIgKsuUemnWmxqreHe6+yIOPrh1wfC/vi9Eh1fSM50maEtCPgkBzfzeHLImmiKEEHeeuqzFkn8iIWtbtgvWNQ/ey9AICEV3CKMywow1jVY4Tmca2uEbpNyaoElqzUkFxeb/a/gbDW+NpUcW9T7Pepj7jSSl0x+87byOAM2SvhRtRxs5hF48sXAen8d2LDSmSUgZBNliJ+ZS05IqD56CPs6YbfeRQa1Axo2Z/ALdCXcx/vewapnTJqJzZXxD066hFNg0FWcIgEQ5dztepvfxiYBw/hIGgXIayrI66Fril6QtU9feiBQzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OHYOGP1grr4dnl9ekMGrWvQoAr+kfzpW5Wi4RafNuiU=; b=SsxY7765vschGlfWgK1UggWsz3ujTdja22mAXeOghVwYQ2dzRKgWq69+yo05OFCu2mx8snS9GqLd6xt5mgPxtViyAh/cTo6JGBrHfNh2lH4aqj2RR51jk3MPViOEF5Z3DiamFpW/mKAmzJOJbUiYn9M09umLU8lm6xf5uJVKmM0ykRza3sYjoWZOBr02jNK8CGQw4Ehv/z0YpZgbxv2nYULfKV662q1BxsU09HA5+htIBif8IUVq454QMU22V8cLZcNokQRC59Qroztcnzau08efV9nRf96R5r8rUtMAm7Ea0nhJQxU1sMXbF49KdzpMuDNzkuJ1pbbCmDGlPbnXRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OHYOGP1grr4dnl9ekMGrWvQoAr+kfzpW5Wi4RafNuiU=; b=gSKlrL4fG/Etyf2R6MFKuvAC6EnolJ46/XJcgETfpAmWo6NF2IDb/f2tnvisbkAXit8i7QsisC6ooGqUcyiUbYjcXHVwsaX+kYReus7mGgk2ioa/zyKPg+sTxd5pTwAH6d7n/Sver8IV3bFuBOUZp2fOoQqnLCPK39JRdRZbvTg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by PH0PR13MB5424.namprd13.prod.outlook.com (2603:10b6:510:12b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.7; Mon, 23 May 2022 21:17:03 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::4d5f:a0de:1d6c:1bc9]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::4d5f:a0de:1d6c:1bc9%3]) with mapi id 15.20.5293.007; Mon, 23 May 2022 21:17:03 +0000 Date: Mon, 23 May 2022 23:16:52 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Peng Zhang Cc: dev@dpdk.org, stable@dpdk.org, Yong Xu , Chaoyong He Subject: Re: [PATCH] net/nfp: fix the issue about set the vlan strip offload off Message-ID: References: <20220419083857.409261-1-peng.zhang@corigine.com> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220419083857.409261-1-peng.zhang@corigine.com> X-ClientProxiedBy: AM6P195CA0056.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::33) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a4455f7c-5a4c-4e8f-5183-08da3d0194fc X-MS-TrafficTypeDiagnostic: PH0PR13MB5424:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xY7JCQtuvul9Gx8J6vVqfk02tG3ZTkOqaaVhfBVziFb2ekapCpfY0jw/xaL5t+qLfDniqW2JreOXMY4PRIsU75pB1mnS5dBoU4k6ypBEzv4wHK4CRm8Di3gVUVYq6KeqSEcgZ8ZM6UCHGBZVcMHeTC8mIycZ15COAs30k1va2zNtZQo3Rbufv/g0e/+faxHV35vGlWpB5Ij55OiHN3ll9FQrlfOjc4GQQMxt8OJEWrco/EP6RduUgP07zEbZuQY0zmh/PSgTPCmTh5fsr+s80/BZt3G+dM5VosNktIMYI31PNXAYQsmrfu76Qsrb4y5pX+dIRBLg8Vbkgc4m0ltIKEPFl1nAr5ZZji1s9Qx8sefxzhKfjtX9ma0xbSdcuILZ8lj4Y9duo4kBP/TsejvsYuDQLarK7clyMVcGsFzIEGfhsETKtRPlukdd+4geZAJNRCgRfN/rMSZ7hMUteQWHwSSWr4yv/DO/cJuJKHQ2L63TxNWXVetYC17BrPWx6Heyd2gdhRhaAJYSLc5fQtGbgjB8sioMTZo+kfDImHEMABp1H+gspbMR749sD+4flDxGFdpOFSWYDjEnjutfotN9++8QNED6i4evLhlvXjSBB35b7BmPhaqMvLJwdRr7jIXmIFjcizHhJg2uGIYYKjFiOcJcQOAh1G98wqAmakYu0EQ2MBXv5YL3GNmQzdOheP4gckuitzGXgcH9NbF6vMBju3fhFNVex8UUtCt7hAVvv3I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66574015)(6666004)(6486002)(508600001)(450100002)(5660300002)(6862004)(4326008)(8676002)(66476007)(66946007)(66556008)(107886003)(2906002)(8936002)(186003)(53546011)(316002)(52116002)(38100700002)(6636002)(54906003)(26005)(6512007)(9686003)(83380400001)(6506007)(38350700002)(86362001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?XbkntcENOlxzIUnryJ/6XaZAp5z/O++Ecq9UeGkvA9b3uf3I7xeGCR76DE?= =?iso-8859-1?Q?vBgwHZNq1PAlphoPXkdp/8qjWXea5hDJB44kD1uDX1g0O9KK9jWB6fCFl4?= =?iso-8859-1?Q?VdqL46D22dfJNXcX9KoyOh267mODIfVUxodEhwVFkl4cYggIoARNI6vOUx?= =?iso-8859-1?Q?Yvnj4zkWaXjUQIiceDxqNt+J9mx0/gK6X+qR2gdtrnHLVJZ7XxRSe/1AZL?= =?iso-8859-1?Q?9UhN2waz40kLAg6EKUqTCI56NONjue4Eis/6+nF+DsOD7tzezUZbHkdNqK?= =?iso-8859-1?Q?xU8GuiZAnOPAU0/GN+oBma9ibahdS34zovokceJ5pPBC7LXgnMYNHdeed1?= =?iso-8859-1?Q?tb89GqC9yNL9txUy43/6WVaeqakdKv1Y3cioHAgzX/oK6E9Lvaxxynm+kH?= =?iso-8859-1?Q?sK9cWlBnbcp/tl/zM7u19YRTDQl+Ldqh1TRIythHzkd2a+rBNcqV1/tewT?= =?iso-8859-1?Q?AkeENDO9Hbmd2BJCP6Lti9JK598GtfUaM93GvRUD84oNDU09OP/LfDe7s1?= =?iso-8859-1?Q?IaaaZkkSh9K4dtvQAbmqlYq1YwisWMhWviH6XPh9JCN99t1spQSLgeeWQV?= =?iso-8859-1?Q?/OZVOGyuXSQH+cdXNSVPMLu3eLFrlNP2znwQfJrkjhDXxT1sdwjW12WTgH?= =?iso-8859-1?Q?Mpjm72XqfBDU1pKq5L7oiK8wlznFYjQxQKse82fdIjodGolcN6DnF4dOCR?= =?iso-8859-1?Q?te2B8NDL+8SY9XAbUisOVe+J5M2Z2bBzmGlr0Q5wW2kFNlH/eJodKAAt41?= =?iso-8859-1?Q?NsF1zW7jTi4FrZjaMmU7M0KSAZG5K7OWFo4S91kL0fFFozF6xELpX1Y1dU?= =?iso-8859-1?Q?B6dJAAdeSFKxQJU1cJnKeFSLMx2lOqRgu5mfmZDi+F3BVEfxLV1s1Yd2FY?= =?iso-8859-1?Q?Q2FL6ufJkNlsW+jjtrp3YUmG9xd5HLqVPtc6HSVnVXb6FKuyrJC12mc7iE?= =?iso-8859-1?Q?LHuTt17We8MLoY/kABJPbaPL86iyIBogVH4BXYx7IwwgRWty/r2/VHP5jo?= =?iso-8859-1?Q?2PADCkzx99HctJQ/naX0x1OCxwtF/Yplt6CGawEgapLxoP0phlcbeyFIwz?= =?iso-8859-1?Q?3oxUctdzWtxnUWxYg5cLs+d34rTIXWw8xzOcr90QPn1Mfth2I9xsyPfSsy?= =?iso-8859-1?Q?kBu94lQ4CTTtssRVcKFSXobgEJ+efG5zUEr8QOOAPHU7QJ0isi3AzoXOdx?= =?iso-8859-1?Q?zEvpQug8jj+VRNoCSI0WhAW8soARdVQA5YNota2U/EojyqFMD5HlUOhCMm?= =?iso-8859-1?Q?UXkSnjExvc4RXdSU+wynB5j8OuPOz3s8OjmuA3pIZ0gQmVqYt77UXSqoty?= =?iso-8859-1?Q?Nt9xJfLsg2E0Q4y87FS5R+n3WXtIj6txX7ZqcNzwgMXZnDaL7zj21wm0A4?= =?iso-8859-1?Q?z/Smpy1Ltw9w2osBBZpnHQj1SYHhaBM0XESIEy8ZYI6txR4betiHfQAD48?= =?iso-8859-1?Q?7DlktKVY+IMP30HXWXvctTNOr7EwIfoGKJnd3YR9whDif6I8S6PsKPzeAO?= =?iso-8859-1?Q?Yf+ZMGxm/b9SJrhNam7Uja4Ke3pWOhH8SzhywmzVP+uAgNEW5+sZinpJI5?= =?iso-8859-1?Q?GlOjnU5iQrPuHoOSAQCqzOKc+XzJAP/pmqx2r3HLeQNjhwNBv6lFux56wy?= =?iso-8859-1?Q?MiXeAzwpdRt+GCsqTotLgiHz+wBtpLf3b3pWNRxh34iSbOPXv1hL7+z6+h?= =?iso-8859-1?Q?wO2vJ/tQeaYhO+/43hz592hQkEeybu5z9wP0/Vrp2WIlf7w83iIAWEWTTk?= =?iso-8859-1?Q?YxiZyRkb9UPnpdzjWQAwYJL73kDHFmb08gaa832J9TOw2bhKvXC3B3xw0B?= =?iso-8859-1?Q?YtnggV4nGKWoKSA/noi2PaUmRrTiRlE=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4455f7c-5a4c-4e8f-5183-08da3d0194fc X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2022 21:17:03.1733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8acxoL412AutcRh2kz+NP3q2YCdtVDf/ChlnR24W6b/fwbZ0LpSAuo2TCbB8S1e0T1JyApQ9geKqRUA5qKS+MckUiGqtNbHSeMeLbpovvoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5424 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Peng, Thanks for your work. On 2022-04-19 10:38:57 +0200, Peng Zhang wrote: > When set the vlan_strip_offload off, it doesn't work. > Because we can't update the msg in the nic. > > This patch will fix this error. > > Fixes: d4a27a3b092a ("nfp: add basic features") > Cc: stable@dpdk.org > > Signed-off-by: Peng Zhang > Signed-off-by: Yong Xu > Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund > --- > drivers/net/nfp/nfp_common.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > index b26770dbfb..ab4cfda389 100644 > --- a/drivers/net/nfp/nfp_common.c > +++ b/drivers/net/nfp/nfp_common.c > @@ -968,19 +968,18 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev, int mask) > int ret; > > hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private); > - new_ctrl = 0; > + new_ctrl = hw->ctrl; > > - /* Enable vlan strip if it is not configured yet */ > - if ((mask & RTE_ETH_VLAN_STRIP_OFFLOAD) && > - !(hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN)) > - new_ctrl = hw->ctrl | NFP_NET_CFG_CTRL_RXVLAN; > - > - /* Disable vlan strip just if it is configured */ > - if (!(mask & RTE_ETH_VLAN_STRIP_OFFLOAD) && > - (hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN)) > - new_ctrl = hw->ctrl & ~NFP_NET_CFG_CTRL_RXVLAN; > + if (mask & RTE_ETH_VLAN_STRIP_OFFLOAD) { > + /* Disable vlan strip just if it is configured */ > + if (hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN) > + new_ctrl = new_ctrl & ~NFP_NET_CFG_CTRL_RXVLAN; > + /* Enable vlan strip if it is not configured yet */ > + else > + new_ctrl = new_ctrl | NFP_NET_CFG_CTRL_RXVLAN; > + } > > - if (new_ctrl == 0) > + if (new_ctrl == hw->ctrl) > return 0; > > update = NFP_NET_CFG_UPDATE_GEN; > -- > 2.27.0 > -- Kind Regards, Niklas Söderlund