From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Michael Baum <michaelba@mellanox.com>,
Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [PATCH] net/mlx5: fix build with clang 14
Date: Fri, 10 Jun 2022 14:54:01 +0100 [thread overview]
Message-ID: <YqNM+cNjfKWcrlPj@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20220518091100.1182494-1-david.marchand@redhat.com>
On Wed, May 18, 2022 at 11:11:00AM +0200, David Marchand wrote:
> clang 14 raises the following warning:
>
> ../drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error: 'fscanf'
> may overflow; destination buffer in argument 3 has size 16, but the
> corresponding specifier may require size 17
> [-Werror,-Wfortify-source]
> ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s",
> port_name);
>
> Extend port_name so that it can fit a null terminated string.
>
> Fixes: 63d1db710fbc ("net/mlx5: fix unlimited parsing of switch info")
> Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Seeing this error with Ubuntu 22.04, and this patch fixes the issue.
Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2022-06-10 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 9:11 David Marchand
2022-06-10 13:54 ` Bruce Richardson [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-11 13:58 Ali Alnubani
2022-05-11 14:04 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqNM+cNjfKWcrlPj@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).