patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] app/flow-perf: fix logic to add comma every three digits
@ 2022-06-10 22:06 Rahul Lakkireddy
  2022-06-10 23:45 ` Stephen Hemminger
  0 siblings, 1 reply; 3+ messages in thread
From: Rahul Lakkireddy @ 2022-06-10 22:06 UTC (permalink / raw)
  To: dev; +Cc: daxuex.gao, wisamm, stable

Add comma after 1 in 1000 too, like 1,000. Also, since max uint64_t is
a 20 digit number, increase space in temporary array to hold 20 digits.
Fixes following warnings when using optimization=1 build flag with
GCC 11.

../app/test-flow-perf/main.c: In function ‘pretty_number’:
../app/test-flow-perf/main.c:1737:28: warning: ‘sprintf’ may write a terminating nul past the end of the destination [-Wformat-overflow=]
         sprintf(p[i++], "%d", (int)n);
                            ^
../app/test-flow-perf/main.c:1737:9: note: ‘sprintf’ output between 2 and 5 bytes into a destination of size 4
         sprintf(p[i++], "%d", (int)n);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Bugzilla ID: 1029
Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support")
Cc: stable@dpdk.org

Reported-by: Daxue Gao <daxuex.gao@intel.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
 app/test-flow-perf/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
index 56d43734e3..594507a85e 100644
--- a/app/test-flow-perf/main.c
+++ b/app/test-flow-perf/main.c
@@ -1724,11 +1724,11 @@ do_tx(struct lcore_info *li, uint16_t cnt, uint16_t tx_port,
 static char *
 pretty_number(uint64_t n, char *buf)
 {
-	char p[6][4];
+	char p[7][4];
 	int i = 0;
 	int off = 0;
 
-	while (n > 1000) {
+	while (n >= 1000) {
 		sprintf(p[i], "%03d", (int)(n % 1000));
 		n /= 1000;
 		i += 1;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] app/flow-perf: fix logic to add comma every three digits
  2022-06-10 22:06 [PATCH] app/flow-perf: fix logic to add comma every three digits Rahul Lakkireddy
@ 2022-06-10 23:45 ` Stephen Hemminger
  2022-06-13  9:55   ` Rahul Lakkireddy
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2022-06-10 23:45 UTC (permalink / raw)
  To: Rahul Lakkireddy; +Cc: dev, daxuex.gao, wisamm, stable

On Sat, 11 Jun 2022 03:36:43 +0530
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> wrote:

> Add comma after 1 in 1000 too, like 1,000. Also, since max uint64_t is
> a 20 digit number, increase space in temporary array to hold 20 digits.
> Fixes following warnings when using optimization=1 build flag with
> GCC 11.
> 
> ../app/test-flow-perf/main.c: In function ‘pretty_number’:
> ../app/test-flow-perf/main.c:1737:28: warning: ‘sprintf’ may write a terminating nul past the end of the destination [-Wformat-overflow=]
>          sprintf(p[i++], "%d", (int)n);
>                             ^
> ../app/test-flow-perf/main.c:1737:9: note: ‘sprintf’ output between 2 and 5 bytes into a destination of size 4
>          sprintf(p[i++], "%d", (int)n);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Bugzilla ID: 1029
> Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support")
> Cc: stable@dpdk.org
> 
> Reported-by: Daxue Gao <daxuex.gao@intel.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>

There was a better alternative proposed here:

https://patchwork.dpdk.org/project/dpdk/patch/20220518101657.1230416-12-david.marchand@redhat.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] app/flow-perf: fix logic to add comma every three digits
  2022-06-10 23:45 ` Stephen Hemminger
@ 2022-06-13  9:55   ` Rahul Lakkireddy
  0 siblings, 0 replies; 3+ messages in thread
From: Rahul Lakkireddy @ 2022-06-13  9:55 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, daxuex.gao, wisamm, stable

On Friday, June 06/10/22, 2022 at 16:45:22 -0700, Stephen Hemminger wrote:
> On Sat, 11 Jun 2022 03:36:43 +0530
> Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> wrote:
> 
> > Add comma after 1 in 1000 too, like 1,000. Also, since max uint64_t is
> > a 20 digit number, increase space in temporary array to hold 20 digits.
> > Fixes following warnings when using optimization=1 build flag with
> > GCC 11.
> > 
> > ../app/test-flow-perf/main.c: In function ‘pretty_number’:
> > ../app/test-flow-perf/main.c:1737:28: warning: ‘sprintf’ may write a terminating nul past the end of the destination [-Wformat-overflow=]
> >          sprintf(p[i++], "%d", (int)n);
> >                             ^
> > ../app/test-flow-perf/main.c:1737:9: note: ‘sprintf’ output between 2 and 5 bytes into a destination of size 4
> >          sprintf(p[i++], "%d", (int)n);
> >          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Bugzilla ID: 1029
> > Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support")
> > Cc: stable@dpdk.org
> > 
> > Reported-by: Daxue Gao <daxuex.gao@intel.com>
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> 
> There was a better alternative proposed here:
> 
> https://patchwork.dpdk.org/project/dpdk/patch/20220518101657.1230416-12-david.marchand@redhat.com/

Thanks Stephen. I missed this earlier patch from David. My patch
can be dropped.

Thanks,
Rahul

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-13  9:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 22:06 [PATCH] app/flow-perf: fix logic to add comma every three digits Rahul Lakkireddy
2022-06-10 23:45 ` Stephen Hemminger
2022-06-13  9:55   ` Rahul Lakkireddy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).