From: Bruce Richardson <bruce.richardson@intel.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2 2/3] dma/idxd: fix memory leak due to free on incorrect pointer
Date: Mon, 4 Jul 2022 14:25:49 +0100 [thread overview]
Message-ID: <YsLqXc4bXSvxi061@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <YsLp2n9HS1aV15Xe@bricha3-MOBL.ger.corp.intel.com>
On Mon, Jul 04, 2022 at 02:23:38PM +0100, Bruce Richardson wrote:
> On Sun, Jul 03, 2022 at 01:22:42PM +0100, Kevin Laatz wrote:
> > During PCI device close, any allocated memory needs to be free'd.
> > Currently, one of the free's is being called on an incorrect idxd_dmadev
> > struct member, namely 'batch_idx_ring', causing a memleak from the
> > pointer that should have been free'd.
>
> I think you need to explain that the two rings are beside each other in
> memory and we need to free using the pointer to the start of the block,
> rather than the pointer to the middle of it.
>
> > This patch fixes this memleak by calling free on the correct pointer.
> >
> > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
> > Cc: stable@dpdk.org
> > Cc: bruce.richardson@intel.com
> >
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
>
> With more explanation in the commit log
>
Correction (obviously!)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2022-07-04 13:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220408141504.1319913-1-kevin.laatz@intel.com>
2022-04-08 14:15 ` [PATCH 1/5] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-04-08 14:49 ` Bruce Richardson
2022-04-08 14:15 ` [PATCH 2/5] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-04-08 14:52 ` Bruce Richardson
2022-04-19 16:20 ` Kevin Laatz
2022-04-08 14:15 ` [PATCH 5/5] examples/dma: fix missing dma close Kevin Laatz
[not found] ` <20220703122243.929642-1-kevin.laatz@intel.com>
2022-07-03 12:22 ` [PATCH v2 1/3] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-07-04 13:19 ` Bruce Richardson
2022-07-04 13:34 ` Kevin Laatz
2022-07-04 13:44 ` Bruce Richardson
2022-07-03 12:22 ` [PATCH v2 2/3] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-07-04 13:23 ` Bruce Richardson
2022-07-04 13:25 ` Bruce Richardson [this message]
2022-07-03 12:22 ` [PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove Kevin Laatz
2022-07-04 13:25 ` Bruce Richardson
[not found] ` <20220704152751.943965-1-kevin.laatz@intel.com>
2022-07-04 15:27 ` [PATCH v3 1/3] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-07-04 15:39 ` Bruce Richardson
2022-07-04 15:27 ` [PATCH v3 2/3] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-07-04 15:27 ` [PATCH v3 3/3] dma/idxd: fix null pointer dereference during pci remove Kevin Laatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsLqXc4bXSvxi061@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).