* [PATCH 2/2] build: fix warning when running external command
[not found] <20230529055751.3035712-1-ruifeng.wang@arm.com>
@ 2023-05-29 5:57 ` Ruifeng Wang
2023-05-29 8:12 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Ruifeng Wang @ 2023-05-29 5:57 UTC (permalink / raw)
To: bruce.richardson
Cc: dev, jerinj, honnappa.nagarahalli, feifei.wang2, nd,
Ruifeng Wang, stable
Meson gives warnings on calls to run_command when there is
a missing "check" parameter. Most of the occurrences has been fixed.
Fixed the remaining one in this change.
Fixes: ecb904cc4596 ("build: fix warnings when running external commands")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
config/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/meson.build b/config/meson.build
index fa730a1b14..65087ce090 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -366,7 +366,7 @@ if max_numa_nodes == 'detect'
error('Discovery of max_numa_nodes not supported for cross-compilation.')
endif
# overwrite the default value with discovered values
- max_numa_nodes = run_command(get_numa_count_cmd).stdout().to_int()
+ max_numa_nodes = run_command(get_numa_count_cmd, check: true).stdout().to_int()
message('Found @0@ numa nodes'.format(max_numa_nodes))
dpdk_conf.set('RTE_MAX_NUMA_NODES', max_numa_nodes)
elif max_numa_nodes != 'default'
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] build: fix warning when running external command
2023-05-29 5:57 ` [PATCH 2/2] build: fix warning when running external command Ruifeng Wang
@ 2023-05-29 8:12 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2023-05-29 8:12 UTC (permalink / raw)
To: Ruifeng Wang; +Cc: dev, jerinj, honnappa.nagarahalli, feifei.wang2, nd, stable
On Mon, May 29, 2023 at 01:57:51PM +0800, Ruifeng Wang wrote:
> Meson gives warnings on calls to run_command when there is
> a missing "check" parameter. Most of the occurrences has been fixed.
> Fixed the remaining one in this change.
>
> Fixes: ecb904cc4596 ("build: fix warnings when running external commands")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-29 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230529055751.3035712-1-ruifeng.wang@arm.com>
2023-05-29 5:57 ` [PATCH 2/2] build: fix warning when running external command Ruifeng Wang
2023-05-29 8:12 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).