From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AF2142CC7 for ; Thu, 15 Jun 2023 17:10:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A35A40EE3; Thu, 15 Jun 2023 17:10:39 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 9678B40E0F; Thu, 15 Jun 2023 17:10:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686841837; x=1718377837; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6Fl49o6JDI8UtHg8B/qAFggUPa1YSD1sAvSRNmNB53A=; b=NPUmk8e6YN2GCv0f9/vaQPbN1GuMzHUL4pTWWzLEn33UB0ytwOJsbliT Y+veZz4Wkm/TdYvTp356pZ7MlLdJhP5f7ZglZXoHiyWoRBDAY3UNvCcVf LUHJvrbRvdHXpKZsuV5g5XDAzuCIHD46X4CAimMbbmEl2TJPkFJHOdJdY RZbCDOgdDCRybiSMlqP8WySnkdeUd7MaalUhFfD5s6hGw6GCmuPsfVLnx 5aJ675auJgph8/YsDW79WNr0t3vZWix502A00d8Nu0AIgvhW3e+Mxiobt fROG7v1l8/GodQOGydHOFHL4LYhoSQeoif5ucBIl2gTgGhgHTskOpEBMJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="422564442" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="422564442" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 07:42:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="782535378" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="782535378" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 15 Jun 2023 07:42:13 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 07:42:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 07:42:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 07:42:12 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 07:42:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EtcV5kIde/FMe5ZW8iM1NoKqC4fSZpw65xebUZY1gaNnB4JEPBhNaFt833uyfLbrIEvEa2kZS4wFbIZlaqv91EMVM1gZwz0HJ0P6rbolQY0wqDHQzTWsOb84Kgx7nNlvd41bdKg0qsSD+DZuE92RmFLml/vM6eGK5sFWxFxB8R83PAzpjMzhmb9fk0K+f6icJPMHPH4f4+Q/2aLruT9GDQIlTxl2sA/IK+8innAkANL/daUutqyMS2u/+qwz+1DJA+Zo63thW67mdsnryd2i6+r32d9IAiMOdtm7qsa7r8e9poIkY66+01mYErD8f0a7JI6ezdv7JC56J4v1W00ASw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Zaj+UeEpL8blqw2QKVcWv278hmsOwxxUgkNeI7nPsU=; b=Stv0l76R8pNFupRpHNUu4Fr6wp1eK7SpgoVigfdF2PXqhVhH5OamrIxWQKdOAV0uC8ZTrFHXEYt+dIwfHmmWsiNSEVP3MPuZVjltdVumtp1OMnJmMZHPpEKww3N/HvJ4chtGbqVK9EQCqo785JlvifkY3EfsSZs3dlSR9Wmn5yjBEAQcRJ10F+CU1LBA/v6jhcSt2vv1hy9IU7ryttsD/c0q9rEEd5NJxBPkg5KUOBZda3U4BMJ241ZZptsjAHbY178DIMS4CXue+BF5cBbS/zjM9KpnBsdW0pCJ3CHDqrjKpYAT/LXCXfxfyXzc5chhgHmPjn+oal4dZPqZcLQCuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB8150.namprd11.prod.outlook.com (2603:10b6:208:44c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Thu, 15 Jun 2023 14:42:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 14:42:09 +0000 Date: Thu, 15 Jun 2023 15:42:03 +0100 From: Bruce Richardson To: David Marchand CC: , , Olivier Matz , Dekel Peled , Andrew Rybchenko Subject: Re: [PATCH] mbuf: fix doxygen for distributor metadata Message-ID: References: <20230615134942.3393383-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230615134942.3393383-1-david.marchand@redhat.com> X-ClientProxiedBy: LO2P265CA0043.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::31) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB8150:EE_ X-MS-Office365-Filtering-Correlation-Id: 7610ce84-7933-4119-f2b1-08db6daeb26a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +paQkumJBZ/ELQomwRtgD33H0cPuXufx29FSnmcp8SM8OoHwi8KhqsmIrVQdpxy87Svelsm2JPsmQ+zISJ6tYEVMvUD9+PJ1qLrjuMzI5RzCfhvECoIxOGPgxbVXO/rpdriFxYaveoVBQvnvamLQscZdn2wUTfRWc8tRo0ONQ40b8Me3vmJUDh7G3RZJzGBF4gY71c/0HY52PtDTNIcrg0q/QuQJlFIUYsNYfl2oMF7koc5VmoLbylRK7qV4cUI3rzkzs8beHZmffSNXw/W0M+QVIZjO4cx9VH1p+F3KZIxqphIDXDYAAXXSaFCOWPWAIdFSoJiwyBPKVIvehnnUmW92lFz4mT74/E2TbMvP1nntYa5InqsHnZlXvCWy16DL+oWvFs4vEfg+mb85WMC/aLEzuDXt5/7AHWKLJhmP/0P8vpBW8YJUZJ4+sFLB9Cj3AFwIajnZiYpy6zrt8Xpx0PX9i9sobCDBmbfskLVW93vG7uX9LxZYDrINYmbs/rDbP6OIJXG/0wQpfgmZ9ZOhr6zYeWUUuThHERa4TxFxDZxNiRrPFL8abKmJlSpE/7S0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199021)(8676002)(66556008)(8936002)(5660300002)(66946007)(6916009)(4326008)(66476007)(316002)(54906003)(44832011)(2906002)(41300700001)(6666004)(478600001)(6486002)(6512007)(186003)(6506007)(83380400001)(82960400001)(26005)(38100700002)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SPxZYF93+9rra7x0oG720Dq3s+RgoxLcFy8Oy0Zv3YhOCcTgXs2H01Hir1fr?= =?us-ascii?Q?dFrOC5U6TCN8YI3iigKB+K5ItFlAIl6eOYARfLaxT/fz4H3onmq0K1Sq62ej?= =?us-ascii?Q?biX+xtwEFOFRYPQNZsbh0c0ljJ5aW9MX6Knm/WK7hkuUh/U7WXgZLLKy7+mf?= =?us-ascii?Q?moQvJiWUBua45+g+Da8lA1cy1Lgwwxaq8nOvq0bfBK/45XQPf1euGrTmNvL5?= =?us-ascii?Q?1YZOrNZ3MqzTXUsVmQJvqFQcWiCny52gl6f0Z8FhiCUZDn0wLNmuCakyQR7U?= =?us-ascii?Q?1a4nJzaZ/mabuopoGYazZ0k7t1YVMrgekUh/M/jNxV8zYDX4IBZQsHsdbkh3?= =?us-ascii?Q?PSOalN9TKFg6ekb4VoREiUfhqjzZD35s5wivmqjtvFLe1xuOkMfJV/ASijnl?= =?us-ascii?Q?Afqr88Lr1A/xLAvwMascOBx94FKmP4WwD3u5gFrmGm+YlNdfIMs7nUeVl3a1?= =?us-ascii?Q?H9wp0FZxedsxDdTPd+5DCc1QgMQFSdXDnFU008szARQFeUjEfMyzHSD3XtKG?= =?us-ascii?Q?FHEy4BJduAUkc9CCDwvfz0pu2MkvaTyEy0MJAKx9dnkOw+XQcaROZ52whS5J?= =?us-ascii?Q?9i1uS4YvYEX4bXxs0DC2DLKZQCpgEvA5gA7QB97Q/LBeUgKmT9+/t/4pxBtC?= =?us-ascii?Q?IMUQVuCkdcHMTjfSzmWQJ93f7nknInu8nXLr/eu3h0Tc33d8rwqO6CDnBe8p?= =?us-ascii?Q?fRF3GONjZbOSBovJ+Hd2P0NtUb2aNg8zAvS0Jbs7nm61yhS1p8Qz2k2kaFah?= =?us-ascii?Q?pJChfS32as4VYMECT0CDbCjfs87EKNJLZ0TQevpc3gXWxnPXL9dSlpovBFdG?= =?us-ascii?Q?zu76QVagqrQAZuuO0InizSifYrkLp4LiBGqPjxunsZxf5H6I7sKxkqOyVdWn?= =?us-ascii?Q?BF0aTGlUarmZTQJhrNQwZhz3/D4vWhWgdz/T9YD/3/4ny/QkAdVwihNe+RCp?= =?us-ascii?Q?oWC8QP2+FW3xWs2hwoQTduh8fwaZ5tH1X1T9nVyPjBmwOaeYk7gB2vWQQDEC?= =?us-ascii?Q?tP1ZfoKK2NzsM+7/6RpRwNsDJpgZJAv8xLDH0LOo/3dtqhzH8RL5jG3fg2j8?= =?us-ascii?Q?TM6KPc/ZlN7G9lNgutLsr6vCAAix3z7hszlGc7hmE0MJECoBvYEj1ljrvZrB?= =?us-ascii?Q?nTksVTLmQn93pJe0xvTeD/U6n+q7gznWwftjWYfg/BnoirgBK3FRITg3C5/c?= =?us-ascii?Q?coi5SsDejCQflGNIbmD0U6p+uz0JKGYOgGtHqAVUq+k5wKZXTmSiDCfYeEgW?= =?us-ascii?Q?BDMKlgEog/KaVq6bCCMdPmO3xp89Wn2Y19pVfsYAKRke2OKrdz+bAaqoQeNO?= =?us-ascii?Q?gI4qmz0q8+YmxIlAXjmYxwWP5MsKGjh08K2hBttFeQlg7U+Wtt7BmFtsZ2Uh?= =?us-ascii?Q?sfMvOpToQtyEQBMTZs+cPnrhNyT68M5+u2Z4QtRoU018cWrGOzye0d8GcBG4?= =?us-ascii?Q?sFoXVv0jwQJDb3ykWD8AHEi3GkWZMO26rUOAMHnG8vxJXIhIZmTHZmKDjkFw?= =?us-ascii?Q?Lfazs0K/gCSehAg64ntljPNEiqueUk55zsBVX11kEk+AlD5gG8PB2fiR6aI1?= =?us-ascii?Q?0lGHsxKZh2se9epnzm4+l5vWBeQIjP0gCAtpbVC0Pn1KfdxsV5rxW8LYOrO4?= =?us-ascii?Q?SQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7610ce84-7933-4119-f2b1-08db6daeb26a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 14:42:09.0287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vq5K/LnHKbyhQZH5xfvmypYyXMeK2v/jCMEPc1hsGrw9FWV4mQjqk9bRDMwrO1j6bULZj3N/ESpBi0SUMSk2mI65IDg3tJ52COsptFLs5E4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8150 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Jun 15, 2023 at 03:49:42PM +0200, David Marchand wrote: > /**< is for post annotations. > > Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > lib/mbuf/rte_mbuf_core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > index c692c33ec4..2030b3bef9 100644 > --- a/lib/mbuf/rte_mbuf_core.h > +++ b/lib/mbuf/rte_mbuf_core.h > @@ -584,8 +584,8 @@ struct rte_mbuf { > * @see rte_event_eth_tx_adapter_txq_set() > */ > } txadapter; /**< Eventdev ethdev Tx adapter */ > - /**< User defined tags. See rte_distributor_process() */ > uint32_t usr; > + /**< User defined tags. See rte_distributor_process() */ Yes, this fixes the issue, but... I dislike having the comment on the line under the item in question. I think the post-annotation comments should only be used for comments on the same line. If the comment is to be on a different line, I think it should go on the previous line to the item. I also think this tends to be the style used throughout DPDK generally. /Bruce > } hash; /**< hash information */ > }; > > -- > 2.40.1 >