From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A29A431DD for ; Mon, 23 Oct 2023 13:53:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B4EF41109; Mon, 23 Oct 2023 13:53:49 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id B0B6B40270; Mon, 23 Oct 2023 13:53:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698062027; x=1729598027; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=s86Ti2EURapSU54Zuk7WnB1kDu9rB66x8nOV+V7NRoU=; b=atkYlZfIJm+AW5sHzZfiTSQcgMiQbYcWQV+GyPTriq/L4aJrKVBfcLWi Cf5pA/5NAwrc6IeAYwK04uFhlgpbffjBaosMVZHSldsjTdC4NnXagikJ2 vsCl/ZWh0qWcvmswixTbIuRCxqBgf1x+UicUMmnINACikwTGNae+4l4/T OPesfcTEjgnCVLdJDR2GS3gtGT/e5fK0XJVCaKUpt3rvvJqOVEfAsIMvC 3o0XGNUVTWKuXXeJYBlOQUCda9BCcFbnX+BEuHModobuh8P20gLQJagFb LOU093idu3ZtdBTPDINW53UY9H9SPJaqaEONpVjqLRoEbyiKo6OrXzhXA A==; X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="390710160" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="390710160" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 04:53:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="1089471138" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="1089471138" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Oct 2023 04:53:45 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 23 Oct 2023 04:53:45 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 23 Oct 2023 04:53:45 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.40) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 23 Oct 2023 04:53:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YH1KvopQHiA61UMLpzDO8mZn1269qmgtqZzFD/gu+Gf97IeIKkNaZji/w+a/mfThgNS/KlOySCznqfphOLdL+H3Oam41BMnOrKzKGfQMq3QsrGy2WeuTUCDq3VnvmUNwJx+w3qJrKf/X/D+VcxmgvWkTWgd1Lk3bcKgNwu0E4Iljk+BxLz2LPtJcx5hayO6vghB4B52a5j2cgZ5FaXb3VScWzqWsFfQuznd8avJAE2fZdgXAFfiYPtBXi68Jcgk2+lo+IzbFMA0H8b7Dk1aZH9mzp32WIl5phPyIGW1OsOGnqaKB6t09bjRuiyc2hJbQvmXtROuZvClkkNA8M2RZmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oZfLLLXxoK4dVZQ5Ktr6HCjnfuK7GS6oJkGPqrAk3vQ=; b=NCqwgm/LRUo+zjGb0JPPNR4sDtaNPhXqh71zRU2qfqQDJt8L73sXnU0oPvtJQztPbBX2k2jhborSrWknkRQqi/9D/x5xIUI9/m5hV3t8KE9I8d8dUsrwCBb/vylj3xe8KAxgSFBqWrVB+f0Ch/C3BOVG1xe4dWd3uRj02CiwZWDTI57CtQNrD7P1UWISl8wg4zMcK5y8fySiVGMVs95reCkb/EOTT1I5aW26EHmNV+H4wzzQ91fHnnImg9g3tCb6AlKuflEVQbSi+FGSHyjzORTU91k64Z5q9md/wzxFSLLaYRf/WkUwhSnUcdfyeQGvWFZftc96DbGgX33ky3znMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by CH0PR11MB5428.namprd11.prod.outlook.com (2603:10b6:610:d3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Mon, 23 Oct 2023 11:53:41 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::4f61:d541:87b4:e935]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::4f61:d541:87b4:e935%4]) with mapi id 15.20.6907.030; Mon, 23 Oct 2023 11:53:40 +0000 Date: Mon, 23 Oct 2023 12:53:34 +0100 From: Bruce Richardson To: Srikanth Yalavarthi CC: Aaron Conole , Igor Russkikh , David Marchand , "dev@dpdk.org" , Shivah Shankar Shankar Narayan Rao , "Jerin Jacob Kollanukkaran" , "stable@dpdk.org" Subject: Re: [EXT] Re: [PATCH 1/1] build: update link args and includes for libarchive Message-ID: References: <20231020170135.18319-1-syalavarthi@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DU7PR01CA0034.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::9) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|CH0PR11MB5428:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d662d64-af55-4a5c-f6dc-08dbd3beb30f X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H3eGWeqUGAP4j6kRNPGvKYV8YaBdWTVaFGSmRfL+Lodcm3yQ8vRKXZCMnlimpv3exxejB0TJhk0E2ncW/5XOU6HDPxXYf+3yFziiFJ3METyyWSyODFnW5W9hXvjS14UPjM7PQR7p8XOD3GMb3rJGeDC5eZMfuPw+JrfcdRJd/RnRtTHZ78iXOH7rgSrmBKxS+vu0ExvfhC/f/GQDWInaXjn7TBEjTtpFFTPy8oaM3yhQIV5/s8VtNVZsPpx9eZUhbCirNfRtC1vDLQNiKe7OkQ/tBQgW2/4eSKZci163vJoKBwspyTei2XhvPX6SrXbt8xwEQXNNuqu27rhX+kpdxgRZTIHzKd8DdcIyWHQ49jT0NMbPFks4jnzEJGeFTOEuykb3QkFvCfgQS0lmxF3z7eTMV6ioVKF6USdQofS57OdSorAuGcDwlrzxAlQYdyy7aaFugOAHC9BFP7eg13U0OkICdoO9QYfx24sPlXDSu1Vtn7QAd12JZdlCX2RQvpkLJzCHTB8nDClxMI4z57uaX/lG5VWN2wrmIvLYd9AZgOUm13YE6dD6UqTO9Y+BbDVE X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(39860400002)(396003)(346002)(376002)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(6506007)(53546011)(26005)(82960400001)(6916009)(316002)(66556008)(66476007)(66946007)(54906003)(6486002)(83380400001)(478600001)(6666004)(6512007)(38100700002)(8676002)(4326008)(8936002)(5660300002)(2906002)(44832011)(41300700001)(15650500001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wrEfUT8ZXdHBICgfSUCsa62Duh0RJ2/m6doxo8DgqWmjVUsFjIz6IGg1RZSv?= =?us-ascii?Q?lnKNwGDqBvYrawB+UhtYQj4WLm8n19mpme4MX2ScZfcEadSo9FFkV3tgvnAJ?= =?us-ascii?Q?onEHYl4wX9Pqw72f3stnsAwVoJZ5ryDZLFh78Ispb8P64yjg4BzUEM6/RhnF?= =?us-ascii?Q?ki09HBvHHcgzfzSMWhA0Gx+M7zzM/0fu9yI7N+SQhREM0y4U8TJ1YXSXP5Sr?= =?us-ascii?Q?EbM73Z8/WUN8Ir3ZL2dJRH7H1WLRuWFjTnrznTZ0jh0a1J1zDSvinH9j6dch?= =?us-ascii?Q?KSV5IUVE37nOJ1ex0ztAqCbkQ3qOaPyWnid1r7kBy500QX80SpN+BpFXGmPx?= =?us-ascii?Q?t2OJHQBhc8kz9243TrUsMZrxjlz1i9c+04jovJsQ5w3+25VIsPy4USyZCOMN?= =?us-ascii?Q?5nAANnYKcwNwtzcJWhSEen3zcZOc2hjXQ4RbNAzWYp+LOI6j1CZy4lKrWEU9?= =?us-ascii?Q?asS2YdIaSEOzdzHYIDr1ydiTxeIXvU3zJkrpcBEXX+rwPe+VmkaGvzRQo4gU?= =?us-ascii?Q?uQs8HvKi4sV0HxL/EWqsHpsKuKUBlUxgtw6ufyo/JtBvtdZz1kciDDyZMgLG?= =?us-ascii?Q?3DojqRXOcUFRdygb08x8oPMZIVOI1k8pdprLeKGLKVSvXLuVfMb9iUFA4gy/?= =?us-ascii?Q?29NYXsTATL2YtiYT4KnA9EO/HCSme2EJcoQxZ8fEXBzLn2X+CW52nDJobbD+?= =?us-ascii?Q?mXJSe5aFW8zuxyraaUrBO686kNZ0jWJbD8jVGF2ML1WeRP+bRhuWUWfOOEPK?= =?us-ascii?Q?GPZ+W1iIuagtY7c2Xh62LdEap8ncHjfVneS7coTzu+yQzNQfqHjQBGp1o6PS?= =?us-ascii?Q?oJVeeBSBgU5Kyt7hR0nt4+xslos8rRgERMjx/APAGOS45xGQ5m5VzYTVQTzE?= =?us-ascii?Q?zvgFRsAsyE13e7WH3SJQxlWW2xCK0UZTwCt2Fkv3uqZNHUt8ELb1GGIhrMrh?= =?us-ascii?Q?hc85hp7rMWC/R1bmKmIcjvY5f/2BCr663kp8yqPi1FVRsZNdjlUbkI4P5KS/?= =?us-ascii?Q?2IOxsZNlfXY9q1kgXoF6KQV0ztNvq9yquKO+5qE+Ic+Q+TS8MsfvlB1Wahoh?= =?us-ascii?Q?M4MjMNOB4jeB+BuMSPQkQkbVQ4OGzAesNUgrhvvoR20nDsB4M5TUo8mV4uxa?= =?us-ascii?Q?jTc22b8KFySn2Io3FdtQavDOtbCfTGKF+xtWxhidWywZprBwkOcLQBXoqHDE?= =?us-ascii?Q?IEYNqodhgsK/DFOYL1YJSCuHuHvJbUdUDjnqxvZtUmNQVlVU4xOY4XC11A4t?= =?us-ascii?Q?u80L6OjwAKVLZz665QmN980Deh283YOMTBdWcLGx9vTvILTELcbeHMPCZTZM?= =?us-ascii?Q?Jx4TB+/noSScW6vj17PUZS16BpjT6jAMOcJu637PhM/adtYJ/qO87ui51B75?= =?us-ascii?Q?wb8fWB7ZEZfAJKmc9ZPpiIAQiPlXB/V3MZTtvHk2TwOniw9LatiFOlu3W0nC?= =?us-ascii?Q?IQZlQdRQN8f/3bedJ0qC9aVHTewTMTPG2gU7wimUVD5jZCp8wuT1oUGv32bP?= =?us-ascii?Q?2k6zSrWxN7LCy70UVf+asKUUVx0Km4zi8NnequXNnGDRibX2aFgxpr0OYr1E?= =?us-ascii?Q?OJqrgJaO7ClyovyRZjWU7aURh9gFAWuY6lI9iwMX+iR+ghylSDvxeIQ4HmPk?= =?us-ascii?Q?Fg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6d662d64-af55-4a5c-f6dc-08dbd3beb30f X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 11:53:40.7489 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cdGf2JI7E+ouI3SFK3otBniKnV0adLr+Wf88ETLdqRnrxtWwRYQaYZI4H+sl6Ct22UCXguY58YX54EiPMDRjTlVhItcJGAvQFmtBNN9kPR4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5428 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Oct 23, 2023 at 11:40:14AM +0000, Srikanth Yalavarthi wrote: > > -----Original Message----- > > From: Bruce Richardson > > Sent: 23 October 2023 14:56 > > To: Srikanth Yalavarthi > > Cc: Aaron Conole ; Igor Russkikh > > ; David Marchand ; > > dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > > ; Jerin Jacob Kollanukkaran > > ; stable@dpdk.org > > Subject: [EXT] Re: [PATCH 1/1] build: update link args and includes for > > libarchive > > > > External Email > > > > ---------------------------------------------------------------------- > > On Fri, Oct 20, 2023 at 10:01:35AM -0700, Srikanth Yalavarthi wrote: > > > In order to avoid linking with all libraries listed as Libs.private in > > > libarchive.pc, libarchive is not added to ext_deps during meson setup. > > > > > > Since libarchive is not added to ext_deps, cross-compilation or native > > > compilation with libarchive installed in non-standard location fails > > > with errors related to "cannot find -larchive" > > > or "archive.h: No such file or directory". In order to fix the build > > > failures, user is required to define the 'c_args' and 'c_link_args' > > > with '-I' and '-L'. > > > > > > This patch updates meson build files to add libarchive's includedir > > > and libdir to compiler flags and would not require setting c_args and > > > c_link_args externally. > > > > > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Srikanth Yalavarthi > > > --- > > > > Checking back through the mail archives I'm still a little unclear as to what > > breaks when we try using libarchive as any other package with a pkg-config > > file? I would have thought the best solution was just to add libarchive as an > > external dependency, found using pkg-config, to EAL. When we add it as a > > dependency, rather than using c/ldflags, we should get all this path fixup for > > free? > > Can you clarify what breaks when we add libarchive as a libeal dependency > > only? > > Below is my observation. > > In current implementation, we are looking for libarchive's availability through pkg-config. > When found, we are setting RTE_HAS_LIBARCHIVE=1 and adding '-larchive' to ldflags. > > Since, we are not adding libarchive to ext_deps (to avoid linking with deps.private), the This is the bit I'm a bit stuck on. What is the issues with adding libarchive to ext_deps? For other libs, when doing static builds we have to link with deps.private and it's the correct behaviour AFAIK. Not doing so would surely lead to problematic builds, no? /Bruce