From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20315431E2 for ; Mon, 23 Oct 2023 15:01:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1834E40275; Mon, 23 Oct 2023 15:01:14 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 5215E40270; Mon, 23 Oct 2023 15:01:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698066071; x=1729602071; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=tRCoYR8HZS6MeyGOoKrWtkv/ikyGDN/dwGnTFyXlez0=; b=g3UqECt7V1vqw0iDi37kDrUcvz4CzrMDP1S8mmz3gvYKbEKpnHqPuPey j26X994cXUXG245blg8ZmzfeIvAfxfA23xpRJ91sm2UTTDKFDW6Hf20An GUNnBXtkqsiPA86PxR3We8F2WaxokKX7GsV7HyHrYWib7ybr3WpsC2qK7 OJW8O7IE7m7kdJ9mIlEMNsDm69fctQ8k/3TGLt411tcj+dN2qFfmejyS1 q2HllKZh5YXrLxqqY7WrFT2YL2hioUzULOOt6xvty1kCow7iHl4BD03xM zd8rZdUr+mSnbulMM+gyRT40dxe7J3wiXVMWfsJt4ZBNfWuylFbXwWFaO Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="384031043" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="384031043" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 06:01:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="881758346" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="881758346" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Oct 2023 06:00:48 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 23 Oct 2023 06:00:48 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 23 Oct 2023 06:00:47 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 23 Oct 2023 06:00:47 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 23 Oct 2023 06:00:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6HGMegyKsef7uUIDOqdN19mjzOwgmIztQc28cqhRyFJE4ljzIeGJxgElzQ+V/Qnia+8AHbnvRM4SjoItfBUMBDZXWWW9nBPO0aEW9YCxV8YAMXtBq8rPk0jlNFvoddwVvqAVBh+lKvAnn6p6uIFEQR+oKanNpZLiNQEVK+HAmzFme/3HGk+IlR+YqdhBCMApuy1Ho9j7jZstu5i4G/9fVdvQZeiew/iJTBne8qtDip1mpE/ezmN4u/JnjxmUX31IhMzLgHjqsmKNBiCxU1j+oyAir+IEAW0pzqbIij/2qX8uvkXo6YuhED4VMJuA3TOEUCCi1U9LmIz/4pF+sw06w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LJvnFBcyu+/7uChjUBpdWUdmn5p+ZECrTViqSDByNzs=; b=IwGGzmAVsA1LK+d47WbmwUOH7123ZtO2NLonNiGnW0BRK3igZ/usIGQ0nmjlnv7gW6Yuc1tjYsN1Ux/lr/Oy0IQTp6C7R8xOizYNJdUiY1Hz674kFMFwXkHoURWXHyVSOfg7/W2qzAkUOBBVYCHxJwXaEK2fcTZcAy3hitKn7rxGvccl99ia34l+LkNBnZoJA+XCU+L8fcqV8mQNcwwsSJRLh+4K6SkrhPobKOiEPb7bfONN2bfpYC1jQ5RXXlfuIEM4uCON2psrUBApljZud2tulZyxdMgePYfVSb72PlOtGC+6/qdzoOuJXhyLjYkfdm5Suyh9rkXw3yyz5pVxdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by DS0PR11MB7406.namprd11.prod.outlook.com (2603:10b6:8:136::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Mon, 23 Oct 2023 13:00:40 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::4f61:d541:87b4:e935]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::4f61:d541:87b4:e935%4]) with mapi id 15.20.6907.030; Mon, 23 Oct 2023 13:00:40 +0000 Date: Mon, 23 Oct 2023 14:00:33 +0100 From: Bruce Richardson To: Srikanth Yalavarthi CC: "dmitry.kozliuk@gmail.com" , Aaron Conole , Igor Russkikh , David Marchand , "dev@dpdk.org" , "Shivah Shankar Shankar Narayan Rao" , Jerin Jacob Kollanukkaran , "stable@dpdk.org" Subject: Re: [EXT] Re: [PATCH 1/1] build: update link args and includes for libarchive Message-ID: References: <20231020170135.18319-1-syalavarthi@marvell.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB6PR0301CA0089.eurprd03.prod.outlook.com (2603:10a6:6:30::36) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|DS0PR11MB7406:EE_ X-MS-Office365-Filtering-Correlation-Id: 33ff4eb3-0efb-4681-53ad-08dbd3c80ef8 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: um49d9uK3zmELkcHuuUZ1L61UUhTLXBdJWXNBnjsB75Z+3FU1erOsaiQ/BKz/72YGktfv49DOv3FbazjRX1bc4p4VobaX+1J3QcMWZCnb7vgSizRalkY6ECu/j71q+jQ9v1HpYvOJfO0SM8pm/mdHeRJRcXxNUfm9c92Owh8rL7wc7y6pORpqZv47pSugKWWwhtI7aeLlb90Cg8SSnzg9CSp8ftY0zou59Ekrw0XBSFUmaygn7foE7BSvL+DtRQSY6eagHjERAKWIKweJd7PhkN7MiLfA/sOikTp/HiuXoVEUufo9wbHoZlvAu13e8b07ARV7B9P7BJDaERJx0fCqRFrn8YDtNxFQLBPJOUCzVJ/mUMhxkjAJT0MqJeaIKKAZWRrza7NgTFNh30IgjgbRBVaz4qQ6/SrJEQne+9JUumVHfcRR05YQuSajbOTv6vJE5R2AQtfgJtm/XCHfDE5qMfKPVbYI0Yux/sb9rKTnRAmisutdA9XQq6VG4CsDttx/Bf2mnRBru5Q2qZOYhJkJ+oZuI46vEow09BOaLS6/Z0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(346002)(136003)(396003)(366004)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(26005)(38100700002)(2906002)(41300700001)(44832011)(86362001)(5660300002)(15650500001)(8676002)(4326008)(8936002)(6666004)(478600001)(6506007)(82960400001)(6916009)(316002)(66946007)(66476007)(54906003)(66556008)(83380400001)(6486002)(966005)(6512007)(53546011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3jv5tJR77LnyB0BrNKVM/LvlfjUsJ9u2NR8plHhgvypOMFG2oGJmL3YfTdI+?= =?us-ascii?Q?0ec+c6X8z4PGVW+BA54p52EovYEkrIGKDpqNU/s76rQn8f7U93Kg2QO0fbL4?= =?us-ascii?Q?l/mQLba00ZVy3psLFk198OG++LY54uLS58a6H9iIZqar2gO4iEUqVWl00tLG?= =?us-ascii?Q?y2flyOLaPXEUe+0KgQBiyRxD1ISAejl+Tv4NG8dYUtUG56i6eV61fkKclXih?= =?us-ascii?Q?0GkaBXX/lhM3aVd4802A7pYoMu3AZbLL2ksHr+PmNTJ1S9ntn/RflY3niFFy?= =?us-ascii?Q?mS/YOO1cw/fshD3SL5OqoyulZDebze296YcfbjVg+ebpeuhO+0NsSPaSYyy3?= =?us-ascii?Q?lm1cUsUtLEY+D3HkNlvOfW5KFtzAU/8lItZG0y1vv3+LF/RS7tkSY8N05/+m?= =?us-ascii?Q?Csx2j6ggrJL+iRC/84O0by2/cWw//U27bGrTGImYsvJ+Mz/yhxXP/c0RfD81?= =?us-ascii?Q?0nw6ib0tWScZucghmNuSL43CqRzQCWd63rhkegIxRaUnZxGW7ZJkT9aBL/rx?= =?us-ascii?Q?X2rPHupEdqUNPaRvvT+4Mhtj1MbtiSvWXMN6ThM4Ic6ccOJkjLfW3zhn0v5q?= =?us-ascii?Q?yJQHQRi03Wn0IJrYGy+op4h+TxQ6ukp0+LLB5ymK0XujYHGGsv7OrNeigdIG?= =?us-ascii?Q?bRCnXHLtr3pCoYoQR4BKbroRKQVs8qqbR5szJnvUF+tRGojciT1/zkdjYUcQ?= =?us-ascii?Q?CIR+c3GCkTMNwBArepbARaPH/VycVoqjlmXgl+nLjHsHiy/0TOft2qHU140o?= =?us-ascii?Q?OWhM5fSSlZc9dQnz+Hht63OAithWhCiugAYYAQNFmgCXv9e03AhTRDWllaLj?= =?us-ascii?Q?Oq5XMHnG5F4p8PBg2xMc90LYcquKpXUEiK+bOwPRZX0C0b4Ss59ObilpV01R?= =?us-ascii?Q?RflNKwJ3Wz1T09DZmm9T00k2UH9pzpRDqgVm+NNgDQAjkLlQ9LENAYArbsuW?= =?us-ascii?Q?1BTwi+dgjGDjRSfukbw9JLzRjrRMZHzCl8P28PxGklaj7+Ub9e6neYCgfDrV?= =?us-ascii?Q?j65Q9P1G4uO3/S8iR7ymOGVIzSj/LyRgRD17yxIPtCop6llUd+IX/IN9zBOA?= =?us-ascii?Q?iRlhqnOELK26OJKLbah09babG81mD2XpRF8ih1Sy1gt/PEDu8+8+JCVh9x1a?= =?us-ascii?Q?Gbr42WQGCVZVSyAq/iqaPmrKvKlRV36PNbQ8ccgBOHGj80eTObEv3ZrilvTv?= =?us-ascii?Q?zGfwOdYC581V36330N9y4LxiDrnrCfsUvmB4Be/STAm9skUPn7yXYwJR+awf?= =?us-ascii?Q?hagNwN7+I1laoGQo82mkve91jpTqu0TZcrHJA0aHfxQfMObBoCRw5vH6Y198?= =?us-ascii?Q?Z/2uT7fsuXjfwxbFcjkxNxzvUR9H4ejHEbIMgFG5nytFppqZ48q9CpWVezac?= =?us-ascii?Q?0X2PQFVgTUIeJAAisQzHAAzAx+DEuilnJe68REtZE4TY+MvFb/TWIHB1NG/G?= =?us-ascii?Q?GRKB31BZg3Z0sixY2Xmuu8+bZKhozlnsgQeqmjk65raBPqv6UsBsblqzRNUI?= =?us-ascii?Q?8qF7XdAXqYKVzV2DsHpwPj0NnUZrRSPV7edLYZ+UDJigTD6GB5TEFt73zN+K?= =?us-ascii?Q?qLlfTEPq7hR2f5j12u/R4HEOfnsnXs8v+ozsRNbb7AplQ841fPpN9dPhKpdI?= =?us-ascii?Q?Kw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 33ff4eb3-0efb-4681-53ad-08dbd3c80ef8 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 13:00:40.2708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /GCwc4YPCkwtO4jQ9zROsjhh1Q9nr0XE8uZ36Swm7ssF9gU43ksnW/ZLxDDE3TGF6F1qnie83FxGOcp03Ulw401CtKm4W3naE4W3xdvlydY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7406 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Oct 23, 2023 at 12:46:59PM +0000, Srikanth Yalavarthi wrote: > > -----Original Message----- > > From: Bruce Richardson > > Sent: 23 October 2023 17:24 > > To: Srikanth Yalavarthi > > Cc: Aaron Conole ; Igor Russkikh > > ; David Marchand ; > > dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > > ; Jerin Jacob Kollanukkaran > > ; stable@dpdk.org > > Subject: Re: [EXT] Re: [PATCH 1/1] build: update link args and includes for > > libarchive > > > > On Mon, Oct 23, 2023 at 11:40:14AM +0000, Srikanth Yalavarthi wrote: > > > > -----Original Message----- > > > > From: Bruce Richardson > > > > Sent: 23 October 2023 14:56 > > > > To: Srikanth Yalavarthi > > > > Cc: Aaron Conole ; Igor Russkikh > > > > ; David Marchand > > ; > > > > dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > > > > ; Jerin Jacob Kollanukkaran > > > > ; stable@dpdk.org > > > > Subject: [EXT] Re: [PATCH 1/1] build: update link args and includes > > > > for libarchive > > > > > > > > External Email > > > > > > > > -------------------------------------------------------------------- > > > > -- On Fri, Oct 20, 2023 at 10:01:35AM -0700, Srikanth Yalavarthi > > > > wrote: > > > > > In order to avoid linking with all libraries listed as > > > > > Libs.private in libarchive.pc, libarchive is not added to ext_deps during > > meson setup. > > > > > > > > > > Since libarchive is not added to ext_deps, cross-compilation or > > > > > native compilation with libarchive installed in non-standard > > > > > location fails with errors related to "cannot find -larchive" > > > > > or "archive.h: No such file or directory". In order to fix the > > > > > build failures, user is required to define the 'c_args' and 'c_link_args' > > > > > with '-I' and '-L'. > > > > > > > > > > This patch updates meson build files to add libarchive's > > > > > includedir and libdir to compiler flags and would not require > > > > > setting c_args and c_link_args externally. > > > > > > > > > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Srikanth Yalavarthi > > > > > --- > > > > > > > > Checking back through the mail archives I'm still a little unclear > > > > as to what breaks when we try using libarchive as any other package > > > > with a pkg-config file? I would have thought the best solution was > > > > just to add libarchive as an external dependency, found using > > > > pkg-config, to EAL. When we add it as a dependency, rather than > > > > using c/ldflags, we should get all this path fixup for free? > > > > Can you clarify what breaks when we add libarchive as a libeal > > > > dependency only? > > > > > > Below is my observation. > > > > > > In current implementation, we are looking for libarchive's availability > > through pkg-config. > > > When found, we are setting RTE_HAS_LIBARCHIVE=1 and adding '-larchive' > > to ldflags. > > > > > > Since, we are not adding libarchive to ext_deps (to avoid linking with > > > deps.private), the > > > > This is the bit I'm a bit stuck on. What is the issues with adding libarchive to > > ext_deps? For other libs, when doing static builds we have to link with > > deps.private and it's the correct behaviour AFAIK. Not doing so would surely > > lead to problematic builds, no? > > I agree on adding to ext_deps as it's the correct behaviour. > > However, there was a discussion in mail archives regarding this. > https://inbox.dpdk.org/dev/20210605004024.660267a1@sovereign/ > > Adding Dmitry Kozlyuk for comments. > Testing it out myself, the sample applications don't build statically due to missing dependencies. The libarchive-dev package on Ubuntu, doesn't seem to install all dependent packages for static builds. I had to manually install liblz4-dev and libacl1-dev packages, and then test-meson-builds ran successfully. Personally, it looks to me like a packaging issue, in that I would expect the -dev package to install all required dependent dev packages. I also think using the pkgconfig as a regular dependency is the way we should look to go, and if necessary, document the list of extra dependencies needed for libarchive in our docs. /Bruce