From: Bruce Richardson <bruce.richardson@intel.com>
To: Abdullah Sevincer <abdullah.sevincer@intel.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>,
<mike.ximing.chen@intel.com>, <thomas@monjalon.net>,
<stable@dpdk.org>
Subject: Re: [PATCH v4] event/dlb2: fix disable PASID
Date: Fri, 3 Nov 2023 17:18:37 +0000 [thread overview]
Message-ID: <ZUUrbW23eEOwAj4g@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20231103171436.2791832-1-abdullah.sevincer@intel.com>
On Fri, Nov 03, 2023 at 12:14:36PM -0500, Abdullah Sevincer wrote:
> In vfio-pci driver when PASID is enabled by default
> DLB hardware puts DLB in SIOV mode. This breaks
> DLB PF-PMD mode. For DLB PF-PMD mode to function properly
> PASID needs to be disabled.
>
> In this commit this issue is addressed and PASID is disabled
> by writing a zero to PASID control register.
>
> Fixes: 5433956d5185 ("event/dlb2: add eventdev probe")
> Cc: stable@dpdk.org
>
> Signed-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>
You are probably better to send this as part of a patchset with the patch
to add the disable to bus_pci, since the two patches are linked. Also, if
you want this to be backported - since you CC stable - you also need the
pre-requisite patch to be backported too. Therefore, CC both to
stable@dpdk.org.
/Bruce
> ---
> drivers/event/dlb2/pf/dlb2_main.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/event/dlb2/pf/dlb2_main.c b/drivers/event/dlb2/pf/dlb2_main.c
> index aa03e4c311..63a18df71c 100644
> --- a/drivers/event/dlb2/pf/dlb2_main.c
> +++ b/drivers/event/dlb2/pf/dlb2_main.c
> @@ -514,6 +514,16 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev)
> }
> }
>
> + /* Disable PASID incase it is enabled by default, which
> + * breaks the DLB if enabled.
> + */
> + off = RTE_PCI_PASID_CAP_OFFSET + RTE_PCI_PASID_CTRL;
> + if (rte_pci_set_pasid(pdev, off, false)) {
> + DLB2_LOG_ERR("[%s()] failed to write the pcie config space at offset %d\n",
> + __func__, (int)off);
> + return -1;
> + }
> +
> return 0;
> }
>
> --
> 2.25.1
>
prev parent reply other threads:[~2023-11-03 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 17:14 Abdullah Sevincer
2023-11-03 17:18 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUUrbW23eEOwAj4g@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=abdullah.sevincer@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mike.ximing.chen@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).