From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABF9743382 for ; Wed, 22 Nov 2023 17:41:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0CE741132; Wed, 22 Nov 2023 17:41:21 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 515704028C; Wed, 22 Nov 2023 17:41:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700671278; x=1732207278; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=lf9adC9F2b58d+tBBjzWwGyiqHqv8LXVSarlOwkTkyo=; b=F+0Vonso+DDOGzfNvhm1/5t5Hx32d9qfmXvFUGYzl14d2/wv5ojnek4f kN9dM2DREsoCsF7u2ldbUf1lCJ6FVz5plwLDrfvjaKsbh8G4UZV4NnIkS fSVYojQPdyM1yEgPeP47id4E++ixRXXs1j2InndJ9N42zR0sxz8QI1W4J K1U5iHcn7DxYJBJpmtOBkz4tOddBSlEIS6m1R0oXJg84gEmnluYCr4O2L uagW3LY7kTz0iSa+LyVY+TdeDobwXcvJdfJ5u2g5hQf7U4wDpaZ72QbqZ LuYmlBx/cOmSh0TRfuznMtkAQA5tUx1V8W/pFTOo9cqRLJb4BRqs49AyR A==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="382497085" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="382497085" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 08:41:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="770685782" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="770685782" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 08:41:16 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 08:41:16 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 08:41:16 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 08:41:16 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 08:41:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jrGZRJs9ZLCTkOfkc4Xvj+v5HHwokRKkpLo7C/FgZdSazAPlZVV5UGB5Rcx2ZviZENAB7IrdR7Lh+pgn9c7nGrdUXy1C2l3UhuYiJ3g4Hrq+hF51/D3N5fMZQaZwbjk8/SYLIdC0Hzmfaeclzn7vHQS9ZJHDM9eeCnL66btPNRGvbtTjLUBnurPdLXGt2jc0yxCTY3aTAcLLmm8s5LRW0/31zdEtVasiJDlTstatyi+mxh0yUZs7UwgTr1RcIv3K1QuUNOhAtyH1CS9gP0QrcDk4+gX6sJfVe1odw9zkkDaH/Fk701DHe14eqcg+VKtH3DWqdqcrlb/mvNuFOBx23A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D/h0WXH9X5c6zMMfQru2X0jpm/ii1hOOeDaqWLUyQFQ=; b=B1IdtRnoAOVw/5ClosiavMbk3wtTiwSEKqw1/6jDmGF7IdKmJcKkGWNu1/CYeYT5zU5Gu1nRr8iJxVHzez+CVNAQ4YR52eiPL3elhhR5ENUqJueHH43+NbB+jo7YUkLlFc3KKmuIfWqSV+GR7VjjvTthwpzepw6PvAetVxgDfOEX3i+7zttKwtn/Cr47hvgnA3lOU4dn3tCxuweC9FE43SK+sBrrjD8rEjboAOeMp5duo4PWHTmSsTER9YMTHD48gK1izR1et712T5O+D7y66S1pcy4EqzCGLDcxvd//x0GATU/LJmmrj3SBqWJI7dC1EPL5bIEaX6H/qFFyxuIThQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6929.namprd11.prod.outlook.com (2603:10b6:510:204::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Wed, 22 Nov 2023 16:41:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::4782:d54a:209d:cb49%7]) with mapi id 15.20.7002.028; Wed, 22 Nov 2023 16:41:10 +0000 Date: Wed, 22 Nov 2023 16:41:04 +0000 From: Bruce Richardson To: David Marchand CC: , Tyler Retzlaff , , , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH] eal/windows: fix mingw build Message-ID: References: <20231122163228.986037-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU7PR01CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:10:50f::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6929:EE_ X-MS-Office365-Filtering-Correlation-Id: a26ae7e6-55f0-4441-4c96-08dbeb79d54a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vA00AYL8q99FLLhWrfUBR2w8/bKQntXo19CcZpzy7cyYX6CnRYySryidSHtWoi/9Xfm6j5pLYJ+JC9mry8E5icOiIK1pRu+xE8VMYbmn5cQFmONW0BH8qZMpeoNDNDsb8je/eJDlwEOBpDUSLPrF3gBFF4UXMmDtTDhRos7reL3stG0KLAPxj8XIQ1YMx6ypwmQVdUe/+B76Ft54NHmpP/jf7E1lCy6Ubshr39GpYXCe9T7Sumxk4tmvbBQ3WZMY2z85iq1VEbkU+4BRrl1/JPedhFHP2LF41H4+9m7D5sQ1hyxvMPe7xtSlOBuzc8l12DV3pQBa1obn6qRAQgFV0tOOSZqm6yudxOKmIv0q8gtqaz1xtI1vTbGpFMYwqt0g6wdbVXjbTzERspcUi5wy+jQ0D4UqILY85L+1neDIzxRqHNvFrivVx7lhWGQ77yG+tTGHH54wI49hjJ/CwgTaJCutd8COHQr5Kn9cwLPLHMnZx9+IRxwSi/fAbx0cBhev0pnjHgKokCax/8UXnnfbwaZOJWJN/HJXABdbHFnMoxQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(376002)(366004)(136003)(39860400002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(6512007)(478600001)(83380400001)(966005)(6486002)(6506007)(107886003)(6666004)(53546011)(54906003)(26005)(66946007)(66556008)(6916009)(316002)(66476007)(82960400001)(86362001)(44832011)(2906002)(41300700001)(5660300002)(38100700002)(8676002)(4326008)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aStKTmoxcTlDT1l5TUQrbWpQdlZBU3FqWENTRVkxSHN4c3QrcitELzlWT1Jk?= =?utf-8?B?Ly9WR210aHlaNHlyM1ZKOWFXamRQaUQ4UmRhM1VjV25qMVE4MXJKdVpzemtz?= =?utf-8?B?KzdZbnhqQm5oeUo2OGlCTHloRnZ5K1dld2NheTBYK3RaSUoyK3N3dXJGU3Ay?= =?utf-8?B?TTNSZWprdHNXSWpaRkFFOVI5WFN2OW13VFpKclN6SmxtMnlhelJnNU5TWU8w?= =?utf-8?B?WUtNYXZ1RDBBRFYwK0NjY3BhcllKU2haZERMNVFHQi91OUR2NE02RzVCWlpv?= =?utf-8?B?UE9XK1FLYWJwUUpzcFFzaWswakcvTnZ6elJhNVUwbitOK0praXBjTXBQS3Vm?= =?utf-8?B?MWdrTUNNallrOWU1aUozbXhoTlY4MW5udHZmaFNPcG94MnVJYXRmUng4M3g3?= =?utf-8?B?WkJpRG9DWU1NMVBYZTcvMkV2dFd2OUdQSlpGUG9MLzZ0V2FyNVhjMTVJYS84?= =?utf-8?B?MFdHYWVvb3R5OEMvQ0NhakY1NFlIUFpNdzRIdzgrY1RwSFAreWxMMXlIbWx4?= =?utf-8?B?ZUtnOGZET01BWkI3M1pzS3k0OTFhdTNkdjNHTFZlTnlQbnFRVTZUcFpmODNS?= =?utf-8?B?blFrOXhZbGxFQWR1QmFjOGFkUEtINWVZN2d1bS9MNzQySnZLR2NFRFBYWWZE?= =?utf-8?B?TDlDdCtucDN3V25zNjkxbWlSQ0lPY3JKaHdVQURaTkFwejNESngvSjNYTDVO?= =?utf-8?B?NE5RRlBuTVFUSjdrcUw0c0ErL2REbGcwUzVaTUxwdFRpVnN0WmovcmhjaTJQ?= =?utf-8?B?cU5KYUpNejJXaFNrcDJaWCtyME4vWVppZzZhaFZ1clhWaXV5VFJQQURoN09L?= =?utf-8?B?VnllK052SzJMS0pNeGF1VW1KWHV0ditSWExpK2NsV1hvSWxPUjhlY3kxcFgr?= =?utf-8?B?Y0RBc3hQdUxYOGFpeDZjUDF0blVXMWhabEF4OTJHU1VwVmdtRitNejZqc2R5?= =?utf-8?B?SndOK2oyQjZTT1ZpSkc3Um1xbTNWb0FaaEVEMERIYWFrQmNHK1BWOGNZdGZu?= =?utf-8?B?dHhxWjMrcWMrNWhnT3Zia1l4NytaL2Z3bW9COHNvT1FaelpPL1F6N0d1cUdm?= =?utf-8?B?ZVU2VnpFOUhSV0xLdFE0b3V4UW1LUk5SV2JweE9uNDljbitId2piNkNaZ25Z?= =?utf-8?B?RTNHWVhKckMwSGJpTXpESmMzUEIxWUF5VE1CMHpWajRIZ2grWEFnRTdicWpn?= =?utf-8?B?eDFXSlEyOVNLczZvaWZ2Um9TRExGaDVlN3RHS3Y3M2lmb2hWWjgrb29sKzUx?= =?utf-8?B?K1R4c2RDSmVyL1ZxSXVzVWVwQitERnRHcG9LUEo4blFjMWxYN2VsYWxVcGpE?= =?utf-8?B?OHpRY2U2NGsrcVgzQzZQSjRjdW01UHoxb0Z3cDRReW5lSytUaDAzd1FLcy9D?= =?utf-8?B?ajF0Q2hXbXVaT1l1MnBkVGR4Y2toZDFGalY0czEycUo0SzVORTZkUmhBelRH?= =?utf-8?B?cUVVUXdoaVZnKzVQNWRFNmYxZkN6WHJ6ZkJtUFcxT0FTUjkrekZ4WldObTNp?= =?utf-8?B?bVhoTDRaMFNKYjBwemVxZjJVWGYvZkdzTk5EMFNGNWQ4VENscitOWGR4VzYv?= =?utf-8?B?dFY4d3dzQnAyeExOdUxFbzZyVFppc01mWWF1N250VXdGSE1SZUpRYVNqdjFz?= =?utf-8?B?YTZEWmlwZFNHSlAveTVKcSs3M1EyVlNlZ2NidUdaZ0wyNXU1MUFOU3gyejhp?= =?utf-8?B?dktDRzVqZ2ZNalhmNEtXUERiRlREbHE5VUVRV2MyTGY1YXFtUDRHWm8zZDVo?= =?utf-8?B?WHYzZDVjRUVhRnVSU1BkWGtLTnpaMjhZcDZvWWpQYWU2bFZBYVloV3J5QU9z?= =?utf-8?B?K29HRi9rSjVuVkg3dmVjOGpPRlRTTWphQlpaZUE4TE5zODhQVUdsNWVXc0x4?= =?utf-8?B?ZWhxb1h1ckJ0REpHSU1xV25Xb1VlOTEzNmJXQUV2d0NIWVF4Z3VFOFAxcVhP?= =?utf-8?B?UksxbXo3YjhuVjJYeVNOa1d0eS9JMUFad3VMeDRObjJpd2RzRHZvcjlOVnZl?= =?utf-8?B?TDBrRU10OEtPNG5VOGJQTWN6VVJpRndhS2piTHV6OUh5TXpiSUpHaVJwb3Vy?= =?utf-8?B?VDhKTmpsTER3SnNKeHQrYWxPRDRzVkhCUUZWSlBFL1U3RGlvWUJFemF5TVQ3?= =?utf-8?B?UmVKM2k2MUpneXFTY2VKb1h1NWdmWEZ5clR6SmNzT2NsbFdpaU1SQVdRcHBH?= =?utf-8?B?bmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a26ae7e6-55f0-4441-4c96-08dbeb79d54a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 16:41:10.8051 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f/2ABUqsil9YJgX6E0k3cV9p8AKZsT6zDSbCZCK+SrrwCyaFWroNcccz2wifrYHyGRlKellJGgiBDbxVjRCQI5OvdqNv4lPD2WtocgohP9I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6929 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Nov 22, 2023 at 05:36:44PM +0100, David Marchand wrote: > On Wed, Nov 22, 2023 at 5:32 PM Bruce Richardson > wrote: > > > > When compiling with mingw on Ubuntu 23.10, I get the following compiler > > error: > > > > ../../lib/eal/windows/eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined [-Werror] > > 77 | #define MEM_REPLACE_PLACEHOLDER 0x00004000 > > | > > In file included from /usr/share/mingw-w64/include/minwindef.h:163, > > from /usr/share/mingw-w64/include/windef.h:9, > > from /usr/share/mingw-w64/include/windows.h:69, > > from ../../lib/eal/windows/include/rte_windows.h:32, > > from ../../lib/eal/windows/include/rte_os_shim.h:9, > > from ../../lib/eal/common/eal_internal_cfg.h:14, > > from ../../lib/eal/windows/eal_memory.c:11: > > /usr/share/mingw-w64/include/winnt.h:5710: note: this is the location of the previous definition > > 5710 | #define MEM_REPLACE_PLACEHOLDER 0x4000 > > > > and a similar error for MEM_RESERVE_PLACEHOLDER. These errors can be > > fixed by wrapping the two defines in #ifndef .. #endif blocks. > > > > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management") > > Cc: dmitry.kozliuk@gmail.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > > Probably a duplicate of > https://patchwork.dpdk.org/project/dpdk/patch/20231114170529.176665-1-getelson@nvidia.com/ > Yep, duplicate. I'll reject my patch in patchwork. Hopefully the patch above will be merged soon to make this issue go away! :-) /Bruce