From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>,
Jingjing Wu <jingjing.wu@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
"Qiming Yang" <qiming.yang@intel.com>
Subject: Re: [PATCH] net/iavf: remove error logs for vlan offloading
Date: Tue, 6 Feb 2024 10:03:01 +0000 [thread overview]
Message-ID: <ZcID1bWjdGaz-xFG@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20240206095607.339410-1-david.marchand@redhat.com>
On Tue, Feb 06, 2024 at 10:56:07AM +0100, David Marchand wrote:
> This was reported by RH QE.
>
> When a vlan is enforced on a VF via an administrative configuration on
> the PF side, the net/iavf driver logs two error messages.
> Those error messages have no consequence on the rest of the port
> initialisation and packet processing works fine.
>
> [root@toto ~] # ip l set enp94s0 vf 0 vlan 2
> [root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i
> ...
> Configuring Port 0 (socket 0)
> iavf_dev_init_vlan(): Failed to update vlan offload
> iavf_dev_configure(): configure VLAN failed: -95
> iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set
> rx_pkt_burst as legacy for all queues
>
> The first change is to remove the error log in iavf_dev_init_vlan().
> This log is unneeded since all error path are covered by a dedicated log
> message already.
>
> Then, in iavf_dev_init_vlan(), requesting all possible VLAN offloading
> must not trigger an ERROR level log message. This is simply confusing,
> as the application may not have requested such vlan offloading.
> The reason why the driver requests all offloading is unclear so keep it
> as is. Instead, rephrase the log message and lower its level to INFO.
>
> Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
One small suggestion inline below.
> ---
> drivers/net/iavf/iavf_ethdev.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 1fb876e827..fc92cdf146 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -631,7 +631,7 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev)
> RTE_ETH_VLAN_FILTER_MASK |
> RTE_ETH_VLAN_EXTEND_MASK);
> if (err) {
> - PMD_DRV_LOG(ERR, "Failed to update vlan offload");
> + PMD_DRV_LOG(INFO, "There is no support or the PF refused VLAN offloading");
Minor nit, the phrase "no support" seems ambiguous on first reading, since
it's not completely clear that the no support refers to vlan offloading.
How about:
"VLAN offloading is not supported, or offloading was refused by the PF"
> return err;
> }
>
> @@ -707,9 +707,7 @@ iavf_dev_configure(struct rte_eth_dev *dev)
> vf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT;
> }
>
> - ret = iavf_dev_init_vlan(dev);
> - if (ret)
> - PMD_DRV_LOG(ERR, "configure VLAN failed: %d", ret);
> + iavf_dev_init_vlan(dev);
>
> if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) {
> if (iavf_init_rss(ad) != 0) {
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-02-06 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 9:56 David Marchand
2024-02-06 10:03 ` Bruce Richardson [this message]
2024-02-06 10:20 ` David Marchand
2024-02-06 10:34 ` [PATCH v2] " David Marchand
[not found] ` <CAJgakAfnFE79PtTFx1RRKpUkTDbcP_O22VfL5Gw5tZqW9Dcs5A@mail.gmail.com>
2024-02-06 12:46 ` David Marchand
2024-02-06 12:47 ` David Marchand
2024-02-29 11:54 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcID1bWjdGaz-xFG@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).