From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74D0F43C35 for ; Thu, 29 Feb 2024 12:49:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB36402AF; Thu, 29 Feb 2024 12:49:30 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mails.dpdk.org (Postfix) with ESMTP id 69241402AE; Thu, 29 Feb 2024 12:49:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709207369; x=1740743369; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=WU4Ga2Lur4N9E6kcbgqkDcsVFOJqRVYz7jX6DpL0El0=; b=FwytRJ27RCAHTstlrqW/P7z4ARTc/BGakkBnC1vJkFEiyB+aXCkFv1ri N6EblyKk3tzT0OiUkXigHl4b7NspuGTNlPIrLMMViTCijsqEdMamez3By 7MYw2zygxldx1bWyqu17Cn4BHeQThTS8hCQaM3uHaUo7tuVznSS/KFsV7 clTi7mFgqd3NElkP1j+61JMK0hHiaouSD0uoo3zPGTavAXfzn1TehHtR0 hiqNY4axnso7dNuhPK0rW03SWplwdRIbf9Ze3v/a7OHKCH6W13IVDZsWq RN+cnp7p2vsOvwcBS4gy6+EGxbMBbKPmIk719u1/SPaRG5mk2dDt9D59d A==; X-IronPort-AV: E=McAfee;i="6600,9927,10998"; a="7491920" X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="7491920" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Feb 2024 03:49:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,194,1705392000"; d="scan'208";a="45318375" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Feb 2024 03:49:28 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 29 Feb 2024 03:49:26 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 29 Feb 2024 03:49:26 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 29 Feb 2024 03:49:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRprl6P6JJ1vtUWRVqueWy9lca6yzJv3cd+WYS1WfL9u6cjBE6YZxkI6VaIpr1sZ/AHjOfmUDQ0z8+TXLLKap5/fL1GtPmraD0zIm3Zuz50w2VcTGZVamb4/aOsqKp6z8sN/3ViYG4KtQm8ah4EDb5y/nwBloUXJqZ2kg+EoOdtGeYyy2t8eZ3QKMrvSd9tWky/3tIDTefhhK3X+2ApNSVwfRaH2SyUooB8f0aJY9GlGh67v0FyhvGYK42LSTBw9aE10y8UJtwyQGiW+fOWSfpZ9Uz0MDI05XEre4E7Irkhds4K0DOV7NVZ7yzZ3k0TJx9PGld+MJJTEVE3WQGboQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9qSCjYnLAX+nmz1Ll/0I3jOq8uqAeHP6NueV/+bsu60=; b=SzqqaTuD7s6BSoNXQkscQhI1hsn3U15dZvfGnbTqpaFQOjZ39vX+zDxJfLX2lrzjEhVuhMkOi9xwxy0RIFGAgT8xxFiC3ATJ8DsFu740U17VPDVQVmD7TJm76Zg0jOyNAHzUGxa/j9vlUlqcAiOKKyIEGMXbNyHVdBlPHjrtVZFCk5hC5++zCkDcB0BlTOPi9oYa1ZPv2UvMWZaKN2PMrvwpsMQfy6hWqsgFlrkDRoR0JTA2trjiFwzKHE1HLPg6HY7It8WKPVcCzxZR/RMAvKM+C5xXC2qv4lHKgLxLB67+Wt0MSJpmiJ/2uAp9o3JnohgrXXeYZL8qhf6PMhDZ1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW5PR11MB5858.namprd11.prod.outlook.com (2603:10b6:303:193::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.26; Thu, 29 Feb 2024 11:49:24 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7339.024; Thu, 29 Feb 2024 11:49:24 +0000 Date: Thu, 29 Feb 2024 11:49:18 +0000 From: Bruce Richardson To: "Medvedkin, Vladimir" CC: , , , Subject: Re: [PATCH] net/ixgbevf: fix RSS init for x550 nics Message-ID: References: <20240215133145.181302-1-edwin.brossette@6wind.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB9PR06CA0011.eurprd06.prod.outlook.com (2603:10a6:10:1db::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW5PR11MB5858:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d1947ae-145a-4026-3dd2-08dc391c7958 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zGpZDlbfe3IG7asbcPDmD+/+fd5H8usJ7T/i/hxmsoDp1tEObPCtr/mw6qyimTL3jF/RH0iUvefvIY8nb2pQt5nARfOxYG1fpn4EPw9mlk5bUupSYl66zhLHsSQlHhStWjqRSFwmC6Y4LAsH/NSAx586HBee1CGC5IQRkgiQYJXCGoAEDlzXbIRmwMMDw7uWEv6KspwX4lJEF4xrDr8/7hjloIioDSPP3Ia9BGxMxYjms5r9tfnFTRcQed2fi2YK4ZC7VBUJCeaWFycr+EdxYaLkOK9ekJ6JQLmFhk4AE8wuSYBTmyR+11n8dss0WHzpTi7uTUiRx+rlguR4txAkD5tuc5sMh8XLPbCk1GkFZjkHRWpBWy/dcwd+rfwB4hFLwKeLZG3XOWrutx5CaH7Q0/DVX9MTzL4m1T28Hdr0CY+/q3wUkAgdoJKNPue0uwCyxEnzsPwq/vpg6arUwHzNV+B9Qb57H0LqmHtBsjiexD4jXjFzdAdrdAuydgWy9ZbLYQ/YmIdLEOo0v8g5xoCtc8y6i7F3UPsstO0GgfV4+6xDBbc//u1rzB+AZ1s5zxEnBC1sCm49s7tQCYCxVtUNyaWoqjqhzulO27m1qxoU5h2vLFWnjj4OQuqm4eCmVvKvF9mGznTtuhwdmPYrNHr96w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uUibtNEwljeHfQwqjAoFmmxHfvD+8AW+A4URH0ZvvS/2P8h8vum78PRYhH//?= =?us-ascii?Q?yGspZrGVw6aD/CR058qjUSjw4T2v+eWcSk3KlRhRVBwO0ecKXO6CnQ3GoC5Q?= =?us-ascii?Q?tLykg1lfdGpCGs4vVLO06TXnsHjg5VQyUf8L7gVcubESO/61A2KPF7wuePQr?= =?us-ascii?Q?TffQMnyi1TlZBqgHKkgldYfrW8pTwUakwOrNk6tDTcGUUSKyJ3QmmddA2RAE?= =?us-ascii?Q?tEiz3wSLjfYmKFORa7NtVwgKVCQaoZUW+yzXd+N2YizD4WKYHHm08OZhY/PD?= =?us-ascii?Q?Wplo8fPiW96Ckx0nJwcnZ6TznsKHuzWbiqon9Nc4cPrnBjoxfPOvnbqDap9n?= =?us-ascii?Q?ZaxaIucq47NfnLbvuRel4bp+FY+rcejOYMYnXTj8YUk61Q7YpO0n3wIZLqAV?= =?us-ascii?Q?SFxCmQRA0KqKtMZLYtUoUaw0RTtoMML86O3RV2ec2TUQbpeMoAU74dhNERS4?= =?us-ascii?Q?OMeQRbxz1VBk5fy3g1z9zlXLwO/dO/JMTagdp9BW3M+OemoQbzlJWlKdTNkW?= =?us-ascii?Q?u4YMtWPoH1r1KFA3uADWG9Jprx+c3QgsTVW1MT8pxGqorFs4UT/6/ta2nGPd?= =?us-ascii?Q?PCgNDZGsrje043NGI07KuGQUv6P9Qfo6fl7jl+6Kx+kyoV0jCYKoBtXdVmlQ?= =?us-ascii?Q?htqO1moZ5wu0dfV0OggPZEtlub14T7qDdPzxSwCHh/CHMnKJWCDvK+Od+8s/?= =?us-ascii?Q?ebYaCtPsEZ45Lp7qySwHhZQZW0QO9+PpeLOpqX1rY5XUGhfLBH6/W1xJ6jPi?= =?us-ascii?Q?ljOu/jo89CUUje1jGYdkKwStyekYQ1K0/+gmI6teu4puILFbK1PTZkzrREsY?= =?us-ascii?Q?AZt74ZwKPE7/LNeLxCaAUfhRlwQ7PkWnsQ89f4io4/nZmt7x3dvyZuzzjnHl?= =?us-ascii?Q?jL0kHMBQHgAlZx+8PzeSyXIfTKvSg0pNDWOErSRKp1Y0AFZsk+gPwyOYGqVS?= =?us-ascii?Q?0Mgt3rnczAP0j2argX6/J/h5uHwC49e1hOP5WMFcy+J/sYLWO1G1wKGW260W?= =?us-ascii?Q?4sMxu3eSCoafazdV7ImbCbuGgatCHOuN4FrZBxFquGWemE2HfdPwEOgQBChk?= =?us-ascii?Q?X5TI8h5lrfM5Y5DR4+GBAn79x8ldLjZz1/q2tG+J868YjSZshDa9OrGLakgQ?= =?us-ascii?Q?jtRt1jRYNMi6OBNdFjauHzbuBH18pUfFgylKsUqalOhDzXz6E9H9dOQKqeH7?= =?us-ascii?Q?bU6sZiIq+COUdvLxlIsAFGp8GhsUVrZpIiVy8JQqGoQD7/LzMlscCp66Fav2?= =?us-ascii?Q?IMKi3D6rEdVtn2uyMeX9RVsiAJxDcma/TVlwwVjkzoLtsASnHMngxIRzcIp5?= =?us-ascii?Q?lf6JxqqdbJ3tZZZ0fARlk0o/g4J4P78koWKsYvkRCj1ftABa0JJDgLdXamap?= =?us-ascii?Q?fYfocGmfEXNYsdQaYxmWCOUcB6Z+PsfCcrkcJPL0d8rwLbPWvX7MFs3V4dAv?= =?us-ascii?Q?lUcvGuHCB/W3HFgezdq8S7YiiZAXNLBwmEe+2339oOSpgifrhxDLPWQJmJNE?= =?us-ascii?Q?iBkx+AJnl9lYhdELH2rd9Feq+pnFwXY8S1h9Si0VjUHOQpO0TX2ZETtwtVdL?= =?us-ascii?Q?BERwGsF9E6Rq1xmXLDbgxBjhOJfXvaG3Spm1aAqT2GbdP3v53QLdS0kgJcv2?= =?us-ascii?Q?Pg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7d1947ae-145a-4026-3dd2-08dc391c7958 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 11:49:23.9834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BQ2lWKBsWH0uHa38oJ7vAIwQAlIXVQVshJ0RAnqVkhX1nqbz6biB7YOjqFz7fBRk2IlGZRvLbs3YdZfPP+g0b2MALWfJcgwaByLM3KNr67A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5858 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Feb 27, 2024 at 05:26:06PM +0000, Medvedkin, Vladimir wrote: > > On 15/02/2024 13:31, edwin.brossette@6wind.com wrote: > > From: Edwin Brossette > > > > Different Intel nics with the igxbe pmd do not handle RSS in the same > > way when working with virtualization. While some nics like Intel 82599ES > > only have a single RSS table in the device and leave all rss features to > > be handled by the pf, some other nics like x550 let the vf handle RSS > > features. This can lead to different behavior when rss is enabled > > depending on the model of nic used. > > > > In particular, it occurred that ixgbevf_dev_rx_init() do not initiate > > rss parameters at device init, even if the multi-queue mode option is > > set in the device configuration (ie: RTE_ETH_MQ_RX_RSS is set). Note > > that this issue went unnoticed until now, probably because some nics do > > not really have support for RSS in virtualization mode. > > > > Thus, depending on the nic used, we can we find ourselves in a situation > > where RSS is not configured despite being enabled. This will cause > > serious performance issues because the RSS reta will be fully zeroed, > > causing all packets to go only in the first queue and leaving all the > > others empty. > > > > By looking at ixgbe_reta_size_get(), we can see that only X550 nic > > models have a non zero reta size set in vf mode. Thus add a call to > > ixgbe_rss_configure() for these cards in ixgbevf_dev_rx_init() if the > > option to enable RSS is set. > > > > Fixes: f4d1598ee14f ("ixgbevf: support RSS config on x550") + Cc: stable@dpdk.org > > Signed-off-by: Edwin Brossette > > --- > Acked-by: Vladimir Medvedkin > Applied to next-net-intel tree. Thanks, /Bruce