* [PATCH v2] net/ice: fix null pointer dereferences
[not found] <20240301052029.543989-1-wenwux.ma@intel.com>
@ 2024-03-04 5:37 ` Wenwu Ma
2024-03-04 10:00 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Wenwu Ma @ 2024-03-04 5:37 UTC (permalink / raw)
To: dev; +Cc: songx.jiale, Wenwu Ma, stable
This patch fixes two null pointer dereferences detected by
coverity scan.
Coverity issue: 414096
Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config")
Cc: stable@dpdk.org
Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
---
v2:
- deleting rather than modifying the prints that
cause null pointer dereferences
---
drivers/net/ice/ice_tm.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c
index fbab0b8808..17f0ca0ce0 100644
--- a/drivers/net/ice/ice_tm.c
+++ b/drivers/net/ice/ice_tm.c
@@ -615,10 +615,8 @@ static int ice_set_node_rate(struct ice_hw *hw,
sched_node,
ICE_MAX_BW,
rate);
- if (status) {
- PMD_DRV_LOG(ERR, "Failed to set max bandwidth for node %u", tm_node->id);
+ if (status)
return -EINVAL;
- }
if (reset || committed == 0)
rate = ICE_SCHED_DFLT_BW;
@@ -629,10 +627,8 @@ static int ice_set_node_rate(struct ice_hw *hw,
sched_node,
ICE_MIN_BW,
rate);
- if (status) {
- PMD_DRV_LOG(ERR, "Failed to set min bandwidth for node %u", tm_node->id);
+ if (status)
return -EINVAL;
- }
return 0;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net/ice: fix null pointer dereferences
2024-03-04 5:37 ` [PATCH v2] net/ice: fix null pointer dereferences Wenwu Ma
@ 2024-03-04 10:00 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2024-03-04 10:00 UTC (permalink / raw)
To: Wenwu Ma; +Cc: dev, songx.jiale, stable
On Mon, Mar 04, 2024 at 01:37:51PM +0800, Wenwu Ma wrote:
> This patch fixes two null pointer dereferences detected by
> coverity scan.
>
> Coverity issue: 414096
> Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel with expanded commit log message.
thanks,
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-04 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240301052029.543989-1-wenwux.ma@intel.com>
2024-03-04 5:37 ` [PATCH v2] net/ice: fix null pointer dereferences Wenwu Ma
2024-03-04 10:00 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).