From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4894243B7C for ; Mon, 4 Mar 2024 11:00:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42CFE40DCB; Mon, 4 Mar 2024 11:00:45 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 2892640271; Mon, 4 Mar 2024 11:00:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709546443; x=1741082443; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=swu+ntznaVnnW89TKnDVTXBjfV7ic84CFpb2P6+mEAY=; b=m20TRxb9/5kSEqao5KJ7evhYvgWd6TNL1xwNlou9BoQwq6vmP3f1w2Vc 5h2V55VYMwdq9pXW2EyHfUmaywmP90ayyN2yMW0ctqWH0gns/QaAPBzt8 9QJW38NCD060hZPpeOW3u9D3jTNB14L+YKnA2ubtbF/H4w2xugW6tLY4s 0jb9KuwUXSpLKpOSLbLL7NPZ+dPGTynmv7+vM1Biiy7U5HsCOI6PCZJzf f5QvtVv/gZGm5pCbvHlc7/C9bzzZ2mb4cxIgExIr2b/+1MRRUYgFK+AaN yzqU8eF2mBuT00e4YuLACD+Mx1QmQ2zr0RSSds8YB/A99KzsIZvNpL9nC Q==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="7799663" X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="7799663" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 02:00:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="39800549" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Mar 2024 02:00:39 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Mar 2024 02:00:39 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 4 Mar 2024 02:00:39 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 4 Mar 2024 02:00:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d0n6/cYuiNHdmadrBosH306Bm70xlqDKj0MmhWEzSLhICsyZlMxHytN8AppGuuU04Q4TP5uHWGjn2Ek0aRSa4ktH5ErYy6oNAx/5+Yu1npocqrw7e6S3ekWZ8P+5ZSe+hAiJRh/hQbUpCABahcJ7DD3BZZh9GRpxHT4dwhJyvJID3uGART0sZiVeB67Eb6p5oWHQPaxnQHdi2so7Suwe4cnTYabA6QPal8oFtKMVOz3WrFMIaph0LBUa/wsUo/ajdg9Qv/e6VvPjt+OEK3+9IiEsDAwYXTPakkXsJtdCiMK05VHoggMfeeyZi+UXzLxa/9EHyPn5+EyHggew410Vag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PZtwJAdC1k+uhBigRgMsjc8uzPXt/7nmsVM06HV+LbY=; b=XmpCl725Lg+JyLICgZUWqtwP5MRQX1aLYDsQauUsDBdX1muoqMIErJRZx/Cr9ATavX0xf9fK0OXuxU0xlvuZKx0wRRjBqZK+Ob5vypBQ09bhkyRuyimpbpvgXC2HNkY2WnDKrY4bQ8Vzv0BefviMUSncXfQExdxgs4+cGBsSe6m/iYURQsqnAV8W+lfQ0uk/8/C88yZvfnB8xmNCEmydZ1i5tf9wBx5XmYZ7FKc2UbXUwtuIQH9RcWj8IenDkzVxWKQ9EOT3vvLs30yFrg+0ysgL5IQUHo193lPLVdGI1XOaCle9lamge4FywyWbuBMdbm6rBNmSFXp90utr6NNKAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6355.namprd11.prod.outlook.com (2603:10b6:510:1fd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.23; Mon, 4 Mar 2024 10:00:36 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::d10:3009:a8d3:1d2e%7]) with mapi id 15.20.7362.019; Mon, 4 Mar 2024 10:00:36 +0000 Date: Mon, 4 Mar 2024 10:00:30 +0000 From: Bruce Richardson To: Wenwu Ma CC: , , Subject: Re: [PATCH v2] net/ice: fix null pointer dereferences Message-ID: References: <20240301052029.543989-1-wenwux.ma@intel.com> <20240304053751.567348-1-wenwux.ma@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240304053751.567348-1-wenwux.ma@intel.com> X-ClientProxiedBy: DB8PR06CA0038.eurprd06.prod.outlook.com (2603:10a6:10:120::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cb52309-67bb-4acc-ec84-08dc3c31f077 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UpJOu8exJB7Lyh8HPY87L26FoKYNI5d7++aHfkqn6xWK22iCriVyou5wd+4kxspRtMk3OdusN5MDkAOqTHEfZTaK285idUAvxLgxXt1p+y6dlaVsOZ4Nie5QZF2kvoSmpA9ByU5FDP0RK8dLpKeNvQrK/vNK7nq4rz72oxrvpPQgjPXqdEyZz3y+6iDeHpTXBQvbFAg3FttoeVuf7VvL8a6533mBDAaRtA74bVsgtMhcm3GnT5rt7byKaJaq08FhF1cXzzYv5JqNGoujzdc+sHG6ikAyipJUK4goNAHgm5flvzlEpwkhsOt66003pel3rAmXjrN7IXBksp5/38ec84zEgsjPeduzEBJEtKouwV8JyZSe5LIYLHMbKxSIKGO64aQwNX9PBFZ4AlkvkRlbHuGjaNfoddTDJP2MNiaMzU1n2iqZuG3f/cTyDg2/Qc6tmncmL+HJlCFPDakau258D1WnpcIPBlqggDZR9scbntmiKXg93/A736rgv6W9O6+ZRHSnbpim2pEHEsX/qSThJ9fx8B6Lujl8PXsjya5SLLzLaIBC1LHSMXStIaRXhBysrBsJxCkEqQqcew4H6Lg9mfiatsC8w/8SG03dlr6okA6NkFB2Mbtc7RB76aKpTy6s003cmfmpjmM5HZd1haRLp+oZ10ERgSkyBy0SXzjphl0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8KgB1wSFjK1PmBfJdHh8lXUoDH5AFQfrDJpsuGT7xmlypjoKkRlryoh/086T?= =?us-ascii?Q?cAserCwHHxzGzznykN8YayDtlekhGLWStfGpKY39aO5GrZHnMTO7AtepBbZq?= =?us-ascii?Q?22zrZ4k2s7SlYuXhyhMjuer1POaY/1h1QFjMuqmrmzureq6GTYZh/uD5FztB?= =?us-ascii?Q?0LsfVSPEXWCwgN0sQwGBgLx2CGV4lObsuhXgwMBxFH7lzMb2Lq1P9ugURIrd?= =?us-ascii?Q?Hbq7l0zGgvQjp26eT4z5GpmFK9lkAQM/MCqQ551XqZptzYY/KwFH+gJDk1I1?= =?us-ascii?Q?IonOBkK8XvW4XkUX4DVTBRUF5hZYuRQcMfe5DMrKGiO+CGQKfUOvIQnewn0V?= =?us-ascii?Q?q5aCzWLv9sBiaqy8+Ggyxw1TG4zltigM/PRAC5HFMpFWcQNlfCG1IvPh6NbA?= =?us-ascii?Q?O9VYL8LBUByD5EAud/MDUgAmObEmLABAk6wg1sduICEr9V3wNqBOQr5+3TZy?= =?us-ascii?Q?liPvtV5uySjT2TOcw04wzaXUeE5raKZxWN6cA8DyGdvqdq32JQAU2T0yojfI?= =?us-ascii?Q?B+D5KvnK8QjpHr5x/9OuUUpe3YTSREuVcLkXT4N3w5fxUAXhBbFPgqMeq9n+?= =?us-ascii?Q?GA9KXjvw8HcSCihil3nd6O6o0T7SqFRz+mKrMaFlRWuP4am3Nh+KeDurIWxc?= =?us-ascii?Q?ZUN5S5Wxnr8jUsQJXnOZmCfzqIXe4YIwtr1EIZWUoUYfudOFnJ4UHXlaD3lr?= =?us-ascii?Q?sZ+pjHt2Cyhn1RyrlB/CKe3zHq2MZ7KHeGFdyf0FvJFiaoPrIIayMpZN0EgA?= =?us-ascii?Q?4sNeVmV9ghGNPUTewFNXohmOARe+CUASN4h6YXdZKodtqD2H1S2SMFf0XeNv?= =?us-ascii?Q?PEOAngUn58P2W06s29EdJSo3aqrsAotUB7KALwxfMDyPmtFjMW44ctnNFjdn?= =?us-ascii?Q?v+AIqlZecSdvapXON9wm2o+2dLQ7KzTob7IzACSNckzCdB5PlDYUaNKvQi8M?= =?us-ascii?Q?w3J5ztQq2FNZF4F+CpYLcX4G2BjIk2uFzbxwDvLpIK+qukiUlqxFi13ZCEr9?= =?us-ascii?Q?IegL9Q2ffAW+0lzJCcMX82f29ibLjnyyymBtOC1Mr8kMyrknqiMAcSwP0fN0?= =?us-ascii?Q?CbNwSJLdnwRjQLoNgl7CTrmUxP9K/xKNDSIM/JoD1GqEV8eGS/QeSJszqL9s?= =?us-ascii?Q?frGugcTb2z/ThO+WmJU+W5yP3awZEci78T6wzNDBgjP1NU5JV3k+ZeCHKmyA?= =?us-ascii?Q?hGviCzUNBeLsJ6cgrbsj4peEiqJPh8OILJVlwOXok6t97r7P1MvcIL/zoryC?= =?us-ascii?Q?DXmbU7eUUeOKPoaYJ8E4YWyREQ/dizh2W+qn1Ied/pTUdgT3JbtIgyOP9Fup?= =?us-ascii?Q?SNBS0qmZXylZyArl0N36IpInZq0C5FArYfK91Uz1aJKQazOgal1CE4wZZqgR?= =?us-ascii?Q?NTd93HK4adU8OhKqqWTyDrndCY1qIWQEkolyss2kwbNr4vCmhTF6FH1HcZDQ?= =?us-ascii?Q?l+dolNsOc95WrDLhxEvG4e7LiwlUhDyVytU9QWDopP3hD1WiqIxA1MJan0SQ?= =?us-ascii?Q?s+IDhK9j/AkvTSwi10HpkeZ/JITDSNdF4x/y1padm1U67+zzDoPFX58hLf8+?= =?us-ascii?Q?ZSSizDAOUymxPOLMXVeKJzhdpj2BrxZZKqeYMD83+BXBIuNZsk2Z0IMnjtc/?= =?us-ascii?Q?8Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7cb52309-67bb-4acc-ec84-08dc3c31f077 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2024 10:00:36.6131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pRN8P7SMI2mFktrRobD9Vgy9qQQ3/EZ4dHQmVZmd5Wlfs+TsHUBDgMaMjSJI5DoeKCfBCc93UgCzMdaO3Jmn73Rsimf3BZTnfoyVQbpFiVM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6355 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Mar 04, 2024 at 01:37:51PM +0800, Wenwu Ma wrote: > This patch fixes two null pointer dereferences detected by > coverity scan. > > Coverity issue: 414096 > Fixes: 6ccef90ff5d3 ("net/ice: support VSI level bandwidth config") > Cc: stable@dpdk.org > > Signed-off-by: Wenwu Ma Reviewed-by: Bruce Richardson Applied to dpdk-next-net-intel with expanded commit log message. thanks, /Bruce