From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04D2E43DFA for ; Thu, 4 Apr 2024 12:58:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E80BD402EC; Thu, 4 Apr 2024 12:58:13 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id B4C2E4025D; Thu, 4 Apr 2024 12:58:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712228291; x=1743764291; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ANjZhWNQL9J8hQbc7CIuxs+/F3+/rxh41pfivqp4qnc=; b=iwiGcRFcnNmmf0RT1HnN1R3MHwNo6/BuL6NnFU0XjnboPSEtXqxFvC/P n7OLVBpmgVrqt/NvInDroZOYkTMQFx0nknDdtoB/luGgGhoBGiVMd4aqx jSxQzgUoQgOefycT3D9wueVzM8yCxAob3E1VSPYfZKb9lrJ8b/yMV7Ldx Z+dDXaVAxgxk73pwa+oNgzWQUZFkjbQXb8HmALUnTzdxm7O2+8QXHeez0 2vt05R5HclvpGwWkcpzMG0deKe6UnZFRGEwQrNjlp8s04nfuZSz9zPp98 /GWq0QWu3EeFoKh2no4MdhA5FF5EIygYiSIP1syXWkuTQNtCOEB06xVYt w==; X-CSE-ConnectionGUID: 7mM+gqFhTveQEujSKsYY9w== X-CSE-MsgGUID: 26VaCA5MQyu8xIzetqUMhw== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="7399283" X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="7399283" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 03:58:09 -0700 X-CSE-ConnectionGUID: Fmh1ClJJQNuaNZqYtU5asg== X-CSE-MsgGUID: /EhgJ1oPTv65UUf/UL+p3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="23437646" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Apr 2024 03:58:08 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 03:58:08 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Apr 2024 03:58:07 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Apr 2024 03:58:07 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Apr 2024 03:58:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VTIzLnvVPsbEjnUmRMbuSf7bS/5+o9f3WrZDwtMeA1mVX0LGEay3ZM77Adhjl4I/7WmcnQ11MsFQ3RgAz46CsxgperUI7rEB5AHAnPiq7iQB8hapr4eHRr4thn37cVvYl7vwSCIli491+Chsqvd3Aadf06Sa5cnjWvynrUrQsAl9Kon0/XrzCFMOenAhkNoL8PzBwmaDiUBVdeO/XosiwQkNrOXu7VK+NGWkAUd/qm5k2w+GnGhsPqKmJ889EQH9PluzUg5b57dcvWFaNMPHVPle25sWIN8GFjpw8fS4IAVnXegZm0vXGghlnDpv3F3b7OVT21iAm7sYLjemjgrKGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cQaVjeAC6rzM5cCZu5Og46myPefD4c8XVsmvfP3nDww=; b=Qx04YiQsS3QkEbWiyPXPFEg5ZGe10QpyD3Zcil5ovY7D3ZULdS+6UP0xNBtLMd0RGIYUjhWm+yGUP5lCs1s4z+s7xpb1XlEqUssLO9o6Tz8oLu526c6L8u+ncZGGQQ45o/I+eLxnpZfg+oR8C+BHk4cSvNnE6gVcs7aOXjGb/MOuCCeok8YODB66sYHOwlAoP5rfrlBpk//b2SfK4ktKcdGUcitzSUdu6LE4H79UcyC+Yjgi9MgE6MKni1/sJZDGKMIb9s+Pwpgl72WSsrQRuXDEFKWNOEWsd4BFaW+jIFmzZSWByYUsY0C4+25LhqkXrGTsJuk60MMpLnwMtran5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6268.namprd11.prod.outlook.com (2603:10b6:208:3e4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25; Thu, 4 Apr 2024 10:58:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Thu, 4 Apr 2024 10:58:05 +0000 Date: Thu, 4 Apr 2024 11:58:01 +0100 From: Bruce Richardson To: Kaiwen Deng CC: , , , Jingjing Wu , Zhichao Zeng , Qi Zhang Subject: Re: [PATCH] net/iavf: fix fail to reset vf when using dcf Message-ID: References: <20240314010049.340381-1-kaiwenx.deng@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240314010049.340381-1-kaiwenx.deng@intel.com> X-ClientProxiedBy: DB9PR05CA0009.eurprd05.prod.outlook.com (2603:10a6:10:1da::14) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6268:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MEM3yT8NzXasRtl9h4a5ylHKraMoNH42vBPiOh93BfY3EenF7eNi90sCIqcYYazA4PW0xnHMrPLdGauY5JJ7p7wCfQ0+NBcjsx14KwJCtyAJbmC9H+rmUOKdnoLKnWYMjRBq+W5PKpIgxAaKg9z6xD+Hdd7qq0m2B9S+VYu9QoSOy6xwYk97z/Usuakvm06vW/svG7nghYcb+yXlJx8QntMUyALvrR2zrp4q4dthHjtfElPYdyB385NvlD9l6dYTScEgVNPGWyuXI+ymlx5fxcQN5rttqMbAFTxRGr3DG/rFvWkH8pgwaVAlm0qk3iAlWfSBntcBJB9tmnzxiiaIgbVV4IWFvk352DKMatRzw3yInhyZR7ozHwZNLhl/UP/3hLuvgwMeuhZxqzw2Pcwo5duL7/3YABh403kVmTMGWQZ65kYJVsHJfyBr47ICP5WtvCj6jbhxw0g9G4YnHlQPri//rjM3sEtbgm2Zc9cjdQOmj8zBDJ+3EGgBmiS71SxyxNRYVgnvfJRCGtDraSgqnuStYdyMuGfGCSJ5xHH1dP4k7s+r/b9z4vPqij3I0k5sKUD1TA2nkGgRFr1zTCmfViDKwHI0HnyVL3IZFQe657PcxjyerhoAVuW3OWZ4RCWRMLS0cQ5yuuUIoxNo8r3pYqDzq76auxXC5fbJHfWOeMc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7aV01MjsfKRcMhESpEuucOHKcIxaN8yzNsy7o6NxH7iGp9WU+0FIDVjHq/s8?= =?us-ascii?Q?TERBhx9xBkead1nY23qBl4NRORqzmqU73Yj6A6n2w6fzI2E0/+4cKSjjM/Se?= =?us-ascii?Q?LsXbCxTzkal9xnPEeUAAkXdpQtrQ0mBsLiTFFkukqs6qJyk1dIhSmhTJQoku?= =?us-ascii?Q?GjV8nG72/CKeYClOXrdDRjbZhzQSPC5P4embdjSuozLunMfQQF01DnEFrbeL?= =?us-ascii?Q?JUIDEzgoIKACN96hXCG5EEK8gehWLRhruDdE30GZ/R7Xlyo0FYfr7RG/Wrge?= =?us-ascii?Q?e5BKOqaRRCy7folRdEY+VNT5Cj9Zfbht7vKV8wI0Ac9WUt0b/s42BIsyA35b?= =?us-ascii?Q?o1JS/c1e/GUnuZ8lRMSopLKhQIDQTD4Agsihrl8R/17cv7biHNeK/aw3l4T5?= =?us-ascii?Q?7b5nj7gg2Qjpruiz/XZRQKRIKwd9hv8e95JGdQIQuAlw96D+J6nGKhYwMkqZ?= =?us-ascii?Q?VtxllU+SNtgJAi8KiNKbMTtji9qIw6xCDwsJVDoTYjyBh52Dzk7cOFGClmfM?= =?us-ascii?Q?B5HtFBC4pHjfmwcFwBGo09BgN+Muzo2IRCBLyYapUPvcxPLj9PgiclQkLVf3?= =?us-ascii?Q?dpRX/tk0SGbqycxAbsYKO1HadnuoRWEvZCk0NRBU5qZxVkqx9p5V3YVa9iWv?= =?us-ascii?Q?a2gujmM+EfnjMo5jPsuhP2ONUB1ZLdzkPx+e0gzL2EdnybHbS8rtMKU0t+Zn?= =?us-ascii?Q?2trSJpSkecTCM6iW8PSwgyNnliK8qDlUyedbT5cc9/MUS4PeniPppAxTmg0h?= =?us-ascii?Q?b6du34pN3HSLCGy++W8ZGQL6kM4wCHkSQ766NijpG4nEQ71ZgYCaEhd/fWrA?= =?us-ascii?Q?piO9gg7hspd3nAdStMRmgkXYyX5JB85sQafBpzaJW1PX4jx8pqSw3fH44oyt?= =?us-ascii?Q?1JnDMhC405xhQQtxbjRkNrUbk4pPsIggR2H3gVzOfTln1RMpZMfP+yk9Yb9Q?= =?us-ascii?Q?1wlkOR9OYIDJJH+atouxfUp3Q41m190yim/gXB+qXVxKoIA/Ovm1iWJFqf2c?= =?us-ascii?Q?Ig9p5HKCu2oGdbHC9rMNiekxbMCm/eWtHvULn19eD2a2GyhKazjWAnLVpSr/?= =?us-ascii?Q?ZEW7hOkr/IUnP+zZs+6h64Rfxptfassa12pg48pxkBiu7Ij7SZSo+k665DyV?= =?us-ascii?Q?5QWq1tNffwswIqHD80HBSiws8DIE6BZvW19LQO7R87oFaTw27P+XXyVhdJQ4?= =?us-ascii?Q?K06h7ClR1OnvEdjWfEG2w8Vplly3+Jy3mGl8/I2pJVaQeTyI1/OtwhNnFg7T?= =?us-ascii?Q?HNnWlTS9h3vpD3YUAi3T0rZUPP3VA7kA/ZFqFGsMyApXCEyrBS5baSmAwD82?= =?us-ascii?Q?D0nfnzsCgWBSJDXPw9lZSgoo1b8r7fKLCG5jqHCV6av+l5lcitLr7caMkrCB?= =?us-ascii?Q?FwYR15E7/tSI8G/NapTY06sCsUs0Dk1Hs+DuChYJYDhgDkzICoFX2EiwFoK1?= =?us-ascii?Q?Yvrv34OusDJBRmKtNXK/vtiGQfu30H3sef1XEfMu6iXhuT9XMthIvUfu0VB3?= =?us-ascii?Q?NBKFzv3PotoGvHFpnRLVHNHE+9ftivk2gY+kquh32rqgnpwUHw3wM6RzSyEz?= =?us-ascii?Q?8X+9/kSqCg0kBnVSo8cwfs0PecnYDDK41l2RIZRbe/DGVLH7La4pygIyVlPS?= =?us-ascii?Q?Kg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4f7488b2-d193-474a-8575-08dc54961af3 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2024 10:58:05.5708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R9eEVVW3IzV1rHBPwPjmNM00cm6yrsG5rQVfdhFzQYzQa0Dgw+K/eSfG6Lv2/Z0TtyyB4nfYlju0AfENYbiB8osgoO8otUvqL5DePsc+zGE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6268 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Mar 14, 2024 at 09:00:49AM +0800, Kaiwen Deng wrote: > On the latest ice kernel driver, renegotiating VIRTCHNL_OP_GET_VF_RESOURCES > will fail without hardware reset when using dcf. > > This commit will send VIRTCHNL_OP_RESET_VF to pf before dpdk resets vf. > > Fixes: 7a93cd3575eb ("net/iavf: add VF reset check") It could be argued that the offending commit could actually be earlier: Fixes: e74e1bb6280d ("net/iavf: enable port reset") When applying, I'll add both commits as fixes lines. > Cc: stable@dpdk.org > > Signed-off-by: Kaiwen Deng > --- > drivers/net/iavf/iavf_ethdev.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c > index 245b3cd854..1c2d23f80f 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -3038,6 +3038,16 @@ iavf_dev_reset(struct rte_eth_dev *dev) > struct iavf_adapter *adapter = > IAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > struct iavf_hw *hw = IAVF_DEV_PRIVATE_TO_HW(dev->data->dev_private); > + struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private); > + > + if (!vf->in_reset_recovery) { > + ret = iavf_aq_send_msg_to_pf(hw, VIRTCHNL_OP_RESET_VF, > + IAVF_SUCCESS, NULL, 0, NULL); > + if (ret) { > + PMD_DRV_LOG(ERR, "fail to send cmd VIRTCHNL_OP_RESET_VF"); > + return ret; > + } > + } > > /* > * Check whether the VF reset has been done and inform application, > -- > 2.34.1 >