From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D55643DCA for ; Mon, 8 Apr 2024 11:04:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 872AD40289; Mon, 8 Apr 2024 11:04:44 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 5912B40041; Mon, 8 Apr 2024 11:04:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712567083; x=1744103083; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=agtBl8rt0Xr0azHx/ebXt1CXb0bH8PYaS1UslYDAqeM=; b=m6C+v5HKBlba2CyEqXi4+yFDxUfnNXmcPx8M+kV64RmOnCIULftcGVbD 1XicTTv8+8XG2PcRwGiiTQvJJzHFkJdtM0JIYF+PWSleMjvON1JGufKla RHvx3bPnr+JVbqoicnC1WA321er3SllM1p4NwCeUBx5Osur1pTnlytW+x GK+dJj9UVn9pD1YIQQeBPprEkxWQN6jV3gRgS1UkD2EPnhkSlXv4w0dEa tDzmoKv9tq+V9mM80yqffXFFICaUhrSoBA8H1gdev5tLCuDkltgp92G1O 1nW620zN57r9Z1EBJ50UOA+dZND/LTf7zRQOZFkIFzclINIZB1ujap8hg Q==; X-CSE-ConnectionGUID: YxQ21lmrQKiVP9M8VzN80g== X-CSE-MsgGUID: +vTMSvr0Qy+vdbZfnruFxA== X-IronPort-AV: E=McAfee;i="6600,9927,11037"; a="18406168" X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="18406168" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 02:04:42 -0700 X-CSE-ConnectionGUID: Fs3wqYuzS8KX3aHNMvIABA== X-CSE-MsgGUID: XgBFPOZLR4W0UBI7xAWv/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,186,1708416000"; d="scan'208";a="51013821" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Apr 2024 02:04:41 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 02:04:40 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 02:04:40 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 02:04:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hK7GbBZcg6MDJcucfNlbv4mKk2agmq6Tu/D9j6SFAI6iOQ31HdOgIUYGLsZZkGUcKDZdqCzNXwBHRGhfzKluiSiaD7wkRnNmeTj9S7DS80PYZlPV4Nl4vBmAY/hr5sHtCFYZ8a4/m7WrzpghqtNg+xbheADkCHtOUN8tuoZY2plmVcMSfTvwDWLgo7dLSWj9P0EP4rh0EYjmzcAr1GTw4oTNC8+1n71H70lR9UL/jp7aBxPPOUVAbcLTUZ65zJjawPzVvpZ4LBuqOeUwfUxCi2pPZIdcA/t4JGHu2VK0p3i0tgkX7YqAXFNsSrjpVP9O0DpLFk9FuRwYxItNVvE/5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nnRPIxnoQ0Ihx6ZYxF+dwE0cDDXphZAeZYvzpNUvBt8=; b=O6L/A41a7Tjne73cRF4dRDAvdAqwAwR7h+h8nmPA4aTe4duvszSIIW5KFcg34XS2rCbvR7Bp3mN1EjNsmQ3PpKjE7cYi+FzYwj55yz3u/L0oN5jon/CylLukm9LAIKUR/0O2+es6pgKv9Wja4ASUU5/sJK2rStIMdZ8cf0R7DCFPePwj8uFI+z3ViyrvzTd5DMTSzlerdJt+VOknvDvIxE/1Z8h5Z3e7GbaZmbKXXcqWubudPqJCTs7m/6dXbkc65o00m9an/uynq/sgM92orrSp0oggMDrlosFWZxfW5GC9wDHn8GqPoTdXECkb/IkSzIWG7QJgY38Aerm9z0FkZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SN7PR11MB7975.namprd11.prod.outlook.com (2603:10b6:806:2eb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7430.46; Mon, 8 Apr 2024 09:04:38 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::487e:e20c:ad88:9c0f%7]) with mapi id 15.20.7452.019; Mon, 8 Apr 2024 09:04:37 +0000 Date: Mon, 8 Apr 2024 10:04:32 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Ashish Sadanandan , Thomas Monjalon , , , Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h Message-ID: References: <20240202051335.776290-1-ashish.sadanandan@gmail.com> <20240318024415.555614-1-ashish.sadanandan@gmail.com> <1836105.FMhQkTaH9n@thomas> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0226.eurprd04.prod.outlook.com (2603:10a6:10:2b1::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SN7PR11MB7975:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WNzDdLDjZFzDviWaQwrIoV+DGmwWGxfu6O883NJIgui2BpAo81grPP4td2h7MhHto5QKcU+kiHP0uCgoqEANjmrrEyzSpjUrZboHuh3S0VbbJLvKU6JO/RnWNSSSpvQRl5oKmkc4Pd62GkDuEYo0iVmjgZ8dwDQeJ9b2K46JgaEo1AyhuXoI1VlvIjHohdWjLSfeMoJt3VsJRx9K9OIsTql1frqr2iPhyS+W3cw0IvSKFyzvyIO+6GKF/weOi1GvgPhlBLn5jaOXLks9Np/qfKQsm6/I7yWjQAlXzz25LZhW6p61lIBROTl4DC7B5ZkEPHiROU06vQCDNvFV+eqOFYqWdJ9eme6fLr1WIXl9ImbCJs2vqjjONYtMeZRlvYMHqa/6cePKWUflID4hZgn7vXoxm+MOA+Y4zvc4II6rtV8cnJVDzWTaUHDyyA0l+Tgyo3fEG7fs3j+NXTDRtHjDipM+flBaPese7i0OJvUDrGxPVQ9KM4eaUfZXadu5Knle3t+BMdK8onZ4Nv4WuAtq+SSNw9xLRCJAFzHEJhxEuuiSt/b9tQkk+73d9RyOAj077qaKsmtF2Q7ZvpLjSeYBsKIka+HRkiVMcsJR0zcWvUTlT6yTQY8OLfQupsv1bPQwGDnasp5kLB8ZULQRbElpv6sIxSpgQg69F/9mC+M51YM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEh0RW5LZ0Z4Q1FOMXlha2FiUGN1SnlqNVRXM21WaUZ1Q0dMb1pTWTNlaHFl?= =?utf-8?B?SXJCQVozZzc3bjVUVzE2WHlxVTk3MGZoUXI5ZEdXcWdkdllIeXZFVzVINlgy?= =?utf-8?B?dk81RGRPVFlQR09EZW1uTnJaT0JDcm12Um1YamxtS0lwUkRFaVJUbWJZcmRU?= =?utf-8?B?NmQzZkw2SDIxT0x5QytjS3lSaDZLcnltb2djdXVnSFlaQ3VmNXkvOWtkQU5S?= =?utf-8?B?NFpnTkx5R3pRU05lRUQvQXRZZS8yVXJHc0tsa3R6cVFGckNabTQwQVo0WFRl?= =?utf-8?B?TEpuRjhGT3BHMGNmOFdIb3dpdjltNjJqd3J3TXRFd3l4QnpGVEIzdXJIVldV?= =?utf-8?B?a0hkei9ta2NBMDFmRmhoMDRrN2N2MjdWVEtSOVY1SkVlQWVxVGtrcHZDN2J0?= =?utf-8?B?NDN4TTYwQWhQY3dJZTlPellXMWdoQ3JVb0tmdTU0bTh2QVdyYVNwbG1DYTM2?= =?utf-8?B?Zkt5N01vMXZzWjNjbEJQQlRkN2prOWN4dGNZS0Ntdnc4eWVHME5sMW1XbUR2?= =?utf-8?B?d0QzZ2d1bUlIUjZ4UTk3NnAwaDg0eXJVc0ZyS2VZM3VQejBhcDFxTlZLMXJN?= =?utf-8?B?TG92dEtFNGVvOWg3TVBPQXR6Si9DbW1hbUNnT0p1aW5BWGpubDRHaTBheEkv?= =?utf-8?B?YndWUEtmMEdDOUU0SUt6dkJWNlpoTFdBaE9uWnZEUWhZd2RuenA0cGFYcVIz?= =?utf-8?B?aWxIZHhpSEdnQUdvdFR4Z2xCTmFMdTdGblpFSTMvNDBYU0hRSHNNVVlPQkUw?= =?utf-8?B?RXVwYWVzQ1R5aUd6bGZ5SXE4QmdHWXF2QlNDSFJORjF0eCtScURtWjNGbVZ3?= =?utf-8?B?akw5Znc5a056dzJVNEgwSHFKWTBMMVpmcFRtREw1ZTl6b3YrZUlhTFZPRnVw?= =?utf-8?B?TEM5Q1EvdENheGR1a0x0b1VCcU4xbnlhd3U5WWNtclBPNXBiSzYxVDkwc0gr?= =?utf-8?B?WHdCTmRkNzJoTjR3NXVIaXVVdGU2bmF4MnFCMlRudzBlTjZ5b1Y5dEU2T1BX?= =?utf-8?B?TVdUeEp1Y3VpR2dSWmhjTUJRRnlGMFZHV3FPVWs3WmdycWgwbTBTYk15VGk4?= =?utf-8?B?TzRac0M4a0U3SnZaM1R6WHFXZDBwT0FGdWF4RHZhek5WTEIwMTR6UDhzQ0xO?= =?utf-8?B?bzMwQ0hOK2FHNndYRG1GQTAyUnFZK0szWEsxNFhQcjF2bW95enlSYXlPMk1X?= =?utf-8?B?b3VEeXd5bEZNem1Da3VLelRtWit0cnBaTjV0ZnljWERJWGJkZnlKUnhMenVQ?= =?utf-8?B?dkJXN0Qwc1p0NHpqcVlTM0xCTnJwU1QrNFE2a1d5V3FRcUYrL2xsOHB6UEhp?= =?utf-8?B?YUVhSndDSlNRQ1dqeTJBOTduVXlJQ2tnYk9OZ3BkYTh1RUdQTk85MVppMlpX?= =?utf-8?B?MGdRZWdnRDVBMUNMRTNjVHBIbFNTcDhZQTlxY0tBZFNiMzhNMkRpbGgyYzEw?= =?utf-8?B?TStlSXEvWE1kaUNGV2U0eEdXU1dIL25wMnhqeE51OVNudlpHc29IbFhsanhG?= =?utf-8?B?NmRtVDdXamx1YmZQSlRIQjNFcmsya3o2VWJiVDB1bWpLRHNJaXFRRGhhNnNO?= =?utf-8?B?V2VucVlsUUo1TElOZ1lIT2YxMzlkbUc1ZmJYdW9Ed2dsaGszeFFOTnVEUVZB?= =?utf-8?B?d3BtSndPR0Vpclc0aml4eTYzNVpFdGZYUzFkSlZQQzlYNXhtMGJLVjFxM0hE?= =?utf-8?B?d1NlMXh6NG1ZK1pMSWxheDJ0Q2lLN1B5M0RZZnorcTNsMUx6dXZwQndPSlBq?= =?utf-8?B?bGxvSzUrb1FPU01RdG5OL1ZGV044cWZsclQ5MEROUDdhdnNZckRCQThCQVhG?= =?utf-8?B?bjJCZUloZmE1dW1VR3EzcFA4QWs4ZWRkdlJrR3ZiMy9xSXZBNTBBZkIzRXQ0?= =?utf-8?B?REl4Z3VNSURjcFV1VnBnT0JZbjVYVktWNGgzL0R0aWowQW1tUXlBWThDYTBD?= =?utf-8?B?TWpWZlIwZlhsWGFTNXc5YmtFUEZtYlNseVh3bGZoSHlNYVNsQ25SNUtjYmlR?= =?utf-8?B?U0I2NzZpZFZueVZEczU4VDAvMXFBS2VHOU9aRzluOFU5T0NmMC9mdkNVblRU?= =?utf-8?B?c1FDeVd2YTNMNEtyS1FSeWpiK2U0VHZiU29qQ012ZlBwVzB0YURtczVyNTBa?= =?utf-8?B?K09pS3JsTXB5QXFad2w5UjZqa1podjhvNG9IanBiV1MxMzlYVzFFZWpVSGlw?= =?utf-8?B?SGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b475cec2-de2e-406d-6311-08dc57aaeae8 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 09:04:37.8911 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RF/PdsH1qdh2+O/2zuuOcSgPguI5+n/hzop94xPLFA8EO7lCJewpINtw48Rp8rtMCK2iD1GZ2pFhowVsXN/+wdzZuPncNB3WadTixvRK07I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7975 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Apr 08, 2024 at 09:50:51AM +0100, Ferruh Yigit wrote: > On 4/7/2024 2:30 AM, Ashish Sadanandan wrote: > > > > > > On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon > > wrote: > > > > 02/04/2024 18:03, Ashish Sadanandan: > > > Hi everyone, > > > I've made the updates as suggested. Could someone please review > > the latest > > > patchset? Not sure if I followed the new patchset instructions > > correctly, > > > I've always had trouble with that part. > > > > I remember we were discussing about aligning all files. > > I was waiting for a patch applying the rule we discussed. > > > > I missed the part where people were volunteering me for additional work :) > > > > The consensus seems to be that the extern "C" directives should only be > > in public headers, not private ones. Can you please tell me if there's > > an easy way to get a list of public headers?  > > > > Public headers are installed as part of ninja install target, so one > option is you can install a build to a custom folder and get the list > from there. > Or they are listed in meson.build files in 'headers' variable, you can > parse them. > > > Don't get confused with 'driver_sdk_headers' variable in meson files, > that is the list of headers required for driver development, and > installed if sdk ('enable_driver_sdk') meson option is enabled. > I still don't see what the major issue is with just adding the guards to all headers in DPDK. It would avoid any complications of which headers get installed or when. They're stripped out on pre-processing, so it's not like they are going to have a performance impact or anything. /Bruce