From: Bruce Richardson <bruce.richardson@intel.com>
To: Robin Jarry <rjarry@redhat.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject
Date: Wed, 7 Aug 2024 14:43:46 +0100 [thread overview]
Message-ID: <ZrN6EpTmsc9_aClU@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20240801100153.41779-2-rjarry@redhat.com>
On Thu, Aug 01, 2024 at 12:01:54PM +0200, Robin Jarry wrote:
> Fix the following error when using dpdk as a subproject:
>
> subprojects/dpdk/buildtools/subproject/meson.build:28:56:
> ERROR: Unknown function "file".
>
> This was obviously never tested in its submitted form.
>
> Cc: stable@dpdk.org
> Fixes: 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject")
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
Good catch, and easy fix, thanks.
Interestingly, even without testing the build, vscode meson extension
flags this issue in the "problems" tab of vscode: "Unknown function `file`"
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
prev parent reply other threads:[~2024-08-07 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 10:01 Robin Jarry
2024-08-07 13:43 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrN6EpTmsc9_aClU@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).