From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EC18045A7A
	for <public@inbox.dpdk.org>; Tue,  1 Oct 2024 14:41:25 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1B53140693;
	Tue,  1 Oct 2024 14:41:23 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16])
 by mails.dpdk.org (Postfix) with ESMTP id 261F94067A;
 Tue,  1 Oct 2024 14:41:19 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
 t=1727786480; x=1759322480;
 h=date:from:to:cc:subject:message-id:references:
 in-reply-to:mime-version;
 bh=2MvrxMymvA+gyaJF99bPMyzhAqrzww9LISR2fzaEHhQ=;
 b=iRmvGd20CdmrZ2qv9s4wvjdePmDSmLP77j0v7Q2CzcxxvLcyvPzY5yvV
 o+FunTwVjxWMDeGxrLgzwN2HF/kpapdrE0pFtOPEndfumth9ifF0T39y4
 0R5m/hTFythq+MV/JXP5msB9sIvJbpgo/aPjUBc80uIXS1CaRrQt5bII8
 K/ZrRyCEegZ5GYdm2RvtEJMrCFvYscThMkqx5rfsfkNY0YqZIu0FBk/or
 H/B2jgc4rzp+DXCJF2hOalXjfZJKLydG8MwP4pO5bOSWtzlusvgQo6rfW
 fAftSGYfsJ5iXlQ2FGXjEiFVh1qZqRmbLUR7fUJhMbsZZVSAvnoWYBHcR g==;
X-CSE-ConnectionGUID: 3I9DOOSLS4iRbWtNfW1CjQ==
X-CSE-MsgGUID: wr4KUme4RcW6dw5glhUy5g==
X-IronPort-AV: E=McAfee;i="6700,10204,11212"; a="14538822"
X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="14538822"
Received: from orviesa009.jf.intel.com ([10.64.159.149])
 by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 01 Oct 2024 05:41:13 -0700
X-CSE-ConnectionGUID: bsy9R5fATeK87gjiD7SBgg==
X-CSE-MsgGUID: +YwSkmZzSX2lqE9SXRp1sg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.11,167,1725346800"; d="scan'208";a="73705277"
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
 by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384;
 01 Oct 2024 05:41:14 -0700
Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.39; Tue, 1 Oct 2024 05:41:13 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.39 via Frontend Transport; Tue, 1 Oct 2024 05:41:13 -0700
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Tue, 1 Oct 2024 05:41:12 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
 b=QIM+PSM0TiA9vFmCvH7SSAChm2CGKjYNhopXsFWrJ2IM5EIzlJsvM+bzRK/683ddeehOo4ICHrKQ4B9X2MWk5F6BxSkudqK5hCDo0SCNOTo3PAzpEJdLYUUBvv3bHA3Py1Ch+5X3UkWbnXoT7S/fbarMnrYiL8a4i0Wf53tuI14jW8QFG6P+Dofy6hKcVXjYd9n1tMyIeWXt0S9n7QKZL7adF2t6OEfojBSrhotc1jpA2Uof1XKcgQ4vUAFlMEKh8Y2xRE4q9QjmlRfLuej/RBDWsx7Fb6jZLdC6UYA8pYWaLrEoZj4DxYvcAN97U3T0iZPOzXYzMytFjjYYneOSNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector10001;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=j8DUiDtd1bRT1OErC71fOC5O9qY5A9H4rZwwC2S2OaU=;
 b=CHriKqDfsrhpvZ31ETIVlcTzqroVlmPgbAYedQB0Gy2Z+hlYQOQpYMgi+Uc5ZavG1Jh8dDe/6vt/EjbreoRT9iqctLEu0sd7QnP+F4VtxAmpnl558wS/pqtJeBh1njJXpjBniWN9MGIWomgwNQKxWP3l8wzHC/MFpTFURBLPBkH6J1/IW0WiPJEy3j1Udbu9K9rlx/HsWyaJTY77Od7aXGrOd81ZWMme8oZzrKl+sENluuHAKczd4z5JaLgBCmDZrNb8ToauBK0aJ00NZojcLnWCEZAPjMAPUCd3eUGx7kFe4OUytHws6aCpZ1wc6akMwKE/WULc5Wd3LymYc/0xYQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=intel.com;
Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17)
 by DM4PR11MB6167.namprd11.prod.outlook.com (2603:10b6:8:ac::20) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 1 Oct
 2024 12:41:10 +0000
Received: from DS0PR11MB7309.namprd11.prod.outlook.com
 ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com
 ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8026.014; Tue, 1 Oct 2024
 12:41:10 +0000
Date: Tue, 1 Oct 2024 13:41:06 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: <dev@dpdk.org>, <kevin.laatz@intel.com>, <stable@dpdk.org>, Conor Walsh
 <conor.walsh@intel.com>
Subject: Re: [PATCH v4 03/17] dma/ixd: fix incorrect free function in cleanup
Message-ID: <Zvvt4uLp0ToSLKvK@bricha3-mobl1.ger.corp.intel.com>
References: <20240927204742.546164-1-stephen@networkplumber.org>
 <20240930184600.7092-1-stephen@networkplumber.org>
 <20240930184600.7092-4-stephen@networkplumber.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240930184600.7092-4-stephen@networkplumber.org>
X-ClientProxiedBy: DB9PR01CA0023.eurprd01.prod.exchangelabs.com
 (2603:10a6:10:1d8::28) To DS0PR11MB7309.namprd11.prod.outlook.com
 (2603:10b6:8:13e::17)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB6167:EE_
X-MS-Office365-Filtering-Correlation-Id: a3286648-9804-41d2-162f-08dce21653e0
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016;
X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SDyMi7wWcag6cSs6RJnHAUwBe27W8LWL0F1Dsq5idi1XjZh2MNhwWuStchq0?=
 =?us-ascii?Q?aImt72E/b/S3eszN52PXCwuTpxsHn75u3gABLIjgU/V9U8033QhVOiPo1ZGr?=
 =?us-ascii?Q?OTTfsrBkDaKEgTaPNhMa9kKxe52Y6YqurK6ZOoBAcFt/TyNGsoVE+55fdikp?=
 =?us-ascii?Q?2AbVs/Kx0IwRR2cKDu3/SNO3hKR8j6UiWXN7Wqmfj6j6YwYBVinW7jtOGtn0?=
 =?us-ascii?Q?QzsO9PPnxu+fm8Tz3x+5WuHEkw9udY8c24uphM8AQKg2uczVUws56/qVHAbA?=
 =?us-ascii?Q?+/S2yy+g7TVZtb0d7GmgujkGpPsqgmcbvbzUIQLFzYMBhFpd+Ll9X7sDzWRj?=
 =?us-ascii?Q?dMiWNkywMrfZ88sOJx4C4NKKfyCHdZDPILMuubnj+8GfWDHK/YRxl4OEhIPp?=
 =?us-ascii?Q?0wEAqhd0Qb8atCDwIIVjswV0ms7U9avOnXI+FWnbsQMpPYIS6N11L2egVn10?=
 =?us-ascii?Q?hNpjA8Q9pMPn5XaeJ3QMLT3GxBjDVoLTXOQsan7L3SYuqwDPmKk90B+iuDKZ?=
 =?us-ascii?Q?xcO+Z2IQn8s9wLd5TSoDsP+gy5nmdmgZJVGKjvq+Er+O4JRNIMq0NVhTtvna?=
 =?us-ascii?Q?bXCwB/QvRehfCYdFFeAPohjDajLmEnzdfmXcDAmgwqbWIU0RFejLggkHetiK?=
 =?us-ascii?Q?IIjz7nXXZXP0KxQ3SH+Ft1djU5jn2LSs9Atqg4mNNfxEhGKXaNcQno2WeWUi?=
 =?us-ascii?Q?KfLLnjW+AZKgzLcMk+i8b7Dgt2HS3wS3L2r6RM2GDIx9TFAFNAt/NkAOOSCd?=
 =?us-ascii?Q?Qfv/aea81aB8YYIeJNOoWYGciOC9t2RQshZa6Dn1NuWUEnz1tSChVG0QOmhT?=
 =?us-ascii?Q?4r3nzIRPf3L2Y5JqSHmau0NAjLlNfaKGU2rxFBAXnX1iEnRJb/UIDhS/5GxH?=
 =?us-ascii?Q?/d+JNPrFlULyTyxTdMQ6M/Be+Ow8alPh63KeZJobZacUYuyOVVQra094nr7/?=
 =?us-ascii?Q?gGPu3128RekCG41UguzYg0+p9GnNjUdrnd9L2/POX4Du/8TfhzDXHVsHooGE?=
 =?us-ascii?Q?h+8u5KFY0AJbvaNTmVGqXJd+OengTK4/iGv3RMINN/xyJPNc8LEv7pNBATHb?=
 =?us-ascii?Q?pmLgKqyKQLAatU1T1kodQzNZxTYbqvc23hVHB2ocb9l55fcut0FY3t/iiAwq?=
 =?us-ascii?Q?3MVIamO6WIpBNiY4Nmxolir0KPKWcXSfODjdicXqhN7Uupl/UGM38xTGt4cI?=
 =?us-ascii?Q?uEw/tBrURDQZKcrHbHvBWlD8LheTuEHXPSsl4lTRbEKCL7xlTtQtMxQy2gey?=
 =?us-ascii?Q?1+Uz16/ZfQ8aG0fAcyRBW29WN5QV8UckuOl/7qQPt4p5wWuGrwcc1bV5gYiN?=
 =?us-ascii?Q?4QGTClL1Wkvlhne5XnQcw2OWIzVgYllBD+CDur1qI/YzLA=3D=3D?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?37vr9+ISNuniJarwyxlu+z0QnUCQzvomc2MB47euEPWOqndHnTxxPRmZx3Qj?=
 =?us-ascii?Q?5HL2VJK9xdggyPTITKiJX1DFV28NAVRRs+x1oN9szl/kQRAe2CoXOa847DGU?=
 =?us-ascii?Q?7mb00oxFv7q+VVk1LnnFRq1OmNDDPBHrIaQtQdd3nBhHf/W5lgLm5J4ZSsKp?=
 =?us-ascii?Q?3vuyj/8OYRgjo6AqkdEXpds9gcqZ3385gw758cxiVJGx+hll1sTdWCXVqV19?=
 =?us-ascii?Q?O70qI+eEirjlFIrAUdlcx56JS21VO+e4O1kzHd2UbiabE5JJp3tb+x2DLvSf?=
 =?us-ascii?Q?CWiECitSbFzAqum+6nBxEBHSTGmPmk3Off28r9WfoKaRV/Tjg+LqX9mD2B4T?=
 =?us-ascii?Q?jqxVfCnswnxX1G6JyMQpgomzR3V1ODPVyRWcqofoSlmsdREVFtsUhzExN3m7?=
 =?us-ascii?Q?7Uv4pQdlYrpBFHJwSuQs8m0aQRRoKIlXHUCp0GvPSCD4r0qrjIHzuNrVeSNo?=
 =?us-ascii?Q?cfil6EFm0fZO3djIlMgdl0MiKLWWVL51yF2ywIogD2ZJTj03VhICXJ4iyDLB?=
 =?us-ascii?Q?bHOJSd54gRYzuCqRNKePLWT+/0E64RGuaMs0xJavkY7HYbWpNtygfMRLh4zk?=
 =?us-ascii?Q?yRpY3xYmiidYu3PCbVU+DlSKRj2U5rLLEkbT0a186GDh98B4EflCe2b/9TBa?=
 =?us-ascii?Q?xk3ay0qzi+BSoBhaLzZEdlMRs+k/XK5GHGjyhiLsq0pTSno+Ryfqz4KsjvvM?=
 =?us-ascii?Q?C2fl/a+SibDsJ6CrqzO/85RrwIYDeARwGqeDUYfFfw61PChAfFPWcsx+DKVb?=
 =?us-ascii?Q?ZEAuAxlFtcM4Nkz0/PvYMDUn18z4vuH6tvDuTpuG5PW5mYOfSzxn5IpJsvxG?=
 =?us-ascii?Q?6xjHP7CDgwxMKFhfofI8Sp+WopjsMJOU+NO8WYBuLSBjcmaZ4Xdt3CYlwzBu?=
 =?us-ascii?Q?N0igAk5naUX7BDjW9vQ5b7J+yvuxzMmtqmjNkzSnMOglg5JqEPxnsE+7OFoV?=
 =?us-ascii?Q?BBU1HjgARkxj8ijaDdO0x7e+kqNMeR+VNIh2VLc4krQBczHD1MD7HsyMiMp8?=
 =?us-ascii?Q?IpcbsUGfJ0HXcyb7YQLXc5Sv93QOFw41EmLtJ0rW69kY5PjhW4T2owAJw5XX?=
 =?us-ascii?Q?AE9ISTLP70203H8/fB5sZkqZ9xQSxRHWoebj50dYokkOiYromo1Q5cYTHFsp?=
 =?us-ascii?Q?eH9RF1/Xn+IV88NqAYaXYv9Z9Dh/HZom/BEcrxYDaUH3JboyaFqB8w+DQtHs?=
 =?us-ascii?Q?3bWOhdUrrLrCw0pteQ4o5EUW3HqquPj4UTk8x1wCITttvnmOLxKUP9xE4Xkb?=
 =?us-ascii?Q?FtM5RinSHwXulyjQEjGzcSz5O0Zbou/9PauIMAJG2AGGlqf7548QPe4/DL77?=
 =?us-ascii?Q?PwGLC9CSt5LBexBTpqWjzVYOn97lAyxOfQ00VEOWDXyprbeVcLtZ00kRmqyq?=
 =?us-ascii?Q?1RjDSHpIpvlvdOYRgww+497DVLLQ/Ga+HYc8je9/1sdcGeQyXy3oD8B333+Y?=
 =?us-ascii?Q?fIurZkuDwZK3PEr0mp+2P9T6OmquXCAo1TS8daO8vUMutb+J0XF3kEGZIuwp?=
 =?us-ascii?Q?STFno6ZCjS/ZAAaJ2RdGxnl/L93YBOLdQKEOHy48+mcgXh6sq5gtWljet3OO?=
 =?us-ascii?Q?3uPwF7T9qEk2qGu2vVyjY9flyGhlMJpe3iRgipemCzr8xvuzk2Sy1Mui5NWq?=
 =?us-ascii?Q?iQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a3286648-9804-41d2-162f-08dce21653e0
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2024 12:41:10.5320 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2+VefxnevX3kSDLtw6jGJ0uLI7wpu9TApPx/cfTfzLG08PGAdcGjENZvsecSoI2C8z+2wgJBG+WxswT/u56ehFnCtEADULJiYPytk/+eQGM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6167
X-OriginatorOrg: intel.com
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

On Mon, Sep 30, 2024 at 11:43:57AM -0700, Stephen Hemminger wrote:
> The data structure is allocated with rte_malloc and incorrectly
> freed in cleanup logic using free.
> 
> Bugzilla ID: 1549
> Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
> Cc: kevin.laatz@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  drivers/dma/idxd/idxd_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c
> index 81637d9420..f89e2b41ff 100644
> --- a/drivers/dma/idxd/idxd_pci.c
> +++ b/drivers/dma/idxd/idxd_pci.c
> @@ -301,7 +301,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,
>  	return nb_wqs;
>  
>  err:
> -	free(pci);
> +	rte_free(pci);
>  	return err_code;
>  }
>  
> -- 
> 2.45.2
>