From: Bruce Richardson <bruce.richardson@intel.com>
To: Praveen Shetty <praveen.shetty@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH v1] net/cpfl: fix IO port forwarding issue
Date: Mon, 11 Nov 2024 15:27:11 +0000 [thread overview]
Message-ID: <ZzIiT-leb4m8yOhg@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20241108110923.80404-1-praveen.shetty@intel.com>
On Fri, Nov 08, 2024 at 11:09:23AM +0000, Praveen Shetty wrote:
> Issue was reported in dpdk internal regression testing that
> forwarding the packets from IDPF VF to IO ports using the cpfl
> represented_port action was not working.
> This patch will fix this issue.
>
> Fixes: 861261957684 ("net/cpfl: add checks for flow action types")
> Cc: stable@dpdk.org
>
> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> ---
> drivers/net/cpfl/cpfl_flow_engine_fxp.c | 5 -----
> 1 file changed, 5 deletions(-)
>
Following discussion with Praveen to clarify the issue and the fix, applied
with expanded commit-log message (below) to next-net-intel.
"""
net/cpfl: fix forwarding to physical port
CPFL PMD should be able to support below traffic forwarding capabilities
based on the rte flow action types.
1. Forwarding the traffic to the local CPFL vports using
port_representor action.
2. Forwarding the traffic to the physical IO ports using
represented_port action.
3. Forwarding the traffic to an IDPF VF using represented_port action.
The 2nd use case, forwarding the traffic to IO ports using
represented_port action, is not working due to the additional check
added in the previous patch (861261957684 ("net/cpfl: add checks for
flow action types"))
This patch removes the incorrect check to fix the issue.
"""
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied,
Thanks.
prev parent reply other threads:[~2024-11-11 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 11:09 Praveen Shetty
2024-11-11 15:27 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzIiT-leb4m8yOhg@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=praveen.shetty@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).