From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2421445CEC for ; Mon, 11 Nov 2024 16:27:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 144BD427A4; Mon, 11 Nov 2024 16:27:25 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mails.dpdk.org (Postfix) with ESMTP id 0E1AA40041; Mon, 11 Nov 2024 16:27:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731338841; x=1762874841; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=ywhCRRP8bGqpK4lC/WgJruF4M62S921+zw7rr3mJa2Q=; b=KNsFV42RTVdoy8P7JlTOmOUo3asUioNydaXfSRxr4ASxeLqRq4FTH7zz tJHgq6AE+TY2qkxud7bsXzNpAuwb7x3wVSvGoJIHV2NLIWP9sWF7ZOwqi e5F+CsD9XB0NXcjdWeNmJCyRWjDrjCfdt5fGive4GEw9VFNa21N1BluTr RkJqUmFsFkcUKd7ZZVO91oybUVntmQXKuNiK2+l0hkXwsx1D/3UjwhRHo uO/XPNPEnDeiOygMucAVYCuzAFZo+DVuMUhQ1VtWN6XRJkRSnUVm6/mUq gIvcoRzWwTgAcGyo3qt5C54nj890sHvbhe+Ta0wVhfaiHEj1DDqJDrCv9 Q==; X-CSE-ConnectionGUID: kZHb9HUJQxKBd9kZeA9yiA== X-CSE-MsgGUID: wZiqY9E3STGQ/KilGMwjzg== X-IronPort-AV: E=McAfee;i="6700,10204,11253"; a="42531089" X-IronPort-AV: E=Sophos;i="6.12,145,1728975600"; d="scan'208";a="42531089" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2024 07:27:20 -0800 X-CSE-ConnectionGUID: TI9wP8aHQFayWuUAjHpBow== X-CSE-MsgGUID: p6IbjOyHREesiSn1e9GMGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,145,1728975600"; d="scan'208";a="87753875" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Nov 2024 07:27:20 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 11 Nov 2024 07:27:19 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 11 Nov 2024 07:27:19 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 11 Nov 2024 07:27:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ogd48E27a+TVZuZgljba4x7Z9zKTDeRr6vB8o3CsgAGjBlTxM/sfAJLb+cDhGUXF9BVApUHzcj7gBDUbZ0l9v3UHmydTEUOADS3FJRXM45Qy6M/7NCD6ZHr4lBHLeZlwWaotEmRgNf6Co++OV3+EsKnAtMS9Mqzvtmk/bQKsa6By3oB+Ig5i2PYXYHqGs2fzesubzDYzGATBsW8+f+7jWfsxQpIxekI5VVOjVYhmy3G2uhUeBdtNlQFZNcfP5ztJReZ6NbhssIDpnVpRdgVW6S+9hYT2JXfYj9FP+IhbZMau4XdKapRBR/A1sX20ztei9CH8GDR+zXtDptcY43tYyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wsoirprMzoTZi0fMOFUiSb6NW5IgO4k9qob3vISlwzo=; b=lvhvFvBJUP3dlf8z9360wM3o27z+ibu09As7oggOpkvvTIeQ3OayHyKk0UP1RP+ce2guTdxsMwUDMo3aZrrM0Jbcgms5deH7afGZExve2bICr7S/2dnerPYwQIa4p6S0JDjXaaySuv1z+xhbq3zVXGxg+i1dTI4xIQc6qSC71vwFQK94sUNyT7p3/IDAY5MUCP1aItFitL4HHVpvkXSqDlKC6BAd2B/84aWgTFkJDLnJIyt5WTqfF+CEW/8u2ti9ILDmq3bP0j79CDe+iLyGoQ3bDmfCHb2pTUMvdkvdbVfjX7VEfhFt7rwdKsCKj99+NgzrMfMmmuBwiu3knzVjWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB7841.namprd11.prod.outlook.com (2603:10b6:610:121::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 15:27:16 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Mon, 11 Nov 2024 15:27:16 +0000 Date: Mon, 11 Nov 2024 15:27:11 +0000 From: Bruce Richardson To: Praveen Shetty CC: , Subject: Re: [PATCH v1] net/cpfl: fix IO port forwarding issue Message-ID: References: <20241108110923.80404-1-praveen.shetty@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20241108110923.80404-1-praveen.shetty@intel.com> X-ClientProxiedBy: BE0P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB7841:EE_ X-MS-Office365-Filtering-Correlation-Id: c18ba1a1-38a6-4f06-1139-08dd02655320 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UFnAEAry803UAqt1PVMIki8uptIp0SBblNfsXpT7wvQqmexX80LV5u26h/JJ?= =?us-ascii?Q?cBCSq43QH/ga19vgudpzpb3IjRUfHOgPy5J4NDkGYPqPxUKP3fJqndA9+Cfu?= =?us-ascii?Q?mUo6WS+yiKx1ER/qybjeLKCqQ12gW0MSCqZz14U8wgbJU/an3KiF4w0XEViz?= =?us-ascii?Q?41cVKsx7quTNY5qeauVGuuJ+TLb+eprcIYvLovky5HKxX51LZA1hxViXLlcW?= =?us-ascii?Q?rBEVncfZozy1naNLu31eqmNYbRQUeuibTlrYy4yt7ASrHmGQSeY9pV0KXqlz?= =?us-ascii?Q?u0K8kJ+y+1tAjK0/8vCqmM51LVzjvkSJBDkgIRpPc5N52yJ9SToMVGWWrbz7?= =?us-ascii?Q?cZj/mbUzc78Im3aJuElJ2jmqHbSO1ZLQmMSBMLWvgetkYivFQ8KEtobD4jTr?= =?us-ascii?Q?zuuJ4jtcFiQcnr1KEc9ycfQb2cjVtyBw+PXXbVk4Ls4O9xvBz+RWULr4JPG7?= =?us-ascii?Q?R2xtk2ZWBTAgf3x0aGFc1KH+qngiMwuNf+UI3umCGgUY93Ds9cTRN6t0hOX1?= =?us-ascii?Q?HHa0RP3WNAl4T+MqSqEW/cpcH4GHSwiZuIANjIHHW14GTL/5D53/Z1QcuUNL?= =?us-ascii?Q?r0+6EA9cYUAthlHW6FJAcrTKb6cp+EHy9Bo/Hih+tpuw9X57AbUC9fT28X7K?= =?us-ascii?Q?ejv5t384u0dXWJOmImdKVSmOCkiYu7B+jgnaKYei75N9AbKVjJ9iG5H1EcCo?= =?us-ascii?Q?uZDEnI7Id0Pns1F1Gn1maEobXaE3dk9yZNiQ4GW0UNI8y5aJjEhTTxfvguEv?= =?us-ascii?Q?8e9BoWH0MH9MaYE2lDDtQA/Iv9Hg603OOgcvgUW2WtxxMMQaee/WoS1ox6x9?= =?us-ascii?Q?64PPuihnUxl8nGfkpFti8NXFstmQOUiBtkZwRPs+J4YoR8Mfr5YJzzkQnzJs?= =?us-ascii?Q?Q1Db3BSmCaVhN8HgvkfoNsWTOMUXTxF7wAIOZYMxy/rWaRvLtCAwGU8TAjtE?= =?us-ascii?Q?EjPj11M6rQa6l7I4KPCvE6iLPFNNDpHcz7r3LyrQ9l21x/bUxOzrRMt6dylh?= =?us-ascii?Q?6iBpC8gQR4SrnMtQDWgywI/+4LR2gB4tp0OzV0ebwLhV95Ih6PFq5HYY1cgc?= =?us-ascii?Q?zY8TYQmdCnIx6z8e2Ut7BYePq7g87FFFwn3SREieFFq9ft/F/EzYkQfyr43y?= =?us-ascii?Q?ZRnldWYTsPZzrMsvYAgvqFKAHVieHrKEJLZhBgUXyHPMTorGp5eB1kKmkU7k?= =?us-ascii?Q?q0ftXaXSXY86lyKE+nKOJX8B1f8/NVODVzFQHrK1qfwram2SKey+ibXJoPC/?= =?us-ascii?Q?fLJgvTObxQ7jDex8dRfvIksgfSErYvDnnEOjplB/YaG72fQoKoJ2c5lF/+Sn?= =?us-ascii?Q?XFM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1ZvT/6Csl9mMzvpgFMBAbkh2kIWJtVj37m75upSEY/QZ3tM0V1rvN8dBCeON?= =?us-ascii?Q?6TzBHN7hunAiHRELpJPuUbzI1JKaRUjHEWMCpUicOReMA8mybfACyB6Fk1Nz?= =?us-ascii?Q?mMQZIRt/T/kThC+h7fuFrSAWAhHHMmVIoFM3n/oyNpXWXwD4Kk9FHqSIZ8PW?= =?us-ascii?Q?VtH6XJ/HR/R72I5DjUcJzmrkEdIZMsXZYQU2sCdq2ZXRspQuYqJbhV7gq5Zf?= =?us-ascii?Q?1oaPC4ubFl9mFshpWKdtDd8ccGjZkf4kr1RC3z7lehAN8Jnni/lTXyZMnmjn?= =?us-ascii?Q?2DlX9VcGQR7aT6/0Xh69NJX9tXvqMIQ0B3ifKMbPtZSts/wEIiIBGCtIVSMo?= =?us-ascii?Q?HPWSZUmsxB5MjKJbg3Bun7ycTthipYqiq8BZbuERogl/cX8DdNQKmvzaCoRB?= =?us-ascii?Q?rzF6u/NolhL6YRbOiOZ26U/vnVmXMSKDIjkDI2DDqymdPCqwnrun3ynp4S/C?= =?us-ascii?Q?OLWuV5IODhXjVyd7Ijt7WoxfYCT7f+sGqeYitcqiaVtfkZ5bKXPS0O0P21IY?= =?us-ascii?Q?VoZ8/5vJGTIMHbpjkWIrGU8L582b5/umG113n+w9yg0fblxYZuRcP/KFqKGE?= =?us-ascii?Q?L7/5XG91YutP+triVB140UNuWMwyE99b9xk/F99yofdvH9wivvqVLNEAt/z2?= =?us-ascii?Q?mS52q6JqhnVEsycqf4py5k/ObPK4JuETjqHdeSjU1ZXENcLUSjbMcg/VKLY0?= =?us-ascii?Q?46w4hUPct3tksI2n/t1z/naOqTl48Nsr1qaQnf9bJGccfe4YHEpGlfcov+tr?= =?us-ascii?Q?fqjwX6MKPgflethI/Ic6CzOz4yvRRhxTJLlmsTka+0eo5DJiZkI6B2aVzo88?= =?us-ascii?Q?tK4EwR5Brqas6+ncJRYnD3lAYlE33n+BoZzRJIIYSE+rSV39T22u+ZGG0d2E?= =?us-ascii?Q?O8Ne/m4uE50w332v1njH13YDaIPntFa/pH9OhNiNiBp6yPAENSvdrQGS4fIT?= =?us-ascii?Q?1pT62OJIPFo8AUZ+D4D1GYeRgPZjZZahxbf5iVekt8Wj9FfJdk+wpp9C7wgX?= =?us-ascii?Q?pQ1Pfcyagyo4OtwZyJslOEBMhbFf1MhPAi/++v83HNZGAdXMB+/TUKKcN+/E?= =?us-ascii?Q?Xtju2B/8f+YPcsCkj29RoOquGO3D+EHBtmdCsnO14Xx89QOFPPtuadl6btP3?= =?us-ascii?Q?PkkxVRBaqyzvnuYV+kDq3WwDmvtumrMgdODFOjlqfslI7M4RNO0FXMlSyIUU?= =?us-ascii?Q?inyB7LRoFojthmVSjZjisV0unmGJeyMQ0hjQmE4+cMlCES31P0npvp1rwpI7?= =?us-ascii?Q?atlU50KoDcekWeIVXl6ORc63/1kW0MA9k/x8wsvIZrnqnwXkQWsCOQiemivh?= =?us-ascii?Q?kUbHLX+7gYys3OZPjWwUhOq9WVdEd8JJr0cm9tB9MdB3K7Eez0vb6GmbyyDy?= =?us-ascii?Q?8KOynYNiwHASq1Vx7yWNyQQtHwuwiIneSC+i52fX+3r4Xdy7kdoH2zfHBXOA?= =?us-ascii?Q?9Ltxdqj7gZw15xXsKEJKxAT6vogCxHblzUpbPupnYKNZ/FoZjwtxPMK9EFZd?= =?us-ascii?Q?FNKoT6BmA3qCcY6A5oIur5dlH4o0y3pm+9rh5xb+bxzGDMQKh5z8Pm4MCUQU?= =?us-ascii?Q?ft4SptNQcwP/w2zxJkpdKxk+USuhDP/fbGW1ITbVWW+mE+/kBkyiyWcQw6QD?= =?us-ascii?Q?Zg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c18ba1a1-38a6-4f06-1139-08dd02655320 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 15:27:16.8671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h7UXgnjstUZ47zNsTPcLZdJeTXKQz1yQ7N+GxJ6nyjvA1Eg3dQMcnc55i44zk19JHK853dd430z+8Hw1K60oYefGtcjhYIYy6LRQD6ygurs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7841 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Nov 08, 2024 at 11:09:23AM +0000, Praveen Shetty wrote: > Issue was reported in dpdk internal regression testing that > forwarding the packets from IDPF VF to IO ports using the cpfl > represented_port action was not working. > This patch will fix this issue. > > Fixes: 861261957684 ("net/cpfl: add checks for flow action types") > Cc: stable@dpdk.org > > Signed-off-by: Praveen Shetty > --- > drivers/net/cpfl/cpfl_flow_engine_fxp.c | 5 ----- > 1 file changed, 5 deletions(-) > Following discussion with Praveen to clarify the issue and the fix, applied with expanded commit-log message (below) to next-net-intel. """ net/cpfl: fix forwarding to physical port CPFL PMD should be able to support below traffic forwarding capabilities based on the rte flow action types. 1. Forwarding the traffic to the local CPFL vports using port_representor action. 2. Forwarding the traffic to the physical IO ports using represented_port action. 3. Forwarding the traffic to an IDPF VF using represented_port action. The 2nd use case, forwarding the traffic to IO ports using represented_port action, is not working due to the additional check added in the previous patch (861261957684 ("net/cpfl: add checks for flow action types")) This patch removes the incorrect check to fix the issue. """ Acked-by: Bruce Richardson Applied, Thanks.