Re: [PATCH] net/i40e: fix read register return status check

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Nov 19, 2024 at 11:52:38AM +0000, Bruce Richardson wrote:
> On Fri, Nov 15, 2024 at 07:14:25PM +0000, Vladimir Medvedkin wrote:
> > 'i40e_get_outer_vlan()' does not check 'i40e_aq_debug_read_register()'
> > return value. This patch fixes this issue.
> 
> I think a little more detail on the scope of the changes could be good
> here. It fixes the issue by allowing the function to return error, or zero
> on success rather than the value read. This change then causes some rework
> in the calling code to handle the error code and to change the form of the
> function call.
> 
> > 
> > Coverity issue: 445518
> > 
> > Fixes: 86eb05d6350b ("net/i40e: add flow validate function")
> > Cc: beilei.xing@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> 
> Fix below looks good, some minor comments.
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Patch applied to dpdk-next-net-intel with commit log additions and the two
minor comments on the code fixed on apply.

Thanks,
/Bruce