From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC51545D43 for ; Tue, 19 Nov 2024 13:02:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7EF642DBB; Tue, 19 Nov 2024 13:02:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 1384A40041; Tue, 19 Nov 2024 13:02:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732017776; x=1763553776; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=3v7/0fY8bnboE85zPa0h0d43xq5wTtmohFLKJ9Hz1EE=; b=BVARigTaS0AiKc4Qp1AFv8klVZdP6vRwlsZczoHd1+w84onLaRka0ud7 cDGEBjHAyaW6P4tfTrYYEMmry2kPDKRm2fmgoahX7QG6IENifsc7djUNs 52/zvmIxkuW9mQFK8ztCsVVQDVT6Gsuqb/dMSiHIcU5tFQ3lsKP4bKHUJ zFJ6X5gMtgUL9BKzf4rTX8O8oxuwQRgOP80JueZTlWpnJj5CXaDe8NjFv UDmc8hlCZikZhcj7CDHVBQ9/QvJ1G/wv8DTq6omfwa9dTHhjaB82qFuTK tLy6tDhrUIAUN+2GtoMp0eoaXhRML3MU3usq0bKSVYncv6711h9jFc3qm A==; X-CSE-ConnectionGUID: jwHUUL7fQ/OqPXZpd5CwtQ== X-CSE-MsgGUID: i0pqyEBaQ+6T+MUUhQircQ== X-IronPort-AV: E=McAfee;i="6700,10204,11260"; a="43080221" X-IronPort-AV: E=Sophos;i="6.12,166,1728975600"; d="scan'208";a="43080221" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 04:02:52 -0800 X-CSE-ConnectionGUID: 1yZtS251QqquEQWo3jYB5w== X-CSE-MsgGUID: 2DqT6o+xQoOOWpV6tvw+Tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,166,1728975600"; d="scan'208";a="93605263" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Nov 2024 04:02:51 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 19 Nov 2024 04:02:50 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 19 Nov 2024 04:02:50 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 19 Nov 2024 04:02:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aFK6b0+kAEIDM6nvAn0uNM9BB5QldQAO15+620Shpb5EMzwaZLZNqDwTBs1pwENdFR1pbEClvTQA1KcBP7PuzqQe/uy0d6MsRneVr34Yb81Uol/XEhi9fe0jyj+oOVWkCUpDbYM2fD1N1vN3rbkq20Ub+EFwSeYr5KxAd8qWycwg6QMDKQthxseigKEVfd/2SuZM7KKJ+CtYEIkDC4tqZZyTpVxEjaGcBr9mLl5VsGh2hu8S55psX7jjc1eHIkICrf89I+ssT4QeWs9u4x6ylVlPFVFsR7O8oZQktZscKW7dLVJRMO1uZe7usO1hWTTyIEGOxEQByxOzNBTD7SwkFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UPEqsOCGSUeG2ZDmrxU63NYt381l+6oOIRMuYyc9mY0=; b=XYAjNxIrTgDEYGH+Y0v519VhT1JAF7BptCy8HOCtc8VRVx9ogUAEbOW3Kmj9x7U7e66zM28yiCWiJ2DMFwX1+expmxd09slyI2awJYSlbFBW5nEHrGxl8zsvO24UHKIJd8IlvcK+sDCZNzWIqTEO3CSDssK107cZyo+WpaJWZ6GqpTPNKZ1/mo6kyQclMnYpP5dGqBbVnowC3O8eupAVFJURsnJ4orKD5DPI2J00XtKGyaLJPeouTVntzobPT/UscAXpoZez+p9tlcjJQ4+Ngw672eNuMIRrOqk8mxQglB4QawZFUUNh65rmNKCNzrw7BTT3sLNGC8k3EziUraDyCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA3PR11MB7485.namprd11.prod.outlook.com (2603:10b6:806:31c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.22; Tue, 19 Nov 2024 12:02:43 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%4]) with mapi id 15.20.8093.018; Tue, 19 Nov 2024 12:02:43 +0000 Date: Tue, 19 Nov 2024 12:02:37 +0000 From: Bruce Richardson To: Vladimir Medvedkin CC: , Subject: Re: [PATCH] net/i40e: fix read register return status check Message-ID: References: <20241115191425.970929-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8PR09CA0009.eurprd09.prod.outlook.com (2603:10a6:10:a0::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA3PR11MB7485:EE_ X-MS-Office365-Filtering-Correlation-Id: fa677da3-06cc-46fb-8a63-08dd089212b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SUkfsrjPaeH/cokeZCEn0UPE3wFr43/j5DNv346ObTVl66w7qeefBzDvAYqS?= =?us-ascii?Q?9LD3QeIlIOUG/MRVfu9N7ubERSMY4VrmESQXMxOzguRfPpl0ofgXJmrodJAo?= =?us-ascii?Q?8kPzZLVr2igMqoivnWqTHgm9cs2enxKyOGjb86b4Ll2eCFedorfkTSR/yvtb?= =?us-ascii?Q?ZGfQ9R6ui+EbiN+8onaKhGha+2oVHy5usa2U/RgUVjVQDSeydrFoMXC1os2E?= =?us-ascii?Q?aPP8CurweulFxWeRJg4rtxKhKhve9Py2ustZdC3Py5A11zatFXcpJSoZ+g83?= =?us-ascii?Q?4D3Sun29ezPivJC5fvt9rH+TxOo3aVSH23x6YBH3v11JhIuMRbjj4tXKfUml?= =?us-ascii?Q?1rHG+QHXEojKWI1BmSrwekvJO1PRWB3mPonwD2LgEjoxzb+5fZnYorc7OnP/?= =?us-ascii?Q?QmN/BLGLd/J0kjGg4prMAFJE7LFHw2Udo4lnddiJo3sJmU+7ENs5oieR4KqX?= =?us-ascii?Q?TUHfDIK7JXhdkwY4axD5dfAvUj82MteolzWEWgNbFsNlKBvZkpLvWV6ltxhC?= =?us-ascii?Q?mPNpDj9M2zGCiDH+uZhi0PPDuxnDPjybh5Pj14N4YvTIIlYS5ZxAivzReQau?= =?us-ascii?Q?i8qRDXR+jkcZP9b4L8v9eaMTEBv4cdfRL8lYouTqK5YroQiFwR8Q/cjh/FWV?= =?us-ascii?Q?RLyJAIMkIcS1fC3ieP+RA/HEJFzt73aavZ3CHk6WLuIS5AkgqtR+bAmKjE8d?= =?us-ascii?Q?bSEMTvQ6zVQ5G6cAEOdvxxYmXvmUe6wsTjiV2eEs6sloIZPxbJlC6l9OGvuI?= =?us-ascii?Q?6bHX6YKkf55D/3I0tYLuhvHvhP/OCMNW8n0uErwz3y2D/U0IcTXmadU0yoKo?= =?us-ascii?Q?0JRQ3Y9DuiubEnQCNqWrU4/dsPjDT5dsa14NlgFwi8PNnOc8MhDc7y9vDvfe?= =?us-ascii?Q?MS/2qwegpakTY5AxqME9zBTo+lX8R+i2ww3v7b6mO2g5OCZgG0oUQap4Js3k?= =?us-ascii?Q?NQ3s3GJ+yfUFEJ7fm1AZhWFcrSIWYLg6wu1KNHaYNa/4/5aNC+R7Vow5rYDx?= =?us-ascii?Q?UXeeYLtHUif/dA4//J7KY6FUydZbsVQYK3E95uhrmziveD4/cvK0KlvBicVr?= =?us-ascii?Q?pAyl5SLOGqPh4QbTs6ItKbhsSx+G9YckLyWNi9osbj6B28O+RgBrlqsMST5P?= =?us-ascii?Q?gR80oBvDFW13M2mJaA3qVroXsZ4jU5AQM2AgxqrvHJfxLPSuRz2PtVy+1JU5?= =?us-ascii?Q?AvZkGCFatNaxhIIk5Zh6oLtddGLLiG+599r+Mq/X3PD9nzfUos5yiKyBIU09?= =?us-ascii?Q?d4x28vA56g9QO3nUzunpDC1bgt8MWUhrK5VBY6LchjcXpXYK2xl7cP9eLbpb?= =?us-ascii?Q?2Gk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YaITcr3lLimj0HUI6lsDUecaQM+UKEq1LosGdI8qJHLL4XG31LPew5YaEy4h?= =?us-ascii?Q?gJaYWDwhlB4KB3tPEVheHr4BhzzfYPhy9nQVtBH/h+BHhqXqD8MPcuhOnSCa?= =?us-ascii?Q?3+7BGttjjvo7YU5Sr3uBVe+2so7AQbuIl0oW9WvP7m0Lu14oy+XL6UzGBxK3?= =?us-ascii?Q?gv0qB3nlXcpefsAdVi2WttzomxjsI9MMMbHv/Yxox3/MEdJePYiiLQ7SHPvQ?= =?us-ascii?Q?wN27hHwJD6h7Qne7dPe9fN6ng+oEjuPA6qw6Mjw7gnwvdhy9Fnrg+6OnY6xv?= =?us-ascii?Q?43WHJCSmbrfvdhejLX54SdwA6kyzks0J5lP0i8IJzjXOjGiModT/vWBuKl55?= =?us-ascii?Q?BomoxjzXO63/fjcL2PDLzntOkNTf3/eKJyxAC+zCZgylVpOYsQjbQkU6upwM?= =?us-ascii?Q?NAUiZ/8PnoazStevvCzRsXOJ3qZbGYpw47FEtOGEueWMcZfMdQ52I7QaQBdz?= =?us-ascii?Q?hLpSqSdF/osiKauAZJH8P0QMI8ud9qbxTH1eKC51DvQo82tCZIx3K+ExmbOk?= =?us-ascii?Q?OpulSYr9DbGZHFGVkKSIySJaMF56LprufAHtb+So0fyPiyrI1dQcu1oe3378?= =?us-ascii?Q?2nXajqiDXAOKaZZb6MzrYN9RJzWN6igSuOTVW1/jczG982Lrt7jfNhvUNW8a?= =?us-ascii?Q?rvsBLymMlI+uMfvB8xaf4waMlXo4pGa48cXj5o15jWxogAsTyDo5d4EzMVoi?= =?us-ascii?Q?zV/WEilB/hLB9pCMQPXYSFa+7MXK/pb+/Gz0UOqLu1F6e4CG0fA3zoTJEprM?= =?us-ascii?Q?seHRNu6GnXCXKP2Wy9sBqkmSISThncvfK1mDjEbeU3zfMEmPgEkIgPe8auYN?= =?us-ascii?Q?FEVFFSuVAAR+eya6B99VFVZcgpRz0WE0jbj7KaMa9xE+itROGRoTof6osoNq?= =?us-ascii?Q?bTvr6vlVMxjpxpxeuWL0mFd9zhR0Exe0nWZAPa+FobFXnUHCXt53TQMtjsrR?= =?us-ascii?Q?H8q3lPZuSJkWdlxPxMa57DvjtS6Cv4plkumIF8mPkIvufdqnArTNr7rMFONk?= =?us-ascii?Q?mA5AL0dtu0qSWW/2UPDzOyrJOKarie0UXbYiTBIC2/U94RpQbNN+EQpbWYFw?= =?us-ascii?Q?dKsaOrZdxxiZdtE0Jz2lIUZnFHsvMeZ+wT0/uw51jkBu0kYGfpkEE2qc1EgJ?= =?us-ascii?Q?YNlleCthpkvD2hu+dXOhy8iN4pubCaqcu1383yQBXLGpiNnA1MOaRxAytHxC?= =?us-ascii?Q?wPkLX7qMQqbpGvLlZ7fxcmuQsrjHwcvJJhZgNxYrMaJCZ38BK2VWGwdNZywa?= =?us-ascii?Q?OT7U/s2j425YpOkpVjA+DPG9GauRtNU7VanjXBQ0ktSZ5hagkiWezVIDDN43?= =?us-ascii?Q?yRLb0DHK5sy+RqW4b982jl47y6y99kwoUV8t/DdIWNA+pFdJtFpvFRZaG4S1?= =?us-ascii?Q?UV8X1qVHZhzyoHg/fXWCDWJ91SyqqG6+psUUQ0SL2Zjp1ZFalgNkmN+Sc0se?= =?us-ascii?Q?89xLGTzG9IxXWhL+Y5qhIcG0NsaqBghn/HgM1gnXlPWOQD7GljeLAFQ6J1vw?= =?us-ascii?Q?AeCFlFxKAnFZvlO4G+sWBGcsk1/SXYRGDp51kxJc+9gEgnuwC1yM54bXirsr?= =?us-ascii?Q?HF2k5Tbil2UjmhIyhTcCp/pBpYQLO3yIi+TQYBgxlizmvsBZDbLzWlUgBwP3?= =?us-ascii?Q?pw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: fa677da3-06cc-46fb-8a63-08dd089212b2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2024 12:02:42.9682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fRtmxJIX1Z5bCKbxOqayJ884Fpm3BuulW+bL5s2xumTE2J4nK/dtJN/o9IsbA6FQfWC4uavaUW0saW9v4L3Anfr0bEIzjZZCl+3+jqrowDU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7485 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Nov 19, 2024 at 11:52:38AM +0000, Bruce Richardson wrote: > On Fri, Nov 15, 2024 at 07:14:25PM +0000, Vladimir Medvedkin wrote: > > 'i40e_get_outer_vlan()' does not check 'i40e_aq_debug_read_register()' > > return value. This patch fixes this issue. > > I think a little more detail on the scope of the changes could be good > here. It fixes the issue by allowing the function to return error, or zero > on success rather than the value read. This change then causes some rework > in the calling code to handle the error code and to change the form of the > function call. > > > > > Coverity issue: 445518 > > > > Fixes: 86eb05d6350b ("net/i40e: add flow validate function") > > Cc: beilei.xing@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Vladimir Medvedkin > > Fix below looks good, some minor comments. > > Acked-by: Bruce Richardson > Patch applied to dpdk-next-net-intel with commit log additions and the two minor comments on the code fixed on apply. Thanks, /Bruce