From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A4A683B5; Fri, 17 Feb 2017 17:48:03 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 17 Feb 2017 08:48:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,172,1484035200"; d="scan'208";a="226619248" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga004.fm.intel.com with ESMTP; 17 Feb 2017 08:48:01 -0800 To: "Wiles, Keith" References: <20170217154304.50214-1-keith.wiles@intel.com> <37245ce5-de84-27fb-14a7-36ad8934a8d6@intel.com> <93F4E359-E193-477D-97AD-E758BF755E75@intel.com> Cc: "dev@dpdk.org" , dpdk stable From: Ferruh Yigit Message-ID: Date: Fri, 17 Feb 2017 16:48:01 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <93F4E359-E193-477D-97AD-E758BF755E75@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/tap: fix coverity warning on strncpy X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2017 16:48:04 -0000 On 2/17/2017 4:34 PM, Wiles, Keith wrote: > >> On Feb 17, 2017, at 10:21 AM, Yigit, Ferruh wrote: >> >> On 2/17/2017 3:43 PM, Keith Wiles wrote: >>> Calling strncpy with a maximum size argument of 16 bytes on destination >>> array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the >>> destination string unterminated. >>> >>> Signed-off-by: Keith Wiles >> >> net/tap: fix possibly unterminated string >> >> Coverity issue: 1407499 >> Fixes: 6b38b2725cdb ("net/tap: fix multi-queue support") >> Cc: stable@dpdk.org >> >> Applied to dpdk-next-net/master, thanks. >> >> >> (Updates: >> - patch title: >> It is preferred to mention from problem solved instead of the tool that >> found it. >> >> - Added coverity tag: >> This helps to trace coverity issues, defined syntax is: >> >> Coverity issue: xxx >> Fixes: yyyy >> >> - Added Cc: tag for stable tree: >> In case stable tree wants get this patch, to make patch visible. > > I agree this is good, but to many rules not listed or checked in the tools. We need a much easier method to submit patches in the format that is defined and checked. > > Today it is way to hard to know every little internal format for every type of patch. We need to fix this problem to make it easier to submit patches to dpdk.org, we can not continue like this as we grow it will become way to much work for the repo maintainers and the submitter. That is why I am documenting what has been changed and the reasoning in the mail, so I am hoping this is helping others that following the mail list sync about rules. Also gives a discussion medium about rules.. > > Using a better tool then submitting via email seems like a better solution as long as we can add the given checks to the tool. Using a tools should also reduce the email traffic for most everyone, but we need to allow anyone to ask for all of the commits to the repo or pull requests like patches. > > How can we handle these types of issues in the future? > >> ) > > Regards, > Keith >